BuzzbeeSCD/ProjectE
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: remove selectedNoteId state entirely to prevent parent re-render focus stealing

Browse Source
This commit is contained in:
Hermes
2026-08-01 13:22:23 +00:00
parent a673d77d58
commit 58e563f21d
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/src/routes/_app/notes.tsx
+5 -5
View File
@@ -149,7 +149,7 @@ const NoteEditorPane = memo(function NoteEditorPane({ note, onDelete }: { note:
function NotesPage() { function NotesPage() {
const queryClient = useQueryClient(); const queryClient = useQueryClient();
const [search, setSearch] = useState(""); const [search, setSearch] = useState("");
const [selectedNoteId, setSelectedNoteId] = useState<string | null>(null); const selectedNoteIdRef = useRef<string | null>(null);
const selectedNoteRef = useRef<Note | null>(null); const selectedNoteRef = useRef<Note | null>(null);
useRealtime({ enabled: true }); useRealtime({ enabled: true });
@@ -166,7 +166,7 @@ function NotesPage() {
onSuccess: (note) => { onSuccess: (note) => {
queryClient.invalidateQueries({ queryKey: ["notes"] }); queryClient.invalidateQueries({ queryKey: ["notes"] });
selectedNoteRef.current = note; selectedNoteRef.current = note;
setSelectedNoteId(note.id); selectedNoteIdRef.current = note.id;
}, },
}); });
@@ -175,7 +175,7 @@ function NotesPage() {
onSuccess: () => { onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ["notes"] }); queryClient.invalidateQueries({ queryKey: ["notes"] });
selectedNoteRef.current = null; selectedNoteRef.current = null;
setSelectedNoteId(null); selectedNoteIdRef.current = null;
}, },
}); });
@@ -186,7 +186,7 @@ function NotesPage() {
} catch { } catch {
selectedNoteRef.current = note; selectedNoteRef.current = note;
} }
setSelectedNoteId(note.id); selectedNoteIdRef.current = note.id;
}; };
const selectedNote = selectedNoteRef.current; const selectedNote = selectedNoteRef.current;
@@ -219,7 +219,7 @@ function NotesPage() {
onClick={() => selectNote(note)} onClick={() => selectNote(note)}
className={cn( className={cn(
"w-full text-left px-3 py-2 rounded-md text-sm transition-colors", "w-full text-left px-3 py-2 rounded-md text-sm transition-colors",
selectedNoteId === note.id ? "bg-accent text-accent-foreground" : "hover:bg-accent/50" selectedNoteIdRef.current === note.id ? "bg-accent text-accent-foreground" : "hover:bg-accent/50"
)} )}
> >
<div className="flex items-center gap-2"> <div className="flex items-center gap-2">