79 lines
3.1 KiB
JavaScript
79 lines
3.1 KiB
JavaScript
|
import { describe, expect, it } from 'vitest';
|
||
|
|
import { buildDigest } from './digest.js';
|
||
|
|
import { isGeneratedArtifact } from './generated.js';
|
||
|
|
|
||
|
|
const fileDiff = (path, body = '+const a = 1;') => `diff --git a/${path} b/${path}
|
||
|
|
--- a/${path}
|
||
|
|
+++ b/${path}
|
||
|
|
@@ -1,1 +1,2 @@
|
||
|
|
${body}
|
||
|
|
`;
|
||
|
|
|
||
|
|
describe('isGeneratedArtifact', () => {
|
||
|
|
it('matches lockfiles by exact name anywhere in the tree', () => {
|
||
|
|
expect(isGeneratedArtifact('bun.lock')).toBe(true);
|
||
|
|
expect(isGeneratedArtifact('packages/web/package-lock.json')).toBe(true);
|
||
|
|
expect(isGeneratedArtifact('Cargo.lock')).toBe(true);
|
||
|
|
expect(isGeneratedArtifact('go.sum')).toBe(true);
|
||
|
|
});
|
||
|
|
|
||
|
|
it('matches conventional generated output', () => {
|
||
|
|
expect(isGeneratedArtifact('dist/app.min.js')).toBe(true);
|
||
|
|
expect(isGeneratedArtifact('src/api.generated.ts')).toBe(true);
|
||
|
|
expect(isGeneratedArtifact('proto/user.pb.go')).toBe(true);
|
||
|
|
expect(isGeneratedArtifact('src/__snapshots__/App.test.tsx.snap')).toBe(true);
|
||
|
|
expect(isGeneratedArtifact('src/generated/client.ts')).toBe(true);
|
||
|
|
});
|
||
|
|
|
||
|
|
it('does not match authored source that merely looks similar', () => {
|
||
|
|
// A false positive silently removes real code from the review, so these
|
||
|
|
// near-misses matter more than the hits.
|
||
|
|
expect(isGeneratedArtifact('src/lock.ts')).toBe(false);
|
||
|
|
expect(isGeneratedArtifact('src/useLockfile.ts')).toBe(false);
|
||
|
|
expect(isGeneratedArtifact('src/generator.ts')).toBe(false);
|
||
|
|
expect(isGeneratedArtifact('src/minifier.ts')).toBe(false);
|
||
|
|
expect(isGeneratedArtifact('packages/ui/src/lib/i18n/messages/en.ts')).toBe(false);
|
||
|
|
});
|
||
|
|
});
|
||
|
|
|
||
|
|
describe('buildDigest', () => {
|
||
|
|
const sections = [{
|
||
|
|
scope: 'working',
|
||
|
|
patch: [fileDiff('src/a.ts'), fileDiff('bun.lock', '+ "version": "2",'), fileDiff('src/b.ts')].join(''),
|
||
|
|
}];
|
||
|
|
|
||
|
|
it('keeps generated files out of what the model sees', () => {
|
||
|
|
const built = buildDigest(sections);
|
||
|
|
|
||
|
|
expect(built.digest.files.map((file) => file.path)).toEqual(['src/a.ts', 'src/b.ts']);
|
||
|
|
expect(JSON.stringify(built.digest)).not.toContain('bun.lock');
|
||
|
|
expect(built.fileCount).toBe(2);
|
||
|
|
expect(built.hunkCount).toBe(2);
|
||
|
|
expect(built.generatedFileCount).toBe(1);
|
||
|
|
expect(built.generatedPaths).toEqual(['bun.lock']);
|
||
|
|
});
|
||
|
|
|
||
|
|
it('still returns generated files to the client so nothing disappears', () => {
|
||
|
|
const built = buildDigest(sections);
|
||
|
|
|
||
|
|
expect(built.files.map((file) => file.path)).toEqual(['src/a.ts', 'bun.lock', 'src/b.ts']);
|
||
|
|
expect(built.files.find((file) => file.path === 'bun.lock')?.generated).toBe(true);
|
||
|
|
});
|
||
|
|
|
||
|
|
it('gives aliases only to reviewable hunks', () => {
|
||
|
|
const built = buildDigest(sections);
|
||
|
|
const aliased = [...built.idByAlias.values()];
|
||
|
|
|
||
|
|
expect([...built.idByAlias.keys()]).toEqual(['h1', 'h2']);
|
||
|
|
expect(aliased.some((id) => id.includes('bun.lock'))).toBe(false);
|
||
|
|
});
|
||
|
|
|
||
|
|
it('reports zero reviewable hunks when only generated files changed', () => {
|
||
|
|
const built = buildDigest([{ scope: 'working', patch: fileDiff('bun.lock', '+ "version": "2",') }]);
|
||
|
|
|
||
|
|
expect(built.hunkCount).toBe(0);
|
||
|
|
expect(built.files).toHaveLength(1);
|
||
|
|
expect(built.generatedFileCount).toBe(1);
|
||
|
|
});
|
||
|
|
});
|