fix: match root project sessions in switcher (#1274)
* fix: match root project sessions in switcher * test: cover project path matching edge cases --------- Co-authored-by: Isaac Sanchez <isanchez-hawkins@arize.com>
This commit is contained in:
committed by
GitHub
co-authored by
Isaac Sanchez
parent
9c71119835
commit
00c112077d
@@ -7,7 +7,7 @@ import { useSessionPinnedStore } from '@/stores/useSessionPinnedStore';
|
|||||||
import { useGitAllBranches, useGitStore } from '@/stores/useGitStore';
|
import { useGitAllBranches, useGitStore } from '@/stores/useGitStore';
|
||||||
import { useRuntimeAPIs } from '@/hooks/useRuntimeAPIs';
|
import { useRuntimeAPIs } from '@/hooks/useRuntimeAPIs';
|
||||||
import type { SessionNode } from '../types';
|
import type { SessionNode } from '../types';
|
||||||
import { compareSessionsByPinnedAndTime } from '../utils';
|
import { compareSessionsByPinnedAndTime, isPathWithinProject } from '../utils';
|
||||||
|
|
||||||
export type SwitcherItem = {
|
export type SwitcherItem = {
|
||||||
node: SessionNode;
|
node: SessionNode;
|
||||||
@@ -60,7 +60,7 @@ export const useSwitcherItems = (enabled: boolean, options: SwitcherItemsOptions
|
|||||||
(directory: string | null) => {
|
(directory: string | null) => {
|
||||||
if (!directory) return null;
|
if (!directory) return null;
|
||||||
const matches = normalizedProjects
|
const matches = normalizedProjects
|
||||||
.filter((project) => directory === project.normalizedPath || directory.startsWith(`${project.normalizedPath}/`))
|
.filter((project) => isPathWithinProject(directory, project.normalizedPath))
|
||||||
.sort((a, b) => (b.normalizedPath?.length ?? 0) - (a.normalizedPath?.length ?? 0));
|
.sort((a, b) => (b.normalizedPath?.length ?? 0) - (a.normalizedPath?.length ?? 0));
|
||||||
return matches[0] ?? null;
|
return matches[0] ?? null;
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -0,0 +1,29 @@
|
|||||||
|
import { describe, expect, test } from 'bun:test';
|
||||||
|
|
||||||
|
import { isPathWithinProject } from './utils';
|
||||||
|
|
||||||
|
describe('isPathWithinProject', () => {
|
||||||
|
test('matches child directories for root projects', () => {
|
||||||
|
expect(isPathWithinProject('/workspace/app', '/')).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('matches exact project directories', () => {
|
||||||
|
expect(isPathWithinProject('/workspace/app', '/workspace/app')).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('does not match sibling directory prefixes', () => {
|
||||||
|
expect(isPathWithinProject('/workspace/app2', '/workspace/app')).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('returns false when directory is null', () => {
|
||||||
|
expect(isPathWithinProject(null, '/workspace/app')).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('returns false when projectPath is null', () => {
|
||||||
|
expect(isPathWithinProject('/workspace/app', null)).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('matches deep child directories', () => {
|
||||||
|
expect(isPathWithinProject('/workspace/app/sub/dir', '/workspace/app')).toBe(true);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -81,6 +81,15 @@ export const normalizePath = (value?: string | null) => {
|
|||||||
return normalized.length === 0 ? '/' : normalized;
|
return normalized.length === 0 ? '/' : normalized;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const isPathWithinProject = (directory?: string | null, projectPath?: string | null): boolean => {
|
||||||
|
const normalizedDirectory = normalizePath(directory);
|
||||||
|
const normalizedProjectPath = normalizePath(projectPath);
|
||||||
|
if (!normalizedDirectory || !normalizedProjectPath) return false;
|
||||||
|
if (normalizedDirectory === normalizedProjectPath) return true;
|
||||||
|
if (normalizedProjectPath === '/') return normalizedDirectory.startsWith('/');
|
||||||
|
return normalizedDirectory.startsWith(`${normalizedProjectPath}/`);
|
||||||
|
};
|
||||||
|
|
||||||
export const normalizeForBranchComparison = (value: string): string => {
|
export const normalizeForBranchComparison = (value: string): string => {
|
||||||
return value
|
return value
|
||||||
.toLowerCase()
|
.toLowerCase()
|
||||||
|
|||||||
Reference in New Issue
Block a user