fix(tooling): resolve Bun executable on Windows
This commit is contained in:
@@ -29,6 +29,8 @@ import path from 'node:path';
|
||||
import { createRequire } from 'node:module';
|
||||
import { fileURLToPath, pathToFileURL } from 'node:url';
|
||||
|
||||
import { resolveBunExecutable } from '../../../scripts/lib/bun-executable.mjs';
|
||||
|
||||
const __filename = fileURLToPath(import.meta.url);
|
||||
const __dirname = path.dirname(__filename);
|
||||
const repoElectronDir = path.resolve(__dirname, '..');
|
||||
@@ -225,7 +227,11 @@ export function isComplete(electronDir, expected = expectedArch()) {
|
||||
return true;
|
||||
}
|
||||
|
||||
function resolveInstallCommands(env) {
|
||||
function resolveInstallCommands(env, bunResolver = resolveBunExecutable) {
|
||||
const normalize = (commands) => commands.map(([bin, args]) => [
|
||||
bin === 'bun' ? bunResolver({ env }) : bin,
|
||||
args,
|
||||
]);
|
||||
if (env.OPENCHAMBER_ELECTRON_INSTALL_COMMANDS) {
|
||||
try {
|
||||
const parsed = JSON.parse(env.OPENCHAMBER_ELECTRON_INSTALL_COMMANDS);
|
||||
@@ -233,22 +239,22 @@ function resolveInstallCommands(env) {
|
||||
Array.isArray(parsed) &&
|
||||
parsed.every((command) => Array.isArray(command) && typeof command[0] === 'string')
|
||||
) {
|
||||
return parsed;
|
||||
return normalize(parsed);
|
||||
}
|
||||
} catch {
|
||||
// Fall through to the default commands.
|
||||
}
|
||||
}
|
||||
return [
|
||||
return normalize([
|
||||
['bun', ['install.js']],
|
||||
['node', ['install.js']],
|
||||
];
|
||||
]);
|
||||
}
|
||||
|
||||
export function repair(electronDir, options = {}) {
|
||||
const env = options.env ?? process.env;
|
||||
const runner = options.runner ?? spawnSync;
|
||||
const commands = options.commands ?? resolveInstallCommands(env);
|
||||
const commands = options.commands ?? resolveInstallCommands(env, options.bunResolver);
|
||||
|
||||
// A partial extraction can leave stale entries (and a stale path.txt) that
|
||||
// a re-run would merge with. Start clean so the repair is deterministic.
|
||||
@@ -265,6 +271,7 @@ export function repair(electronDir, options = {}) {
|
||||
cwd: electronDir,
|
||||
stdio: options.stdio ?? 'inherit',
|
||||
env: { ...env, ELECTRON_SKIP_BINARY_DOWNLOAD: undefined },
|
||||
windowsHide: true,
|
||||
});
|
||||
if (result.error) {
|
||||
console.warn(`[electron:ensure] could not run \`${label}\`: ${result.error.message}`);
|
||||
|
||||
@@ -259,6 +259,32 @@ test('repair skips a command whose runner errors and keeps trying the rest', (t)
|
||||
assert.deepEqual(calls, commands);
|
||||
});
|
||||
|
||||
test('repair resolves Bun before invoking the install command', (t) => {
|
||||
const dir = withFixture(t);
|
||||
const calls = [];
|
||||
const resolvedBun = 'C:\\npm\\node_modules\\bun\\bin\\bun.exe';
|
||||
const result = repair(dir, {
|
||||
env: { TEST_ENV: 'present' },
|
||||
bunResolver: ({ env }) => {
|
||||
assert.equal(env.TEST_ENV, 'present');
|
||||
return resolvedBun;
|
||||
},
|
||||
runner: (bin, args, options) => {
|
||||
calls.push([bin, args, options.windowsHide]);
|
||||
if (bin !== resolvedBun) return { status: 1 };
|
||||
const platform = platformPath();
|
||||
fs.mkdirSync(path.join(dir, 'dist', path.dirname(platform)), { recursive: true });
|
||||
fs.writeFileSync(path.join(dir, 'dist', 'version'), '41.2.1');
|
||||
fs.writeFileSync(path.join(dir, 'path.txt'), platform);
|
||||
fs.writeFileSync(path.join(dir, 'dist', platform), headerBytesForArch(expectedArch()));
|
||||
return { status: 0 };
|
||||
},
|
||||
});
|
||||
|
||||
assert.equal(result, true);
|
||||
assert.deepEqual(calls, [[resolvedBun, ['install.js'], true]]);
|
||||
});
|
||||
|
||||
test('repair returns false when the runner reports a failure status for every command', (t) => {
|
||||
const dir = withFixture(t);
|
||||
const calls = [];
|
||||
|
||||
Reference in New Issue
Block a user