perf(sessions): archive a worktree's sessions through one server batch

Removing a worktree archived its sessions one SDK call at a time and
then re-rendered the whole sidebar once per streamed session.updated
echo. On a worktree with 121 sessions that meant 14.8s of main-thread
work, 121 requests, and 328 localStorage writes.

- Add POST /api/openchamber/sessions/archive: validates a batch (max
  500 ids, per-request archivedAt), archives sequentially, and reports
  partial failures instead of dropping the batch. VS Code serves no
  such route and answers 501; the shared UI then falls back to the
  per-session path.
- Plan batches from the sessions this client actually holds, live
  directory stores first, so worktree-only sessions still batch.
- Claim (id, archivedAt) pairs before the request and consume the
  matching session.updated echoes, so the server's own confirmations
  no longer fan out into 121 store publications. Runtime-scoped, TTL
  30s, released on response or fallback; non-matching updates pass.
- Make the managed-chats persistence a real trailing debounce instead
  of a 50ms throttle, so a burst of publications coalesces into one
  localStorage write.

Benchmark (121 sessions, production build, real Chrome): 14785ms ->
~1030ms, long tasks 100 -> 1, global store publications 236 -> 1,
persistence writes 328 -> 3.
This commit is contained in:
Iuliia Ivashko
2026-09-04 16:50:03 +03:00
parent 0d8709a72e
commit 0ef189f3c8
11 changed files with 769 additions and 15 deletions
+202 -11
View File
@@ -33,6 +33,8 @@ import { getBtwOriginalSessionID, getBtwSessionID, isBtwSession, withoutBtwSessi
import { withLinkedIssue, type LinkedIssue } from "@/lib/linkedIssues"
import { getImperativeSessionMessageLoader } from "./session-message-loader"
import { cleanupPersistedSessionState } from "./session-deletion-cleanup"
import { requestSessionArchiveBatch } from "./session-archive-batch"
import { registerBulkArchiveEchoes, releaseBulkArchiveEchoes } from "./bulk-archive-echo"
import { getRuntimeKey } from "@/lib/runtime-switch"
import { markAmbiguousTransportFailure } from "@/lib/relay/transport-error"
import { getErrorStatus, isAmbiguousSendFailure } from "./send-failure-classification"
@@ -75,20 +77,29 @@ let _optimisticAdd: ((input: OptimisticAddInput) => void) | null = null
let _optimisticRemove: ((input: OptimisticRemoveInput) => void) | null = null
let _optimisticConfirm: ((input: OptimisticConfirmInput) => void) | null = null
function sessionMutationPatch(
/**
* Revision patch for one or more sessions changing in the same store write.
*
* A batch bumps the revision once, because it is one state change: consumers
* compare revisions to decide whether their view of the list is stale, and a
* batch leaves them stale exactly once rather than once per session.
*/
function sessionsMutationPatch(
state: ReturnType<DirectoryStoreApi["getState"]>,
sessionId: string,
sessionIds: Iterable<string>,
deleted: boolean,
) {
const revision = (state.sessionRevision ?? 0) + 1
const sessionEventRevision = { ...(state.sessionEventRevision ?? {}) }
const sessionDeletedRevision = { ...(state.sessionDeletedRevision ?? {}) }
if (deleted) {
sessionDeletedRevision[sessionId] = revision
delete sessionEventRevision[sessionId]
} else {
sessionEventRevision[sessionId] = revision
delete sessionDeletedRevision[sessionId]
for (const sessionId of sessionIds) {
if (deleted) {
sessionDeletedRevision[sessionId] = revision
delete sessionEventRevision[sessionId]
} else {
sessionEventRevision[sessionId] = revision
delete sessionDeletedRevision[sessionId]
}
}
return {
sessionListSource: "live" as const,
@@ -98,6 +109,14 @@ function sessionMutationPatch(
}
}
function sessionMutationPatch(
state: ReturnType<DirectoryStoreApi["getState"]>,
sessionId: string,
deleted: boolean,
) {
return sessionsMutationPatch(state, [sessionId], deleted)
}
function invalidateSessionLoads(sessionId: string, directories: Iterable<string | null | undefined>): void {
const loader = getImperativeSessionMessageLoader()
if (!loader) return
@@ -1039,6 +1058,50 @@ function removeSessionFromLiveStores(sessionId: string, preferredDirectory?: str
return snapshots
}
/**
* Remove a batch of server-confirmed sessions from every live child store.
*
* Each affected store is written once for the whole batch. Removing the
* sessions one at a time notified every subscriber — and therefore re-rendered
* the sidebar — once per session, which is what made archiving a worktree's
* sessions block the main thread for seconds.
*/
function removeSessionsFromLiveStores(sessionIds: Iterable<string>, preferredDirectory?: string): SessionListSnapshot[] {
const ids = new Set(sessionIds)
if (!_childStores || ids.size === 0) return []
const snapshots: SessionListSnapshot[] = []
const visited = new Set<string>()
const candidates: Array<[string, DirectoryStoreApi]> = []
if (preferredDirectory) {
const preferredStore = _childStores.children.get(preferredDirectory)
if (preferredStore) {
candidates.push([preferredDirectory, preferredStore])
visited.add(preferredDirectory)
}
}
for (const entry of _childStores.children.entries()) {
if (visited.has(entry[0])) continue
candidates.push(entry)
}
for (const [directory, store] of candidates) {
const current = store.getState()
const removed = current.session.filter((session) => ids.has(session.id)).map((session) => session.id)
if (removed.length === 0) continue
snapshots.push({ directory })
store.setState({
session: current.session.filter((session) => !ids.has(session.id)),
...sessionsMutationPatch(current, removed, true),
})
}
return snapshots
}
function cleanupSessionWorktreeMetadata(sessionId: string): void {
useSessionUIStore.getState().setWorktreeMetadata(sessionId, null)
}
@@ -1252,7 +1315,14 @@ export type ArchiveSessionsOptions = {
}
/**
* Archive several sessions sequentially, preserving partial results.
* Archive several sessions, preserving partial results.
*
* Sessions that carry no review or btw link are archived by their directory's
* server in one request, and the whole answer is reconciled with a single store
* write. The remainder — review sessions, btw forks, sessions with an active
* btw fork, and any session this client does not hold — keep the per-session
* path, because unlinking a partner is UI-owned work that reads and rewrites
* another session's metadata.
*
* One failed session never blocks or erases the others: it is reported in
* `failedIds` while the remaining IDs are still attempted. When
@@ -1269,10 +1339,55 @@ export async function archiveSessions(
const archivedIds: string[] = []
const failedIds: string[] = []
const expectedRuntimeKey = options?.expectedRuntimeKey ?? getRuntimeKey()
if (ids.length === 0) return { archivedIds, failedIds }
for (const [index, id] of ids.entries()) {
const plan = planArchiveBatches(ids)
for (const [directory, batchIds] of plan.batchesByDirectory) {
if (isStaleRuntime(expectedRuntimeKey)) {
failedIds.push(...ids.slice(index))
failedIds.push(...batchIds)
continue
}
const archivedAt = Date.now()
registerBulkArchiveEchoes(
expectedRuntimeKey,
batchIds.map((id) => ({ id, archivedAt })),
)
const result = await requestSessionArchiveBatch(directory, batchIds, archivedAt)
if (isStaleRuntime(expectedRuntimeKey)) {
failedIds.push(...batchIds)
continue
}
if (result.outcome === "archived") {
releaseBulkArchiveEchoes(expectedRuntimeKey, batchIds)
registerBulkArchiveEchoes(
expectedRuntimeKey,
result.archived.flatMap((session) => (
session.time?.archived === undefined
? []
: [{ id: session.id, archivedAt: session.time.archived }]
)),
)
commitArchivedSessions(result.archived, directory)
archivedIds.push(...result.archived.map((session) => session.id))
failedIds.push(...result.failedIds)
continue
}
// The runtime does not serve the batch route, or its answer could not be
// trusted. Archiving each session individually is slower but reaches the
// same state, and re-archiving a session the server already archived writes
// the same field again.
console.warn("[session-actions] archive batch unavailable, archiving one by one", result.reason)
releaseBulkArchiveEchoes(expectedRuntimeKey, batchIds)
plan.individualIds.push(...batchIds)
}
for (const [index, id] of plan.individualIds.entries()) {
if (isStaleRuntime(expectedRuntimeKey)) {
failedIds.push(...plan.individualIds.slice(index))
break
}
if (await archiveSession(id, expectedRuntimeKey)) archivedIds.push(id)
@@ -1282,6 +1397,82 @@ export async function archiveSessions(
return { archivedIds, failedIds }
}
/**
* A session whose archive also has to rewrite another session's metadata.
*
* Review sessions and btw forks point at a parent that must be unlinked, and a
* parent with an active btw fork has to delete that fork. Those are
* read-modify-write pairs on a second session, so they stay on the per-session
* path instead of the server batch.
*/
function hasLinkedSessionCleanup(session: Session): boolean {
return isReviewSession(session) || isBtwSession(session) || Boolean(getBtwSessionID(session))
}
/**
* Split the requested IDs into per-directory server batches and the sessions
* that must be archived individually.
*
* Link classification reads this client's session records rather than
* refetching each session: those records are kept current by the same
* `session.updated` events that publish a link created anywhere else, so a
* fetch per session would buy no authority the store does not already have.
* A session this client does not hold is classified as individual, which
* restores the per-session fetch for exactly the cases where the store has
* nothing to say.
*/
function planArchiveBatches(ids: string[]) {
const global = useGlobalSessionsStore.getState()
const knownSessions = new Map<string, Session>()
for (const session of [...global.activeSessions, ...global.archivedSessions]) {
knownSessions.set(session.id, session)
}
for (const store of _childStores?.children.values() ?? []) {
for (const session of store.getState().session) knownSessions.set(session.id, session)
}
const batchesByDirectory = new Map<string, string[]>()
const individualIds: string[] = []
for (const id of ids) {
const session = knownSessions.get(id)
const directory = session
? resolveGlobalSessionDirectory(session) ?? getSessionDirectory(id)
: undefined
if (!session || !directory || hasLinkedSessionCleanup(session)) {
individualIds.push(id)
continue
}
const batch = batchesByDirectory.get(directory)
if (batch) batch.push(id)
else batchesByDirectory.set(directory, [id])
}
return { batchesByDirectory, individualIds }
}
/**
* Reconcile a server-confirmed archive batch with one write per store.
*
* This mirrors what `archiveSession` does for a single session — drop it from
* the live directory stores, invalidate its cached messages, move it to the
* archived bucket, and clear it if it was open — with the per-session store
* notifications collapsed into one.
*/
function commitArchivedSessions(sessions: Session[], directory: string): void {
if (sessions.length === 0) return
const ids = sessions.map((session) => session.id)
const snapshots = removeSessionsFromLiveStores(ids, directory)
const directories = [...snapshots.map((snapshot) => snapshot.directory), directory]
for (const id of ids) invalidateSessionLoads(id, directories)
useGlobalSessionsStore.getState().upsertSessions(sessions)
const ui = useSessionUIStore.getState()
if (ui.currentSessionId && ids.includes(ui.currentSessionId)) ui.setCurrentSession(null)
}
/**
* Sentinel written to `time.archived` when restoring a session.
*