fix(ui): avoid vibrancy backing on unstuck project headers (#2526)
This commit is contained in:
@@ -196,7 +196,8 @@ export const SortableProjectItem: React.FC<SortableProjectItemProps> = ({
|
|||||||
<div
|
<div
|
||||||
className={cn(
|
className={cn(
|
||||||
'-ml-2.5 -mr-2 text-left group/project select-none',
|
'-ml-2.5 -mr-2 text-left group/project select-none',
|
||||||
stickyZoneHeaders && 'oc-zone-header-backing sticky top-0 z-20 bg-sidebar',
|
stickyZoneHeaders && 'sticky top-0 z-20 bg-sidebar',
|
||||||
|
stickyZoneHeaders && isStuck && 'oc-zone-header-backing',
|
||||||
)}
|
)}
|
||||||
onContextMenu={(event) => {
|
onContextMenu={(event) => {
|
||||||
// VS Code hides project actions entirely (hideDirectoryControls).
|
// VS Code hides project actions entirely (hideDirectoryControls).
|
||||||
@@ -422,4 +423,3 @@ const SortableGroupItemBase: React.FC<{
|
|||||||
};
|
};
|
||||||
|
|
||||||
export const SortableGroupItem = React.memo(SortableGroupItemBase);
|
export const SortableGroupItem = React.memo(SortableGroupItemBase);
|
||||||
|
|
||||||
|
|||||||
@@ -150,18 +150,12 @@
|
|||||||
background-color: transparent !important;
|
background-color: transparent !important;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Sticky sidebar zone headers must fully mask the rows scrolling under
|
/* Stuck sidebar zone headers must fully mask the rows scrolling under
|
||||||
them. A frosted (translucent + backdrop-blur) backing is NOT possible
|
them. Electron's transparent/vibrancy windows break backdrop-filter
|
||||||
here: Electron's transparent/vibrancy windows break backdrop-filter
|
(electron#20357), so use the opaque sidebar tone instead. */
|
||||||
entirely (electron#20357 — the backdrop snapshot fails against a
|
|
||||||
transparent root), so any translucency lets row text bleed through
|
|
||||||
un-blurred. Use the opaque sidebar tone instead; the blur declaration
|
|
||||||
stays only as a progressive enhancement if Electron ever fixes it. */
|
|
||||||
:root.desktop-runtime[data-oc-vibrancy] .oc-zone-header-backing {
|
:root.desktop-runtime[data-oc-vibrancy] .oc-zone-header-backing {
|
||||||
background: var(--sidebar-stuck-bg) !important;
|
background: var(--sidebar-stuck-bg) !important;
|
||||||
background-color: var(--sidebar-stuck-bg) !important;
|
background-color: var(--sidebar-stuck-bg) !important;
|
||||||
-webkit-backdrop-filter: blur(16px) saturate(1.2);
|
|
||||||
backdrop-filter: blur(16px) saturate(1.2);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
.font-sans {
|
.font-sans {
|
||||||
|
|||||||
Reference in New Issue
Block a user