BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Decouple bundled UI from runtime API and add remote instance tooling (#1228)

Browse Source 
Add a packaged-client runtime boundary so the shared UI can talk to local,
desktop, remote, and VS Code runtimes through the right transport instead of
assuming one same-origin web server.

Centralize OpenChamber-owned API access behind RuntimeAPIs, runtimeFetch, and
runtime URL helpers, while keeping official OpenCode traffic on the SDK path.
Support runtime switching, remote host selection, desktop client credentials,
and headless connection links for pairing packaged clients with remote
OpenChamber servers.

Harden the new auth model by moving long-lived client tokens out of browser
URLs, introducing short-lived scoped URL tokens for browser-owned transports,
restricting URL-token access to explicit readable/realtime routes, and making
client-token management session-scoped or self-scoped as appropriate.

Update browser-owned assets and preview proxy flows to work with the split
runtime model, including authenticated project icons, preview token propagation,
CSP-safe preview bridge injection, and preview proxy auth that survives
short-lived URL-token expiry.

Tighten Electron security boundaries for packaged clients by gating privileged
preload state to trusted origins and requiring explicit confirmation before
connect deep-links import or switch remote runtimes.

Also refresh agent guidance and project skills so future runtime/API, auth,
preview, UI, CLI, settings, locale, and drag-to-reorder work follows the new
architecture.
This commit is contained in:
Bohdan Triapitsyn
2026-06-02 00:43:05 +03:00
committed by GitHub
parent a4314c189b
commit 2031e3b4a8
282 changed files with 16524 additions and 4259 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/auth/SessionAuthGate.tsx
+168 -4
View File
@@ -11,6 +11,9 @@ import { DesktopHostSwitcherInline } from '@/components/desktop/DesktopHostSwitc
import { OpenChamberLogo } from '@/components/ui/OpenChamberLogo';
import { Icon } from "@/components/icon/Icon";
import { useI18n } from '@/lib/i18n';
import { runtimeFetch } from '@/lib/runtime-fetch';
import { getRuntimeApiBaseUrl, getRuntimeKey, subscribeRuntimeEndpointChanged, switchRuntimeEndpoint } from '@/lib/runtime-switch';
import { desktopHostsGet, desktopHostsSet, getDesktopHostApiUrl, normalizeHostUrl } from '@/lib/desktopHosts';
import {
authenticateWithPasskey,
cancelPasskeyCeremony,
@@ -23,9 +26,47 @@ import {
const STATUS_CHECK_ENDPOINT = '/auth/session';
const TRUST_DEVICE_STORAGE_KEY = 'openchamber.uiAuth.trustDevice';
const LOCAL_DESKTOP_CLIENT_KIND = 'desktop-local';
const LOCAL_DESKTOP_CLIENT_DEDUPE_KEY = 'desktop-local';
const readLocalOrigin = (): string => {
if (typeof window === 'undefined') return '';
const injected = (window as typeof window & { __OPENCHAMBER_LOCAL_ORIGIN__?: string }).__OPENCHAMBER_LOCAL_ORIGIN__;
return typeof injected === 'string' ? injected.trim() : '';
};
const sameOrigin = (left: string, right: string): boolean => {
const normalizedLeft = normalizeHostUrl(left);
const normalizedRight = normalizeHostUrl(right);
if (!normalizedLeft || !normalizedRight) return false;
try {
return new URL(normalizedLeft).origin === new URL(normalizedRight).origin;
} catch {
return false;
}
};
const shouldIssueDesktopClientToken = (): boolean => {
return isDesktopShell();
};
const isLocalDesktopRuntime = (): boolean => {
if (!isDesktopShell()) return false;
const apiBaseUrl = getRuntimeApiBaseUrl();
const localOrigin = readLocalOrigin();
return Boolean(localOrigin && sameOrigin(localOrigin, apiBaseUrl));
};
const desktopClientAuthMetadata = (): { clientKind?: string; dedupeKey?: string } => {
if (!isLocalDesktopRuntime()) return {};
return {
clientKind: LOCAL_DESKTOP_CLIENT_KIND,
dedupeKey: LOCAL_DESKTOP_CLIENT_DEDUPE_KEY,
};
};
const fetchSessionStatus = async (): Promise<Response> => {
const response = await fetch(STATUS_CHECK_ENDPOINT, {
const response = await runtimeFetch(STATUS_CHECK_ENDPOINT, {
method: 'GET',
credentials: 'include',
headers: {
@@ -43,18 +84,106 @@ const readStoredTrustDevice = (): boolean => {
};
const submitPassword = async (password: string, trustDevice: boolean): Promise<Response> => {
const response = await fetch(STATUS_CHECK_ENDPOINT, {
const issueClientToken = shouldIssueDesktopClientToken();
const response = await runtimeFetch(STATUS_CHECK_ENDPOINT, {
method: 'POST',
credentials: 'include',
headers: {
'Content-Type': 'application/json',
Accept: 'application/json',
},
body: JSON.stringify({ password, trustDevice }),
body: JSON.stringify({
password,
trustDevice,
issueClientToken,
clientLabel: 'OpenChamber Desktop',
...desktopClientAuthMetadata(),
}),
});
return response;
};
const issueDesktopClientToken = async (): Promise<string> => {
if (!isDesktopShell()) {
return '';
}
const response = await runtimeFetch('/api/client-auth/clients', {
method: 'POST',
credentials: 'include',
headers: {
'Content-Type': 'application/json',
Accept: 'application/json',
},
body: JSON.stringify({ label: 'OpenChamber Desktop', ...desktopClientAuthMetadata() }),
}).catch(() => null);
if (!response?.ok) {
return '';
}
const payload = await response.json().catch(() => null) as { token?: unknown } | null;
return typeof payload?.token === 'string' ? payload.token.trim() : '';
};
const issueDesktopClientTokenViaShell = async (password: string, trustDevice: boolean): Promise<string> => {
if (!isDesktopShell() || typeof window === 'undefined') {
return '';
}
const invoke = (window as unknown as { __TAURI__?: { core?: { invoke?: (cmd: string, args?: Record<string, unknown>) => Promise<unknown> } } }).__TAURI__?.core?.invoke;
if (typeof invoke !== 'function') {
return '';
}
const response = await invoke('desktop_remote_password_login', {
url: getRuntimeApiBaseUrl(),
password,
trustDevice,
}).catch(() => null);
if (!response || typeof response !== 'object') {
return '';
}
const token = (response as { token?: unknown }).token;
return typeof token === 'string' ? token.trim() : '';
};
const persistDesktopClientToken = async (apiBaseUrl: string, clientToken: string): Promise<void> => {
if (!isDesktopShell() || !clientToken) return;
const cfg = await desktopHostsGet().catch(() => null);
if (!cfg) return;
if (cfg.localOrigin && sameOrigin(cfg.localOrigin, apiBaseUrl)) {
await desktopHostsSet({
hosts: cfg.hosts,
defaultHostId: cfg.defaultHostId,
initialHostChoiceCompleted: cfg.initialHostChoiceCompleted,
localClientToken: clientToken,
}).catch(() => undefined);
return;
}
let changed = false;
const hosts = cfg.hosts.map((host) => {
if (!sameOrigin(getDesktopHostApiUrl(host), apiBaseUrl)) {
return host;
}
if (host.clientToken === clientToken) {
return host;
}
changed = true;
return { ...host, clientToken };
});
if (!changed) return;
await desktopHostsSet({
hosts,
defaultHostId: cfg.defaultHostId,
initialHostChoiceCompleted: cfg.initialHostChoiceCompleted,
}).catch(() => undefined);
};
const applyDesktopClientToken = async (clientToken: string): Promise<void> => {
if (!clientToken) return;
const apiBaseUrl = getRuntimeApiBaseUrl();
await persistDesktopClientToken(apiBaseUrl, clientToken);
switchRuntimeEndpoint({ apiBaseUrl, clientToken, runtimeKey: getRuntimeKey() });
};
const AuthShell: React.FC<{ children: React.ReactNode }> = ({ children }) => {
const titlebarDragStyle = React.useMemo<React.CSSProperties>(() => {
return {
@@ -268,6 +397,21 @@ export const SessionAuthGate: React.FC<SessionAuthGateProps> = ({ children }) =>
void checkStatus();
}, [checkStatus, skipAuth]);
React.useEffect(() => {
if (skipAuth) {
return;
}
return subscribeRuntimeEndpointChanged(() => {
setPassword('');
setErrorMessage('');
setRetryAfter(undefined);
setIsTunnelLocked(false);
setState('pending');
void checkStatus();
});
}, [checkStatus, skipAuth]);
React.useEffect(() => {
if (!skipAuth && state === 'locked') {
hasResyncedRef.current = false;
@@ -336,8 +480,18 @@ export const SessionAuthGate: React.FC<SessionAuthGateProps> = ({ children }) =>
try {
const response = await submitPassword(password, trustDevice);
if (response.ok) {
const payload = await response.json().catch(() => null) as { clientToken?: unknown } | null;
const shouldUseClientToken = shouldIssueDesktopClientToken();
const clientToken = shouldUseClientToken
? (typeof payload?.clientToken === 'string' && payload.clientToken.trim()
? payload.clientToken.trim()
: await issueDesktopClientTokenViaShell(password, trustDevice) || await issueDesktopClientToken())
: '';
setPassword('');
setIsTunnelLocked(false);
if (clientToken) {
await applyDesktopClientToken(clientToken);
}
if (enrollPasskey && supportsPasskeys) {
try {
await registerPasskeyForCurrentSession();
@@ -402,7 +556,17 @@ export const SessionAuthGate: React.FC<SessionAuthGateProps> = ({ children }) =>
setErrorMessage('');
try {
await authenticateWithPasskey(trustDevice);
const payload = await authenticateWithPasskey(trustDevice, {
issueClientToken: shouldIssueDesktopClientToken(),
clientLabel: 'OpenChamber Desktop',
...desktopClientAuthMetadata(),
}) as { clientToken?: unknown } | null;
const clientToken = shouldIssueDesktopClientToken() && typeof payload?.clientToken === 'string' && payload.clientToken.trim()
? payload.clientToken.trim()
: '';
if (clientToken) {
await applyDesktopClientToken(clientToken);
}
setPassword('');
setState('authenticated');