From 223849261a461c67fff0c03b5053f16698d492ba Mon Sep 17 00:00:00 2001
From: herjarsa <herjarsa@users.noreply.github.com>
Date: Fri, 28 Aug 2026 09:52:17 +0200
Subject: [PATCH] fix(ui): stop click propagation on the multi-select checkbox

The checkbox button calls togglePathSelection() on click but does not stop
event propagation, so the click bubbles to the parent row's onClick which
calls executeRow() -> browseToEntry(). With a mouse, every checkbox click
would (a) toggle the selection, (b) navigate into the directory, and (c)
the navigation effect would clear selectedPaths. The primary interaction
of the multi-select feature was unusable.

The existing handleQuickAdd helper avoids this exact bug by calling
event.stopPropagation() inside its onClick handler. Apply the same
pattern to the new togglePathSelection onClick.

Refs openchamber-bot review on #2877.
---
 packages/ui/src/components/session/DirectoryExplorerDialog.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/ui/src/components/session/DirectoryExplorerDialog.tsx b/packages/ui/src/components/session/DirectoryExplorerDialog.tsx
index fa7e61cc..800e66e5 100644
--- a/packages/ui/src/components/session/DirectoryExplorerDialog.tsx
+++ b/packages/ui/src/components/session/DirectoryExplorerDialog.tsx
@@ -740,7 +740,7 @@ export const DirectoryExplorerDialog: React.FC<DirectoryExplorerDialogProps> = (
                       <button
                         type="button"
                         onMouseDown={(event) => event.stopPropagation()}
-                        onClick={() => togglePathSelection(row.path)}
+                        onClick={(event) => { event.stopPropagation(); togglePathSelection(row.path); }}
                         title={t('directoryExplorerDialog.browse.selectForAdd')}
                         aria-label={t('directoryExplorerDialog.browse.selectForAdd')}
                         aria-pressed={selectedPaths.includes(row.path)}