fix(ui): preserve VS Code themes during settings broadcasts

This commit is contained in:
Bohdan Triapitsyn
2026-09-03 12:41:59 +03:00
141 changed files with 3435 additions and 286 deletions
+31
View File
@@ -875,6 +875,7 @@ describe('updateDesktopSettings', () => {
expect(synced.length).toBeGreaterThan(0);
const bootstrapSync = synced.find((detail) => detail.bootstrap);
expect(bootstrapSync).toBeTruthy();
expect(bootstrapSync?.adoptTheme).toBe(true);
expect(bootstrapSync?.settings.useSystemTheme).toBe(undefined);
expect(bootstrapSync?.settings.lightThemeId).toBe(undefined);
expect(bootstrapSync?.settings.darkThemeId).toBe(undefined);
@@ -905,8 +906,38 @@ describe('updateDesktopSettings', () => {
expect(synced.length).toBeGreaterThan(0);
expect(synced.every((detail) => detail.bootstrap === false)).toBe(true);
expect(synced.every((detail) => detail.adoptTheme === false)).toBe(true);
expect(synced.every((detail) => detail.settings.themeVariant === 'dark')).toBe(true);
});
test('allows a bootstrap sync to preserve the current window theme', async () => {
getWindow();
invalidateSettingsCache();
registerSettingsApi(
async (changes) => ({ ...changes } as SettingsPayload),
async () => ({
settings: { activeProjectId: 'project-a', themeVariant: 'dark' },
source: 'web',
}),
);
const synced: SettingsSyncedDetail[] = [];
const listener = (event: Event): void => {
const detail = (event as CustomEvent<SettingsSyncedDetail>).detail;
if (detail) synced.push(detail);
};
window.addEventListener('openchamber:settings-synced', listener);
try {
await syncDesktopSettings({ adoptTheme: false });
} finally {
window.removeEventListener('openchamber:settings-synced', listener);
}
const broadcastSync = synced.find((detail) => detail.bootstrap && !detail.adoptTheme);
expect(broadcastSync).toBeTruthy();
expect(broadcastSync?.settings.activeProjectId).toBe('project-a');
expect(broadcastSync?.settings.themeVariant).toBe('dark');
});
});
describe('unload lifecycle flush (#2197)', () => {