BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ui): stop painting git activity dots on non-git rail surfaces

Browse Source 
The badge PR inverted showActivityDot to !== 'git', so editor/terminal/diff
picked up the blue activity dot whenever git had changes. Git already shows
a numeric badge; other surfaces should stay quiet. Also split the count
aria/tooltip strings into singular/plural keys.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>
This commit is contained in:
Serhii Dziupin
2026-08-05 13:26:46 +00:00
co-authored by Serhii Dziupin
parent 9b7c032524
commit 341b4b45c8
12 changed files with 59 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/layout/ContextPanelRail.tsx
+15 -5
View File
@@ -284,8 +284,8 @@ export const ContextPanelRail: React.FC = () => {
<SortableContext items={surfaces.map((surface) => surface.id)} strategy={verticalListSortingStrategy}>
{surfaces.map((surface, index) => {
const label = t(surface.labelKey);
// The Git surface carries its changed-files count as a numeric
// badge; other surfaces keep the plain activity dot.
// Git shows a numeric badge instead of the old activity dot.
// Other surfaces never inherit git's changed-files signal.
const gitChangedCount = surface.id === 'git' ? changedFilesCount : 0;
const badgeCount = gitChangedCount > 0 ? gitChangedCount : null;
return (
@@ -293,15 +293,25 @@ export const ContextPanelRail: React.FC = () => {
key={surface.id}
surface={surface}
isActive={activeMode === surface.mode}
showActivityDot={surface.id !== 'git' && changedFilesCount > 0}
showActivityDot={false}
label={label}
description={t(surface.descriptionKey)}
badgeCount={badgeCount}
badgeAriaLabel={badgeCount !== null
? t('contextRail.surface.git.changesCountAria', { label, count: badgeCount })
? t(
badgeCount === 1
? 'contextRail.surface.git.changesCountAriaSingle'
: 'contextRail.surface.git.changesCountAriaPlural',
{ label, count: badgeCount },
)
: null}
badgeDescription={badgeCount !== null
? t('contextRail.surface.git.changesCountTooltip', { count: badgeCount })
? t(
badgeCount === 1
? 'contextRail.surface.git.changesCountTooltipSingle'
: 'contextRail.surface.git.changesCountTooltipPlural',
{ count: badgeCount },
)
: null}
orderNumber={index + 1}
showOrderNumber={revealNumbers}