feat(knowledge): rebuild the project notes panel as Project knowledge (#2973)
The panel stored notes, todos and plans inside one shared JSON file that six unrelated domains also wrote to, synchronised itself through window CustomEvents, and could only read plans. It is now Project knowledge: server-owned storage with explicit routes, a store with rollback, a section sidebar, plans that open and edit in place, and search across all of it. Notes and plans the user pins travel with every message sent in that project. Pinning is project state, not an attachment to one message, so it holds until unpinned and the work status panel names what is riding along and can detach it. Agent memory is added alongside, in two scopes: what is true about the user, and what is true about this codebase. The split is not cosmetic — a wrong project fact costs one project and is noticed, while a wrong global fact quietly shapes every session everywhere and the user has no code to check it against. It stays separate from notes so an agent mistake cannot land in what the user wrote. Sessions receive an index of titles only; bodies are read on demand, because an index carrying full text grows until it crowds out the conversation. Deciding what a session must be told, and whether it has been told, now lives on the server. The client owned it before, which meant sessions started without a UI — scheduled tasks, sessions the agent dispatches — received nothing at all, and a tab's record of what it had sent outlived the conversation: after compaction the agent no longer held the block while the tab went on believing it did. What was delivered is recorded in the session's own metadata, and compaction restores it through the runtime that already restores pinned messages, in the same turn. Agent memory ships dark behind OPENCHAMBER_MEMORY_ENABLE: unset, there is no tool, no routes, no session index, no settings row and no panel tab. Absent rather than switched off, so nothing invites turning on a feature that has not been announced. Pinned notes and plans are unaffected and ship as normal.
This commit is contained in:
Bohdan Triapitsyn
committed by
GitHub
GitHub
parent
7611076436
commit
34e8a24b20
@@ -0,0 +1,277 @@
|
||||
import React from 'react';
|
||||
|
||||
import { toast } from '@/components/ui';
|
||||
import { Button } from '@/components/ui/button';
|
||||
import { Input } from '@/components/ui/input';
|
||||
import { Textarea } from '@/components/ui/textarea';
|
||||
import { KnowledgeCard } from './KnowledgeCard';
|
||||
import { Icon } from '@/components/icon/Icon';
|
||||
import { useI18n } from '@/lib/i18n';
|
||||
import { AGENT_MEMORY_BODY_MAX_LENGTH, AGENT_MEMORY_TITLE_MAX_LENGTH, type AgentMemoryEntry, type AgentMemoryScope } from '@/lib/agentMemoryApi';
|
||||
import { classifyMemory, memoryViewKey, type MemoryBadge } from '@/lib/agentMemoryBadges';
|
||||
import { cn } from '@/lib/utils';
|
||||
import { useAgentMemoryStore } from '@/stores/useAgentMemoryStore';
|
||||
import { useUIStore } from '@/stores/useUIStore';
|
||||
|
||||
/**
|
||||
* One stored memory.
|
||||
*
|
||||
* Read-only text on purpose: this is what the agent wrote, and the useful
|
||||
* action on someone else's claim is to remove it, not to quietly rewrite it
|
||||
* into something the agent will contradict next session.
|
||||
*
|
||||
* There is no confirm button. A badge that the user has to dismiss by hand asks
|
||||
* them to do work that tells the agent nothing — the agent already has the
|
||||
* memory either way — so the badge clears itself once they have looked.
|
||||
*/
|
||||
const MemoryRow: React.FC<{
|
||||
entry: AgentMemoryEntry;
|
||||
badge: MemoryBadge;
|
||||
expanded: boolean;
|
||||
onToggleExpanded: () => void;
|
||||
onSave: (patch: { title?: string; body?: string }) => void;
|
||||
onDelete: () => void;
|
||||
}> = ({ entry, badge, expanded, onToggleExpanded, onSave, onDelete }) => {
|
||||
const { t } = useI18n();
|
||||
const [titleDraft, setTitleDraft] = React.useState(entry.title);
|
||||
const [bodyDraft, setBodyDraft] = React.useState(entry.body);
|
||||
|
||||
// Adopt an external rewrite only while this row is not being edited, so the
|
||||
// agent saving mid-edit cannot swallow what the user is typing.
|
||||
React.useEffect(() => {
|
||||
if (expanded) return;
|
||||
setTitleDraft(entry.title);
|
||||
setBodyDraft(entry.body);
|
||||
}, [entry.body, entry.title, expanded]);
|
||||
|
||||
const commit = React.useCallback(() => {
|
||||
const title = titleDraft.trim();
|
||||
const body = bodyDraft.trim();
|
||||
// An emptied field is a rejected write, not a delete: restore it rather
|
||||
// than sending something the server will refuse.
|
||||
if (!title || !body) {
|
||||
setTitleDraft(entry.title);
|
||||
setBodyDraft(entry.body);
|
||||
return;
|
||||
}
|
||||
if (title === entry.title && body === entry.body) {
|
||||
return;
|
||||
}
|
||||
onSave({ title, body });
|
||||
}, [bodyDraft, entry.body, entry.title, onSave, titleDraft]);
|
||||
|
||||
const typeLabel = t(`rightSidebar.contextNotesTodo.memory.type.${entry.type}` as Parameters<typeof t>[0]);
|
||||
|
||||
return (
|
||||
<KnowledgeCard
|
||||
expanded={expanded}
|
||||
onToggleExpanded={() => {
|
||||
if (expanded) commit();
|
||||
onToggleExpanded();
|
||||
}}
|
||||
expandLabel={entry.title}
|
||||
footer={(
|
||||
<span className="flex flex-wrap items-center gap-x-2 typography-micro text-muted-foreground">
|
||||
{typeLabel}
|
||||
{entry.flagged ? (
|
||||
// Shown rather than hidden: an entry withheld from the agent is
|
||||
// exactly the one the user needs to look at.
|
||||
<span className="flex items-center gap-1 text-[var(--status-error)]">
|
||||
<Icon name="error-warning" className="h-3 w-3 flex-shrink-0" />
|
||||
{t('rightSidebar.contextNotesTodo.memory.flagged')}
|
||||
</span>
|
||||
) : null}
|
||||
</span>
|
||||
)}
|
||||
header={badge ? (
|
||||
<span
|
||||
className={cn(
|
||||
'mb-0.5 mr-1.5 inline-block rounded-full px-1.5 py-px typography-micro font-medium',
|
||||
badge === 'new'
|
||||
? 'bg-[var(--status-success)]/15 text-[var(--status-success)]'
|
||||
: 'bg-[var(--status-warning)]/15 text-[var(--status-warning)]',
|
||||
)}
|
||||
>
|
||||
{t(badge === 'new'
|
||||
? 'rightSidebar.contextNotesTodo.memory.badge.new'
|
||||
: 'rightSidebar.contextNotesTodo.memory.badge.changed')}
|
||||
</span>
|
||||
) : null}
|
||||
actions={(
|
||||
<button
|
||||
type="button"
|
||||
onClick={onDelete}
|
||||
className="inline-flex h-6 w-6 items-center justify-center rounded-md text-muted-foreground hover:bg-interactive-hover/50 hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-primary/50"
|
||||
aria-label={t('rightSidebar.contextNotesTodo.memory.actions.delete')}
|
||||
title={t('rightSidebar.contextNotesTodo.memory.actions.delete')}
|
||||
>
|
||||
<Icon name="delete-bin" className="h-3.5 w-3.5" />
|
||||
</button>
|
||||
)}
|
||||
>
|
||||
{expanded ? (
|
||||
// Editable on purpose. A memory worded badly enough to mislead should
|
||||
// be fixable where it is read; deleting it and hoping the agent learns
|
||||
// it again, better, is not a repair.
|
||||
<div className="flex flex-col gap-1">
|
||||
<Input
|
||||
value={titleDraft}
|
||||
onChange={(event) => setTitleDraft(event.target.value.slice(0, AGENT_MEMORY_TITLE_MAX_LENGTH))}
|
||||
onBlur={commit}
|
||||
aria-label={t('rightSidebar.contextNotesTodo.memory.actions.editTitle')}
|
||||
className="h-7 typography-ui-label"
|
||||
/>
|
||||
<Textarea
|
||||
simple
|
||||
rows={Math.min(20, Math.max(3, bodyDraft.split('\n').length + 1))}
|
||||
value={bodyDraft}
|
||||
onChange={(event) => setBodyDraft(event.target.value.slice(0, AGENT_MEMORY_BODY_MAX_LENGTH))}
|
||||
onBlur={commit}
|
||||
aria-label={t('rightSidebar.contextNotesTodo.memory.actions.editBody')}
|
||||
className="min-h-0 w-full resize-none bg-transparent p-0 typography-meta leading-normal text-muted-foreground focus-visible:outline-none focus-visible:ring-0"
|
||||
/>
|
||||
</div>
|
||||
) : (
|
||||
<>
|
||||
<span className="block min-w-0 truncate typography-ui-label text-foreground">{entry.title}</span>
|
||||
<p className="line-clamp-2 whitespace-pre-wrap break-words typography-meta text-muted-foreground">
|
||||
{entry.body}
|
||||
</p>
|
||||
</>
|
||||
)}
|
||||
</KnowledgeCard>
|
||||
);
|
||||
};
|
||||
|
||||
/**
|
||||
* What the agent has chosen to remember, in the two scopes it writes to.
|
||||
*
|
||||
* The scopes are a switch rather than one merged list: a claim about the user
|
||||
* reaches every project, so which store a memory sits in is the most important
|
||||
* thing about it and must never be something the reader has to infer.
|
||||
*/
|
||||
export const MemorySection: React.FC<{
|
||||
projectPath: string | null;
|
||||
query: string;
|
||||
}> = ({ projectPath, query }) => {
|
||||
const { t } = useI18n();
|
||||
const [scope, setScope] = React.useState<AgentMemoryScope>('project');
|
||||
const [expandedId, setExpandedId] = React.useState<string | null>(null);
|
||||
|
||||
const globalEntries = useAgentMemoryStore((state) => state.global);
|
||||
const projectEntries = useAgentMemoryStore((state) => state.project);
|
||||
const globalFailed = useAgentMemoryStore((state) => state.globalFailed);
|
||||
const projectFailed = useAgentMemoryStore((state) => state.projectFailed);
|
||||
const deleteEntry = useAgentMemoryStore((state) => state.deleteEntry);
|
||||
const saveEntry = useAgentMemoryStore((state) => state.saveEntry);
|
||||
const markViewed = useUIStore((state) => state.markAgentMemoryViewed);
|
||||
|
||||
const entries = scope === 'global' ? globalEntries : projectEntries;
|
||||
const scopeFailed = scope === 'global' ? globalFailed : projectFailed;
|
||||
const viewKey = memoryViewKey(scope, projectPath);
|
||||
const storedViewedAt = useUIStore((state) => state.agentMemoryViewedAt[viewKey] ?? 0);
|
||||
|
||||
/**
|
||||
* The mark is frozen for the length of the visit and only advanced on the way
|
||||
* out. Reading the live value would clear every badge the instant the tab
|
||||
* opened, which is the one moment the user is trying to read them.
|
||||
*/
|
||||
const baselineRef = React.useRef(storedViewedAt);
|
||||
const [baseline, setBaseline] = React.useState(storedViewedAt);
|
||||
React.useEffect(() => {
|
||||
baselineRef.current = useUIStore.getState().agentMemoryViewedAt[viewKey] ?? 0;
|
||||
setBaseline(baselineRef.current);
|
||||
return () => {
|
||||
markViewed(viewKey, Date.now());
|
||||
};
|
||||
}, [markViewed, viewKey]);
|
||||
|
||||
const visibleEntries = React.useMemo(() => {
|
||||
const needle = query.trim().toLowerCase();
|
||||
if (!needle) return entries;
|
||||
return entries.filter((entry) => (
|
||||
entry.title.toLowerCase().includes(needle) || entry.body.toLowerCase().includes(needle)
|
||||
));
|
||||
}, [entries, query]);
|
||||
|
||||
const handleDelete = React.useCallback(async (memoryId: string) => {
|
||||
if (!await deleteEntry(scope, memoryId)) {
|
||||
const detail = useAgentMemoryStore.getState().error;
|
||||
toast.error(
|
||||
t('rightSidebar.contextNotesTodo.memory.toast.deleteFailed'),
|
||||
detail ? { description: detail } : undefined,
|
||||
);
|
||||
}
|
||||
}, [deleteEntry, scope, t]);
|
||||
|
||||
const handleSave = React.useCallback(async (memoryId: string, patch: { title?: string; body?: string }) => {
|
||||
if (!await saveEntry(scope, memoryId, patch)) {
|
||||
const detail = useAgentMemoryStore.getState().error;
|
||||
toast.error(
|
||||
t('rightSidebar.contextNotesTodo.memory.toast.saveFailed'),
|
||||
detail ? { description: detail } : undefined,
|
||||
);
|
||||
}
|
||||
}, [saveEntry, scope, t]);
|
||||
|
||||
const scopeOptions: Array<{ id: AgentMemoryScope; label: string; count: number }> = [
|
||||
{ id: 'project', label: t('rightSidebar.contextNotesTodo.memory.scope.project'), count: projectEntries.length },
|
||||
{ id: 'global', label: t('rightSidebar.contextNotesTodo.memory.scope.global'), count: globalEntries.length },
|
||||
];
|
||||
|
||||
return (
|
||||
<div className="flex flex-col gap-2">
|
||||
{/* Chips rather than a tab strip: these pick which store you are reading,
|
||||
not which view you are in, and the chip's pressed state says which one
|
||||
is selected far more plainly than a pill sitting on a matching
|
||||
background did. */}
|
||||
<div role="group" aria-label={t('rightSidebar.contextNotesTodo.memory.scope.label')} className="flex items-center gap-1">
|
||||
{scopeOptions.map((option) => (
|
||||
<Button
|
||||
key={option.id}
|
||||
type="button"
|
||||
variant="chip"
|
||||
size="xs"
|
||||
aria-pressed={scope === option.id}
|
||||
className="!font-normal"
|
||||
onClick={() => setScope(option.id)}
|
||||
>
|
||||
{`${option.label} ${option.count}`}
|
||||
</Button>
|
||||
))}
|
||||
</div>
|
||||
|
||||
{scope === 'project' && !projectPath ? (
|
||||
<p className="typography-meta text-muted-foreground">
|
||||
{t('rightSidebar.contextNotesTodo.memory.empty.noProject')}
|
||||
</p>
|
||||
) : scopeFailed ? (
|
||||
// Said plainly rather than shown as an empty list: an empty tab would
|
||||
// read as the agent having forgotten everything it knew.
|
||||
<p className="typography-meta text-muted-foreground">
|
||||
{t('rightSidebar.contextNotesTodo.memory.empty.unavailable')}
|
||||
</p>
|
||||
) : visibleEntries.length === 0 ? (
|
||||
<p className="typography-meta text-muted-foreground">
|
||||
{query.trim()
|
||||
? t('rightSidebar.contextNotesTodo.memory.empty.noMatches')
|
||||
: t('rightSidebar.contextNotesTodo.memory.empty.nothing')}
|
||||
</p>
|
||||
) : (
|
||||
<ul className="flex flex-col gap-1.5">
|
||||
{visibleEntries.map((entry) => (
|
||||
<MemoryRow
|
||||
key={entry.id}
|
||||
entry={entry}
|
||||
badge={classifyMemory(entry, baseline)}
|
||||
expanded={expandedId === entry.id}
|
||||
onToggleExpanded={() => setExpandedId(expandedId === entry.id ? null : entry.id)}
|
||||
onSave={(patch) => void handleSave(entry.id, patch)}
|
||||
onDelete={() => void handleDelete(entry.id)}
|
||||
/>
|
||||
))}
|
||||
</ul>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
};
|
||||
Reference in New Issue
Block a user