BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(directory-explorer): make batch add work in VS Code; add Turkish locale keys

Browse Source 
Two non-blockers from the openchamber-bot review at b2ab4af15:

1. VS Code batch add reported a misleading failure. addProjects
   returned [] unconditionally for the VS Code runtime because
   addWorkspaceFolder is reached only by addProject. Iterate addProject
   per path so valid selections succeed and the host is called once
   per selection. addProjects is now async (returns Promise<ProjectEntry[]>);
   the call site in DirectoryExplorerDialog awaits it; existing
   tests in useProjectsStore.test.ts updated to await.

2. Turkish locale (tr.ts) was missing the two new keys that other
   11 dictionaries received: actions.addSelected and browse.selectForAdd.
   Add both with real Turkish translations: "Seçilenleri ekle" and
   "Eklemek için seç".
This commit is contained in:
herjarsa
2026-08-28 18:59:47 +02:00
parent b2ab4af157
commit 478f1e9c03
5 changed files with 49 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/session/DirectoryExplorerDialog.tsx
+1 -1
View File
@@ -486,7 +486,7 @@ export const DirectoryExplorerDialog: React.FC<DirectoryExplorerDialogProps> = (
// Batch path wins over single-target create: with checkboxes ticked,
// the user wants the selections added, not a fresh directory created
// for whatever happens to be typed in the filter.
const added = addProjects(selectionToAdd);
const added = await addProjects(selectionToAdd);
if (added.length === 0) {
toast.error(t('directoryExplorerDialog.toast.failedToAddProject'), {
description: t('directoryExplorerDialog.toast.selectValidDirectoryPath'),