BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: suppress inherited subagent notifications

Browse Source 
Subagent completion notifications respect notification settings
Permission auto-accept now suppresses notifications for known child sessions
Server notification checks use OpenCode session parent semantics
This commit is contained in:
Bohdan Triapitsyn
2026-05-07 23:03:46 +03:00
parent add73ad687
commit 585e2a55f1
2 changed files with 48 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/web/server/lib/notifications/runtime.js
+35 -5
View File
@@ -60,9 +60,26 @@ export const createNotificationTriggerRuntime = (deps) => {
};
const setCachedSessionParentId = (sessionId, parentID) => {
if (!parentID) return;
sessionParentIdCache.set(sessionId, { parentID: parentID ?? null, at: Date.now() });
};
const getParentIdFromPayload = (payload) => {
if (!payload || typeof payload !== 'object') return null;
if (payload.type !== 'session.created' && payload.type !== 'session.updated') return null;
const parentID = payload.properties?.info?.parentID ?? null;
return typeof parentID === 'string' && parentID.length > 0 ? parentID : null;
};
const maybeCacheSessionParentFromPayload = (payload) => {
const sessionId = extractSessionIdFromPayload(payload);
if (typeof sessionId !== 'string' || sessionId.length === 0) return;
const parentID = getParentIdFromPayload(payload);
if (parentID) {
setCachedSessionParentId(sessionId, parentID);
}
};
const fetchSessionParentId = async (sessionId) => {
if (!sessionId) return undefined;
@@ -82,12 +99,19 @@ export const createNotificationTriggerRuntime = (deps) => {
return undefined;
}
const data = await response.json().catch(() => null);
if (!Array.isArray(data)) {
const sessions = Array.isArray(data)
? data
: Array.isArray(data?.items)
? data.items
: Array.isArray(data?.data)
? data.data
: null;
if (!sessions) {
return undefined;
}
const match = data.find((session) => session && typeof session === 'object' && session.id === sessionId);
const parentID = match?.parentID ? match.parentID : null;
const match = sessions.find((session) => session && typeof session === 'object' && session.id === sessionId);
const parentID = match?.parentID ?? null;
setCachedSessionParentId(sessionId, parentID);
return parentID;
} catch {
@@ -164,6 +188,8 @@ export const createNotificationTriggerRuntime = (deps) => {
return;
}
maybeCacheSessionParentFromPayload(payload);
const sessionId = extractSessionIdFromPayload(payload);
if (payload.type === 'message.updated') {
const info = payload.properties?.info;
@@ -171,8 +197,7 @@ export const createNotificationTriggerRuntime = (deps) => {
const settings = await readSettingsFromDisk();
if (settings.notifyOnSubtasks === false) {
const sessionInfo = payload.properties?.session;
const parentIDFromPayload = sessionInfo?.parentID ?? payload.properties?.parentID;
const parentIDFromPayload = getParentIdFromPayload(payload);
const parentID = parentIDFromPayload
? parentIDFromPayload
: await fetchSessionParentId(sessionId);
@@ -437,6 +462,11 @@ export const createNotificationTriggerRuntime = (deps) => {
const timer = setTimeout(async () => {
pushPermissionDebounceTimers.delete(sessionId);
if (await isSessionAutoAccepting(sessionId)) {
if (requestKey) notifiedPermissionRequests.add(requestKey);
return;
}
const settings = await readSettingsFromDisk();
if (settings.notifyOnQuestion === false) {