From 58c6a22036a7f1cdf5eb759fea684bfe25712329 Mon Sep 17 00:00:00 2001
From: Isaac Sanchez-Hawkins <266845420+isanchez404@users.noreply.github.com>
Date: Wed, 13 May 2026 03:36:49 -0400
Subject: [PATCH] fix(ui): default Button type to button (#1252)

Co-authored-by: Isaac Sanchez <isanchez-hawkins@arize.com>
---
 packages/ui/src/components/ui/button.test.tsx | 23 +++++++++++++++++++
 packages/ui/src/components/ui/button.tsx      |  5 ++++
 2 files changed, 28 insertions(+)
 create mode 100644 packages/ui/src/components/ui/button.test.tsx

diff --git a/packages/ui/src/components/ui/button.test.tsx b/packages/ui/src/components/ui/button.test.tsx
new file mode 100644
index 00000000..281cf6d8
--- /dev/null
+++ b/packages/ui/src/components/ui/button.test.tsx
@@ -0,0 +1,23 @@
+import { describe, expect, test } from "bun:test"
+
+import { Button } from "./button"
+
+describe("Button", () => {
+  test("defaults native buttons to type button", () => {
+    const element = Button({ children: "Cancel" })
+
+    expect(element.props.type).toBe("button")
+  })
+
+  test("preserves explicit native button types", () => {
+    const element = Button({ children: "Save", type: "submit" })
+
+    expect(element.props.type).toBe("submit")
+  })
+
+  test("does not default asChild buttons", () => {
+    const element = Button({ asChild: true, children: "Link" })
+
+    expect(element.props.type).toBe(undefined)
+  })
+})
diff --git a/packages/ui/src/components/ui/button.tsx b/packages/ui/src/components/ui/button.tsx
index 2b5ba2fa..328b4b8a 100644
--- a/packages/ui/src/components/ui/button.tsx
+++ b/packages/ui/src/components/ui/button.tsx
@@ -93,17 +93,22 @@ function Button({
   variant,
   size,
   asChild = false,
+  type,
   ...props
 }: React.ComponentProps<"button"> &
   VariantProps<typeof buttonVariants> & {
     asChild?: boolean
   }) {
   const Comp = asChild ? Slot : "button"
+  const typeProps = asChild
+    ? (type === undefined ? {} : { type })
+    : { type: type ?? "button" }
 
   return (
     <Comp
       data-slot="button"
       className={cn(buttonVariants({ variant, size, className }))}
+      {...typeProps}
       {...props}
     />
   )