perf: isolate chat streaming renders and reduce sidebar render cost (#1672)
Reworks the chat and session-sidebar render paths to cut render cascades, memory
churn, and UI jank on large sessions and big session trees. Behavior is preserved;
the changes are about *when* and *how much* the UI re-renders.
## Chat streaming
- Freeze the streaming message's parts in the bulk turn projection during streaming,
and re-inject live parts only in an isolated tail leaf, so a ~60/sec delta stream
no longer re-runs the whole-session projection or re-renders unrelated rows.
session with referential reuse of unchanged turns.
- Memoize message rows with field-aware comparators instead of reference equality.
- Replace the manual child-session polling in the task tool with the live SSE
stream + a one-shot load, removing a fetch/settle state machine.
## History loading & scroll
- Load an initial page fast, then prepend one older page in the background so the
scroll container has headroom and "load older on scroll-up" fires before the user
hits the absolute top.
- Compensate scroll synchronously (in a layout effect, before paint) for prepends —
including background prepends that don't originate from a user scroll — so the
viewport stays stable instead of judder-correcting on the next frame.
## Markdown rendering
- Render markdown synchronously *styled* on first paint (paragraphs, lists, code
cards, tables, inline code) instead of raw escaped text; the async pass then only
upgrades syntax-highlight colors. Eliminates the flash of full-width raw text.
- Load KaTeX CSS eagerly with the main bundle instead of inside the lazy markdown
chunk, avoiding a late stylesheet injection on first render.
## Sidebar
- Hoist per-row recursive tree walks out of row comparators into per-group
precomputed sets/keys; batch live-session lookups into a single map; add a
group-level memo boundary.
- Isolate rename drafts so per-keystroke typing doesn't repaint the row tree.
## Sync layer
- Add a staleness guard so a slow message fetch can't repopulate a session the user
navigated away from.
- Throw on fetch failure for authoritative loaders so a transient blip can't read as
an empty server response.
## Cleanup
- Remove dead code (unused hooks, params, duplicated inline types) surfaced while
reworking the above.
## Known issue
- A rare, purely cosmetic first-paint width flash can still appear on large sessions;
it has no behavioral or data impact and is tracked for a follow-up runtime trace.
This commit is contained in:
@@ -2,6 +2,8 @@ import { create } from 'zustand';
|
||||
import type { OpencodeClient, Session } from '@opencode-ai/sdk/v2';
|
||||
import { opencodeClient } from '@/lib/opencode/client';
|
||||
import { listGlobalSessionPages } from '@/stores/globalSessions';
|
||||
import { getReviewTransferDirection, type ReviewTransferDirection } from '@/lib/reviewFlow';
|
||||
import { getOriginalSessionID, getReviewSessionID } from '@/lib/sessionReviewMetadata';
|
||||
|
||||
type GlobalSessionsStatus = 'idle' | 'loading' | 'ready' | 'error';
|
||||
|
||||
@@ -14,6 +16,7 @@ type GlobalSessionsState = {
|
||||
activeSessions: Session[];
|
||||
archivedSessions: Session[];
|
||||
sessionsByDirectory: Map<string, Session[]>;
|
||||
reviewTransferBySessionId: Map<string, ReviewTransferDirection>;
|
||||
hasLoaded: boolean;
|
||||
status: GlobalSessionsStatus;
|
||||
loadSessions: (fallbackActive?: Session[]) => Promise<LoadResult>;
|
||||
@@ -297,11 +300,15 @@ const applySnapshot = (
|
||||
const nextSessionsByDirectory = nextActiveSessions === state.activeSessions
|
||||
? state.sessionsByDirectory
|
||||
: buildSessionsByDirectory(nextActiveSessions);
|
||||
const nextReviewTransferMap = nextActiveSessions === state.activeSessions
|
||||
? state.reviewTransferBySessionId
|
||||
: buildReviewTransferMap(nextActiveSessions);
|
||||
|
||||
if (
|
||||
nextActiveSessions === state.activeSessions
|
||||
&& nextArchivedSessions === state.archivedSessions
|
||||
&& nextSessionsByDirectory === state.sessionsByDirectory
|
||||
&& nextReviewTransferMap === state.reviewTransferBySessionId
|
||||
&& state.hasLoaded
|
||||
&& state.status === status
|
||||
) {
|
||||
@@ -312,15 +319,32 @@ const applySnapshot = (
|
||||
activeSessions: nextActiveSessions,
|
||||
archivedSessions: nextArchivedSessions,
|
||||
sessionsByDirectory: nextSessionsByDirectory,
|
||||
reviewTransferBySessionId: nextReviewTransferMap,
|
||||
hasLoaded: true,
|
||||
status,
|
||||
};
|
||||
};
|
||||
|
||||
const buildReviewTransferMap = (sessions: Session[]): Map<string, ReviewTransferDirection> => {
|
||||
const next = new Map<string, ReviewTransferDirection>()
|
||||
const activeIds = new Set(sessions.map((s) => s.id))
|
||||
for (const session of sessions) {
|
||||
const direction = getReviewTransferDirection(session)
|
||||
if (!direction) continue
|
||||
const targetSessionId = direction === 'review-to-original'
|
||||
? getOriginalSessionID(session)
|
||||
: getReviewSessionID(session)
|
||||
if (!targetSessionId || !activeIds.has(targetSessionId)) continue
|
||||
next.set(session.id, direction)
|
||||
}
|
||||
return next
|
||||
}
|
||||
|
||||
export const useGlobalSessionsStore = create<GlobalSessionsState>((set, get) => ({
|
||||
activeSessions: [],
|
||||
archivedSessions: [],
|
||||
sessionsByDirectory: new Map(),
|
||||
reviewTransferBySessionId: new Map(),
|
||||
hasLoaded: false,
|
||||
status: 'idle',
|
||||
|
||||
@@ -424,6 +448,9 @@ export const useGlobalSessionsStore = create<GlobalSessionsState>((set, get) =>
|
||||
activeSessions: nextActiveSessions,
|
||||
archivedSessions: nextArchivedSessions,
|
||||
sessionsByDirectory: nextSessionsByDirectory,
|
||||
reviewTransferBySessionId: nextActiveSessions === state.activeSessions
|
||||
? state.reviewTransferBySessionId
|
||||
: buildReviewTransferMap(nextActiveSessions),
|
||||
};
|
||||
});
|
||||
|
||||
@@ -458,6 +485,9 @@ export const useGlobalSessionsStore = create<GlobalSessionsState>((set, get) =>
|
||||
sessionsByDirectory: nextActiveSessions === state.activeSessions
|
||||
? state.sessionsByDirectory
|
||||
: buildSessionsByDirectory(nextActiveSessions),
|
||||
reviewTransferBySessionId: nextActiveSessions === state.activeSessions
|
||||
? state.reviewTransferBySessionId
|
||||
: buildReviewTransferMap(nextActiveSessions),
|
||||
};
|
||||
});
|
||||
},
|
||||
@@ -483,6 +513,7 @@ export const useGlobalSessionsStore = create<GlobalSessionsState>((set, get) =>
|
||||
activeSessions: nextActiveSessions,
|
||||
archivedSessions: nextArchivedSessions,
|
||||
sessionsByDirectory: buildSessionsByDirectory(nextActiveSessions),
|
||||
reviewTransferBySessionId: buildReviewTransferMap(nextActiveSessions),
|
||||
};
|
||||
});
|
||||
},
|
||||
@@ -520,6 +551,7 @@ export const useGlobalSessionsStore = create<GlobalSessionsState>((set, get) =>
|
||||
activeSessions: nextActiveSessions,
|
||||
archivedSessions: [...movedSessions, ...remainingArchivedSessions],
|
||||
sessionsByDirectory: buildSessionsByDirectory(nextActiveSessions),
|
||||
reviewTransferBySessionId: buildReviewTransferMap(nextActiveSessions),
|
||||
};
|
||||
});
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user