BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: stop stale chat renders after session switches

Browse Source 
Roll back aggressive chat reuse paths that froze message parts, tool state, and completed assistant bodies when sessions were inactive or backgrounded.
This commit is contained in:
Bohdan Triapitsyn
2026-04-07 20:33:55 +03:00
parent c16d767dff
commit 605e4bf42c
10 changed files with 90 additions and 523 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/chat/hooks/useTurnRecords.ts
+11 -102
View File
@@ -1,7 +1,5 @@
import React from 'react';
import { projectTurnRecords } from '../lib/turns/projectTurnRecords';
import { projectTurnIndexes } from '../lib/turns/projectTurnIndexes';
import { stabilizeTurnProjection } from '../lib/turns/stabilizeTurnProjection';
import type { ChatMessageEntry, TurnProjectionResult, TurnRecord } from '../lib/turns/types';
import { streamPerfMeasure } from '@/stores/utils/streamDebug';
@@ -16,125 +14,36 @@ export interface TurnRecordsResult {
streamingTurn: TurnProjectionResult['turns'][number] | undefined;
}
const buildTailOnlyProjection = (
previousProjection: TurnProjectionResult | null,
previousMessages: ChatMessageEntry[] | null,
nextMessages: ChatMessageEntry[],
showTextJustificationActivity: boolean,
): TurnProjectionResult | null => {
if (!previousProjection || !previousMessages || previousProjection.turns.length === 0) {
return null;
}
if (previousMessages.length !== nextMessages.length || nextMessages.length === 0) {
return null;
}
let changedCount = 0;
let changedIndex = -1;
for (let index = 0; index < nextMessages.length; index += 1) {
if (previousMessages[index]?.info.id !== nextMessages[index]?.info.id) {
return null;
}
if (previousMessages[index] !== nextMessages[index]) {
changedCount += 1;
changedIndex = index;
if (changedCount > 1) {
return null;
}
}
}
if (changedCount !== 1 || changedIndex !== nextMessages.length - 1) {
return null;
}
const previousLastTurn = previousProjection.turns[previousProjection.turns.length - 1];
if (!previousLastTurn) {
return null;
}
const lastTurnStartIndex = previousMessages.findIndex((message) => message.info.id === previousLastTurn.userMessageId);
if (lastTurnStartIndex < 0) {
return null;
}
const previousTailMessages = previousMessages.slice(lastTurnStartIndex);
const nextTailMessages = nextMessages.slice(lastTurnStartIndex);
if (nextTailMessages[0]?.info.id !== previousLastTurn.userMessageId) {
return null;
}
const previousStaticTurns = previousProjection.turns.slice(0, -1);
const previousStaticUngrouped = new Set(previousProjection.ungroupedMessageIds);
previousTailMessages.forEach((message) => {
previousStaticUngrouped.delete(message.info.id);
});
const previousTailUngrouped = new Set<string>();
previousTailMessages.forEach((message) => {
if (previousProjection.ungroupedMessageIds.has(message.info.id)) {
previousTailUngrouped.add(message.info.id);
}
});
const previousTailProjection: TurnProjectionResult = {
...projectTurnIndexes([previousLastTurn]),
ungroupedMessageIds: previousTailUngrouped,
};
const rawTailProjection = projectTurnRecords(nextTailMessages, {
previousProjection: previousTailProjection,
showTextJustificationActivity,
});
const stabilizedTailProjection = stabilizeTurnProjection(rawTailProjection, previousTailProjection);
const turns = previousStaticTurns.length > 0
? [...previousStaticTurns, ...stabilizedTailProjection.turns]
: stabilizedTailProjection.turns;
const projection = projectTurnIndexes(turns);
const ungroupedMessageIds = new Set(previousStaticUngrouped);
stabilizedTailProjection.ungroupedMessageIds.forEach((messageId) => {
ungroupedMessageIds.add(messageId);
});
return {
...projection,
ungroupedMessageIds,
};
};
export const useTurnRecords = (
messages: ChatMessageEntry[],
options: UseTurnRecordsOptions,
): TurnRecordsResult => {
const previousProjectionRef = React.useRef<TurnProjectionResult | null>(null);
const previousMessagesRef = React.useRef<ChatMessageEntry[] | null>(null);
const staticTurnsRef = React.useRef<TurnRecord[]>([]);
const streamingTurnRef = React.useRef<TurnRecord | undefined>(undefined);
const previousSessionKeyRef = React.useRef<string | undefined>(options.sessionKey);
if (previousSessionKeyRef.current !== options.sessionKey) {
previousSessionKeyRef.current = options.sessionKey;
previousProjectionRef.current = null;
staticTurnsRef.current = [];
streamingTurnRef.current = undefined;
}
React.useEffect(() => {
previousProjectionRef.current = null;
previousMessagesRef.current = null;
staticTurnsRef.current = [];
streamingTurnRef.current = undefined;
}, [options.sessionKey, options.showTextJustificationActivity]);
const projection = React.useMemo(() => {
return streamPerfMeasure('ui.turns.projection_ms', () => {
const tailOnlyProjection = buildTailOnlyProjection(
previousProjectionRef.current,
previousMessagesRef.current,
messages,
options.showTextJustificationActivity,
);
const rawProjection = tailOnlyProjection ?? projectTurnRecords(messages, {
const nextProjection = projectTurnRecords(messages, {
previousProjection: previousProjectionRef.current,
showTextJustificationActivity: options.showTextJustificationActivity,
});
const stabilizedProjection = stabilizeTurnProjection(rawProjection, previousProjectionRef.current);
previousProjectionRef.current = stabilizedProjection;
previousMessagesRef.current = messages;
return stabilizedProjection;
previousProjectionRef.current = nextProjection;
return nextProjection;
});
}, [messages, options.showTextJustificationActivity]);