feat(git): inline file diffs in commit history rows (#1291)
* chore: add .worktrees/ to gitignore for worktree workflow * feat(git): add getCommitFileDiff service function * docs(git): document getCommitFileDiff in module docs * feat(git): add GET /api/git/commit-file-diff route * feat(git): add CommitFileDiffResponse type and GitAPI method signature * feat(git): add getCommitFileDiff HTTP client function * feat(git): add getCommitFileDiff API facade * feat(git): add getCommitFileDiff stub to VS Code bridge * feat(git): add getCommitFileDiff to VS Code gitService and bridge handler * feat(git): add inline file diff to history commit rows * fix(git): consolidate CommitFileDiffResponse import to gitApi facade * fix(git): pass directory through history, validate hash, propagate git errors * fix(git): use exit code check for VS Code getCommitFileDiff error detection * fix(git): VS Code rename detection, hash validation parity, retry on error * fix(git): register scroll container as virtualizer root to fix empty space in history diffs * fix(git): address greptile review — rename key extraction, directory guard, language detection, isBinary cleanup * fix(git): harden history inline diffs --------- Co-authored-by: Bohdan Triapitsyn <artmore@protonmail.com>
This commit is contained in:
Erman HAVUÇ
committed by
GitHub
GitHub
co-authored by
Bohdan Triapitsyn
Bohdan Triapitsyn
parent
fa8fac2590
commit
631905764e
@@ -5,6 +5,52 @@ import { Icon } from "@/components/icon/Icon";
|
||||
import { cn } from '@/lib/utils';
|
||||
import type { GitLogEntry, CommitFileEntry } from '@/lib/api/types';
|
||||
import { useI18n } from '@/lib/i18n';
|
||||
import { getCommitFileDiff, type CommitFileDiffResponse } from '@/lib/gitApi';
|
||||
import { PierreDiffViewer } from '@/components/views/PierreDiffViewer';
|
||||
import { getLanguageFromExtension } from '@/lib/toolHelpers';
|
||||
|
||||
const HISTORY_DIFF_REQUEST_TIMEOUT_MS = 15000;
|
||||
const HISTORY_DIFF_LARGE_CHANGED_LINES = 500;
|
||||
const HISTORY_DIFF_CACHE_MAX_ENTRIES = 12;
|
||||
const HISTORY_DIFF_CACHE_MAX_TOTAL_SIZE_BYTES = 8 * 1024 * 1024;
|
||||
|
||||
type HistoryDiffCacheValue = CommitFileDiffResponse | 'loading' | 'error';
|
||||
|
||||
const getHistoryDiffCacheSize = (value: HistoryDiffCacheValue): number => {
|
||||
if (typeof value === 'string') {
|
||||
return 0;
|
||||
}
|
||||
return (value.original?.length ?? 0) + (value.modified?.length ?? 0);
|
||||
};
|
||||
|
||||
const trimHistoryDiffCache = (cache: Map<string, HistoryDiffCacheValue>): Map<string, HistoryDiffCacheValue> => {
|
||||
if (cache.size <= HISTORY_DIFF_CACHE_MAX_ENTRIES) {
|
||||
let totalSize = 0;
|
||||
for (const value of cache.values()) {
|
||||
totalSize += getHistoryDiffCacheSize(value);
|
||||
}
|
||||
if (totalSize <= HISTORY_DIFF_CACHE_MAX_TOTAL_SIZE_BYTES) {
|
||||
return cache;
|
||||
}
|
||||
}
|
||||
|
||||
const entries = Array.from(cache.entries()).reverse();
|
||||
const next = new Map<string, HistoryDiffCacheValue>();
|
||||
let totalSize = 0;
|
||||
for (const [key, value] of entries) {
|
||||
if (next.size >= HISTORY_DIFF_CACHE_MAX_ENTRIES) {
|
||||
continue;
|
||||
}
|
||||
const entrySize = getHistoryDiffCacheSize(value);
|
||||
if (totalSize + entrySize > HISTORY_DIFF_CACHE_MAX_TOTAL_SIZE_BYTES && next.size > 0) {
|
||||
continue;
|
||||
}
|
||||
next.set(key, value);
|
||||
totalSize += entrySize;
|
||||
}
|
||||
|
||||
return new Map(Array.from(next.entries()).reverse());
|
||||
};
|
||||
|
||||
interface HistoryCommitRowProps {
|
||||
entry: GitLogEntry;
|
||||
@@ -13,6 +59,7 @@ interface HistoryCommitRowProps {
|
||||
files: CommitFileEntry[];
|
||||
isLoadingFiles: boolean;
|
||||
onCopyHash: (hash: string) => void;
|
||||
directory: string | undefined;
|
||||
}
|
||||
|
||||
function formatCommitDate(date: string) {
|
||||
@@ -53,8 +100,68 @@ export const HistoryCommitRow = React.memo(({
|
||||
files,
|
||||
isLoadingFiles,
|
||||
onCopyHash,
|
||||
directory,
|
||||
}: HistoryCommitRowProps) => {
|
||||
const { t } = useI18n();
|
||||
|
||||
const [openDiffPaths, setOpenDiffPaths] = React.useState<Set<string>>(new Set());
|
||||
const [diffCache, setDiffCache] = React.useState<Map<string, HistoryDiffCacheValue>>(new Map());
|
||||
const [forceRenderLargePaths, setForceRenderLargePaths] = React.useState<Set<string>>(new Set());
|
||||
|
||||
const loadFileDiff = React.useCallback(async (file: CommitFileEntry) => {
|
||||
const key = file.path;
|
||||
if (!directory) {
|
||||
setDiffCache(prev => new Map(prev).set(key, 'error'));
|
||||
return;
|
||||
}
|
||||
|
||||
setDiffCache(prev => trimHistoryDiffCache(new Map(prev).set(key, 'loading')));
|
||||
try {
|
||||
const fetchPromise = getCommitFileDiff(directory, entry.hash, file.path, false);
|
||||
const timeoutPromise = new Promise<never>((_, reject) => {
|
||||
setTimeout(() => reject(new Error(`Timed out after ${HISTORY_DIFF_REQUEST_TIMEOUT_MS}ms`)), HISTORY_DIFF_REQUEST_TIMEOUT_MS);
|
||||
});
|
||||
const result = await Promise.race([fetchPromise, timeoutPromise]);
|
||||
setDiffCache(prev => trimHistoryDiffCache(new Map(prev).set(key, result)));
|
||||
} catch {
|
||||
setDiffCache(prev => new Map(prev).set(key, 'error'));
|
||||
}
|
||||
}, [directory, entry.hash]);
|
||||
|
||||
const toggleFileDiff = React.useCallback(async (file: CommitFileEntry) => {
|
||||
const key = file.path;
|
||||
|
||||
if (file.changeType === 'R' || file.isBinary) {
|
||||
setOpenDiffPaths(prev => {
|
||||
const next = new Set(prev);
|
||||
if (next.has(key)) { next.delete(key); } else { next.add(key); }
|
||||
return next;
|
||||
});
|
||||
return;
|
||||
}
|
||||
|
||||
const cached = diffCache.get(key);
|
||||
const isOpen = openDiffPaths.has(key);
|
||||
|
||||
if (isOpen && cached && cached !== 'error') {
|
||||
// Close it
|
||||
setOpenDiffPaths(prev => { const next = new Set(prev); next.delete(key); return next; });
|
||||
return;
|
||||
}
|
||||
|
||||
// Open it (or re-fetch on error)
|
||||
setOpenDiffPaths(prev => { const next = new Set(prev); next.add(key); return next; });
|
||||
|
||||
if (cached && cached !== 'error') return; // Already loaded
|
||||
|
||||
const changedLines = file.insertions + file.deletions;
|
||||
if (changedLines > HISTORY_DIFF_LARGE_CHANGED_LINES && !forceRenderLargePaths.has(key)) {
|
||||
return;
|
||||
}
|
||||
|
||||
await loadFileDiff(file);
|
||||
}, [diffCache, forceRenderLargePaths, loadFileDiff, openDiffPaths]);
|
||||
|
||||
return (
|
||||
<li>
|
||||
<button
|
||||
@@ -120,36 +227,108 @@ export const HistoryCommitRow = React.memo(({
|
||||
) : (
|
||||
<ul className="space-y-0.5 py-2">
|
||||
{files.map((file) => (
|
||||
<li
|
||||
key={file.path}
|
||||
className="flex items-center gap-2 typography-micro"
|
||||
>
|
||||
<span
|
||||
<li key={file.path}>
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => toggleFileDiff(file)}
|
||||
className={cn(
|
||||
'font-semibold w-3 text-center',
|
||||
getChangeTypeColor(file.changeType)
|
||||
'w-full flex items-center gap-2 typography-micro text-left cursor-pointer transition-colors rounded px-1',
|
||||
openDiffPaths.has(file.path) ? 'bg-sidebar/90' : 'hover:bg-sidebar/40'
|
||||
)}
|
||||
>
|
||||
{file.changeType}
|
||||
</span>
|
||||
<span className="truncate text-foreground min-w-0" title={file.path}>
|
||||
{file.path}
|
||||
</span>
|
||||
{!file.isBinary && (
|
||||
<span className="shrink-0">
|
||||
<span style={{ color: 'var(--status-success)' }}>
|
||||
+{file.insertions}
|
||||
</span>
|
||||
<span className="text-muted-foreground mx-0.5">/</span>
|
||||
<span style={{ color: 'var(--status-error)' }}>
|
||||
-{file.deletions}
|
||||
</span>
|
||||
<span
|
||||
className={cn(
|
||||
'font-semibold w-3 text-center shrink-0',
|
||||
getChangeTypeColor(file.changeType)
|
||||
)}
|
||||
>
|
||||
{file.changeType}
|
||||
</span>
|
||||
)}
|
||||
{file.isBinary && (
|
||||
<span className="typography-micro text-muted-foreground shrink-0">
|
||||
{t('gitView.history.binary')}
|
||||
<span className="truncate text-foreground min-w-0" title={file.path}>
|
||||
{file.path}
|
||||
</span>
|
||||
{!file.isBinary && (
|
||||
<span className="shrink-0">
|
||||
<span style={{ color: 'var(--status-success)' }}>
|
||||
+{file.insertions}
|
||||
</span>
|
||||
<span className="text-muted-foreground mx-0.5">/</span>
|
||||
<span style={{ color: 'var(--status-error)' }}>
|
||||
-{file.deletions}
|
||||
</span>
|
||||
</span>
|
||||
)}
|
||||
{file.isBinary && (
|
||||
<span className="typography-micro text-muted-foreground shrink-0">
|
||||
{t('gitView.history.binary')}
|
||||
</span>
|
||||
)}
|
||||
<Icon
|
||||
name={openDiffPaths.has(file.path) ? 'arrow-down-s' : 'arrow-right-s'}
|
||||
className="size-3 shrink-0 text-muted-foreground"
|
||||
/>
|
||||
</button>
|
||||
|
||||
{openDiffPaths.has(file.path) && (
|
||||
<div className="max-h-[400px] overflow-y-auto rounded border border-border/40 mx-2 mb-1" data-diff-virtual-root data-diff-virtual-content>
|
||||
{file.changeType === 'R' ? (
|
||||
<div className="px-3 py-2 text-sm text-muted-foreground">{t('gitView.history.renamedNoDiff')}</div>
|
||||
) : file.isBinary ? (
|
||||
<div className="px-3 py-2 text-sm text-muted-foreground">{t('gitView.history.binaryNoDiff')}</div>
|
||||
) : (() => {
|
||||
const changedLines = file.insertions + file.deletions;
|
||||
if (!forceRenderLargePaths.has(file.path) && changedLines > HISTORY_DIFF_LARGE_CHANGED_LINES) {
|
||||
return (
|
||||
<div className="flex flex-col items-start gap-1 px-3 py-2 text-sm text-muted-foreground">
|
||||
<div className="typography-ui-label font-semibold text-foreground">
|
||||
{t('gitView.history.largeDiffTitle', { count: changedLines })}
|
||||
</div>
|
||||
<div className="typography-meta text-muted-foreground">
|
||||
{t('gitView.history.largeDiffDescription')}
|
||||
</div>
|
||||
<Button
|
||||
type="button"
|
||||
variant="ghost"
|
||||
size="xs"
|
||||
className="h-6 px-0 text-primary hover:bg-transparent hover:underline"
|
||||
onClick={() => {
|
||||
setForceRenderLargePaths(prev => new Set(prev).add(file.path));
|
||||
void loadFileDiff(file);
|
||||
}}
|
||||
>
|
||||
{t('gitView.history.renderDiffAnyway')}
|
||||
</Button>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
const cached = diffCache.get(file.path);
|
||||
if (cached === 'loading' || cached === undefined) {
|
||||
return <div className="px-3 py-2 text-sm text-muted-foreground">{t('gitView.history.loadingDiff')}</div>;
|
||||
}
|
||||
if (cached === 'error') {
|
||||
return (
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => toggleFileDiff(file)}
|
||||
className="w-full text-left px-3 py-2 text-sm text-muted-foreground hover:bg-[var(--interactive-hover)] transition-colors"
|
||||
>
|
||||
{t('gitView.history.diffError')}
|
||||
</button>
|
||||
);
|
||||
}
|
||||
return (
|
||||
<PierreDiffViewer
|
||||
original={cached.original}
|
||||
modified={cached.modified}
|
||||
language={getLanguageFromExtension(file.path) || ''}
|
||||
fileName={file.path}
|
||||
renderSideBySide={false}
|
||||
layout="inline"
|
||||
/>
|
||||
);
|
||||
})()}
|
||||
</div>
|
||||
)}
|
||||
</li>
|
||||
))}
|
||||
|
||||
@@ -33,6 +33,7 @@ interface HistorySectionProps {
|
||||
commitFilesMap: Map<string, CommitFileEntry[]>;
|
||||
loadingCommitHashes: Set<string>;
|
||||
onCopyHash: (hash: string) => void;
|
||||
directory: string | undefined;
|
||||
showHeader?: boolean;
|
||||
contentMaxHeightClassName?: string;
|
||||
branchDivider?: {
|
||||
@@ -52,6 +53,7 @@ export const HistorySection: React.FC<HistorySectionProps> = ({
|
||||
commitFilesMap,
|
||||
loadingCommitHashes,
|
||||
onCopyHash,
|
||||
directory,
|
||||
showHeader = true,
|
||||
contentMaxHeightClassName = 'max-h-[50vh]',
|
||||
branchDivider = null,
|
||||
@@ -92,6 +94,7 @@ export const HistorySection: React.FC<HistorySectionProps> = ({
|
||||
files={commitFilesMap.get(entry.hash) ?? []}
|
||||
isLoadingFiles={loadingCommitHashes.has(entry.hash)}
|
||||
onCopyHash={onCopyHash}
|
||||
directory={directory}
|
||||
/>
|
||||
))}
|
||||
</ul>
|
||||
|
||||
Reference in New Issue
Block a user