BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: map PR summaries to directory branch keys

Browse Source 
Preserves a stable lookup key for PR status summaries
Displays PR indicators using directory and branch labels
Skips unmatched summary entries safely
This commit is contained in:
Bohdan Triapitsyn
2026-07-22 16:34:25 +03:00
parent de6fa36960
commit 63d37eecdf
1 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/session/SessionSidebar.tsx
+19 -7
View File
@@ -1324,9 +1324,15 @@ const SessionSidebarComponent: React.FC<SessionSidebarProps> = ({
})); }));
}, [sectionsForRender, showArchivedSessions]); }, [sectionsForRender, showArchivedSessions]);
const prLookupKeys = React.useMemo(() => { const prLookup = React.useMemo(() => {
if (!isVisible) return EMPTY_STRING_ARRAY; if (!isVisible) {
return {
keys: EMPTY_STRING_ARRAY,
displayKeyByLookupKey: new Map<string, string>(),
};
}
const keys = new Set<string>(); const keys = new Set<string>();
const displayKeyByLookupKey = new Map<string, string>();
sectionsForSidebarRender.forEach((section) => { sectionsForSidebarRender.forEach((section) => {
section.groups.forEach((group) => { section.groups.forEach((group) => {
const directory = normalizePath(group.directory ?? null); const directory = normalizePath(group.directory ?? null);
@@ -1334,13 +1340,15 @@ const SessionSidebarComponent: React.FC<SessionSidebarProps> = ({
if (!directory || !branch) { if (!directory || !branch) {
return; return;
} }
keys.add(getGitHubPrStatusKey(directory, branch)); const lookupKey = getGitHubPrStatusKey(directory, branch);
keys.add(lookupKey);
displayKeyByLookupKey.set(lookupKey, `${directory}::${branch}`);
}); });
}); });
return [...keys]; return { keys: [...keys], displayKeyByLookupKey };
}, [gitBranches, isVisible, sectionsForSidebarRender]); }, [gitBranches, isVisible, sectionsForSidebarRender]);
const prVisualSummaryMap = usePrVisualSummaryByKeys(prLookupKeys); const prVisualSummaryMap = usePrVisualSummaryByKeys(prLookup.keys);
React.useEffect(() => { React.useEffect(() => {
if (!isVisible || !githubAuthChecked || !githubAuthStatus?.connected || !github) { if (!isVisible || !githubAuthChecked || !githubAuthStatus?.connected || !github) {
@@ -1505,7 +1513,11 @@ const SessionSidebarComponent: React.FC<SessionSidebarProps> = ({
const prVisualStateByDirectoryBranch = React.useMemo(() => { const prVisualStateByDirectoryBranch = React.useMemo(() => {
const result = new Map<string, PrIndicator>(); const result = new Map<string, PrIndicator>();
for (const [key, summary] of prVisualSummaryMap) { for (const [key, summary] of prVisualSummaryMap) {
result.set(key, { const displayKey = prLookup.displayKeyByLookupKey.get(key);
if (!displayKey) {
continue;
}
result.set(displayKey, {
visualState: summary.visualState as PrVisualState, visualState: summary.visualState as PrVisualState,
number: summary.number, number: summary.number,
url: summary.url, url: summary.url,
@@ -1521,7 +1533,7 @@ const SessionSidebarComponent: React.FC<SessionSidebarProps> = ({
}); });
} }
return result; return result;
}, [prVisualSummaryMap]); }, [prLookup.displayKeyByLookupKey, prVisualSummaryMap]);
const renderGroupSessions = React.useCallback( const renderGroupSessions = React.useCallback(
( (