BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf(ui): index and batch session updates

Browse Source 
Batch global session, status, ordering, and activity timing mutations at the existing directory event boundary so large subagent bursts publish each owner once.

Maintain active session roots, children, and directory buckets in the global store, reuse them in Sidebar projections, and avoid rebuilding live aggregates and structural data for unrelated renders while preserving authoritative ordering reconciliation.
This commit is contained in:
c_w_xiaohei
2026-08-26 00:42:37 +08:00
parent df924aa532
commit 701173e399
16 changed files with 1153 additions and 376 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/session/sidebar/list/SessionProjectCollection.tsx
+14 -11
View File
@@ -142,7 +142,7 @@ const VisibleSessionProjects: React.FC<SessionProjectCollectionProps> = ({ topol
isVSCode: topology.isVSCode,
pinnedSessionIds: collection.pinnedSessionIds,
sessionOrderRanks: collection.sessionOrderRanks,
sessions: collection.sessions,
sessions: collection.rootSessions,
});
const [editingId, setEditingId] = React.useState<string | null>(null);
const [editTitle, setEditTitle] = React.useState('');
@@ -268,6 +268,16 @@ const VisibleSessionProjects: React.FC<SessionProjectCollectionProps> = ({ topol
}),
[getOrderedGroups, sectionsForSidebarRender],
);
let selectedSingleProjectId: string | null = null;
if (singleProjectMode) {
if (projectSections.some((section) => section.project.id === singleProjectId)) {
selectedSingleProjectId = singleProjectId;
} else if (projectSections.some((section) => section.project.id === view.activeProjectId)) {
selectedSingleProjectId = view.activeProjectId;
} else {
selectedSingleProjectId = projectSections[0]?.project.id ?? null;
}
}
const groupProps = React.useMemo(() => ({
hasSessionSearchQuery: view.hasSessionSearchQuery,
normalizedSessionSearchQuery: view.normalizedSessionSearchQuery,
@@ -401,7 +411,7 @@ const VisibleSessionProjects: React.FC<SessionProjectCollectionProps> = ({ topol
hasSessionSearchQuery={view.hasSessionSearchQuery}
normalizedSessionSearchQuery={view.normalizedSessionSearchQuery}
isDesktopShellRuntime={view.isDesktopShellRuntime}
sessions={collection.sessions}
sessions={recentSessions}
childrenMap={collection.childrenMap}
pinnedSessionIds={collection.pinnedSessionIds}
recentSessions={recentSessions}
@@ -436,7 +446,6 @@ const VisibleSessionProjects: React.FC<SessionProjectCollectionProps> = ({ topol
alwaysShowActions,
collection.childrenMap,
collection.pinnedSessionIds,
collection.sessions,
copiedSessionId,
deleteSessionConfirm,
editTitle,
@@ -470,13 +479,7 @@ const VisibleSessionProjects: React.FC<SessionProjectCollectionProps> = ({ topol
projectSections,
activeProjectId: view.activeProjectId,
singleProjectMode,
singleProjectId: singleProjectMode
? (projectSections.some((section) => section.project.id === singleProjectId)
? singleProjectId
: (projectSections.some((section) => section.project.id === view.activeProjectId)
? view.activeProjectId
: projectSections[0]?.project.id ?? null))
: null,
singleProjectId: selectedSingleProjectId,
emptyState: view.emptyState,
searchEmptyState: view.searchEmptyState,
projectRepoStatus: topology.projectRepoStatus,
@@ -497,8 +500,8 @@ const VisibleSessionProjects: React.FC<SessionProjectCollectionProps> = ({ topol
view.searchEmptyState,
visibleSessionCountByGroup,
recentSection,
singleProjectId,
singleProjectMode,
selectedSingleProjectId,
]);
const scrollerView = React.useMemo(() => ({
homeDirectory: view.homeDirectory,
packages/ui/src/components/session/sidebar/list/sessionCollection.test.ts
+2
View File
@@ -238,6 +238,7 @@ describe('projectSidebarCollection', () => {
expect(projection.orderedSessions.map((entry) => entry.id)).toEqual(['managed-root', 'managed-child', 'project-root']);
expect(projection.childrenMap.get('managed-root')?.map((entry) => entry.id)).toEqual(['managed-child']);
});
});
describe('useRecentSessionCollection', () => {
@@ -299,6 +300,7 @@ describe('useRecentSessionCollection', () => {
dom.restore();
}
});
});
describe('getDescendantIds', () => {
packages/ui/src/components/session/sidebar/list/sessionCollection.ts
+111 -40
View File
@@ -2,7 +2,6 @@ import React from 'react';
import type { Session } from '@opencode-ai/sdk/v2';
import { useAllLiveSessions } from '@/sync/sync-context';
import {
compareSessionsByLifecycleOrder,
EMPTY_SESSION_ORDER_RANKS,
orderSessionsByLifecycleScopes,
useSessionOrderingStore,
@@ -15,6 +14,8 @@ import { deriveRecentSessions } from '../recent/activitySections';
import { normalizePath } from '../utils';
import { isChatDirectoryPath } from '@/lib/chatDirectories';
import { isBtwSession } from '@/lib/sessionBtwMetadata';
import type { GlobalSessionStructure } from '@/stores/globalSessionStructure';
import { countSyncPerformance } from '@/sync/performance-diagnostics';
type ProjectSidebarActiveSessionsArgs = {
globalActiveSessions: Session[];
@@ -28,6 +29,11 @@ type SidebarSessionPartitions = {
chatSessions: Session[];
};
const parentIdOf = (session: Session): string | null => {
// SAFETY: OpenCode session payloads expose parentID although the SDK base Session omits it.
return (session as Session & { parentID?: string | null }).parentID ?? null;
};
// This boundary owns session visibility before Recent or projects take
// ownership. Temporary /btw forks never leak into any sidebar projection.
export const partitionSidebarSessions = (
@@ -125,6 +131,78 @@ type SidebarSessionProjectionArgs = ProjectSidebarActiveSessionsArgs & {
sessionOrderRanks: ReadonlyMap<string, number>;
};
type SidebarSessionStructureArgs = Omit<ProjectSidebarActiveSessionsArgs, 'globalActiveSessions'> & {
globalActiveSessions?: readonly Session[];
globalStructure?: GlobalSessionStructure;
};
const buildSidebarSessionStructure = ({
globalActiveSessions,
liveSessions,
knownDirectories,
isVSCode,
globalStructure,
}: SidebarSessionStructureArgs) => {
countSyncPerformance('sidebarStructureBuilds');
const indexedGlobalSessions = globalActiveSessions ?? [];
const visibleSessions = mergeSidebarSessionSources(indexedGlobalSessions, liveSessions);
const partition = partitionSidebarSessions(visibleSessions, isVSCode);
const projectSessions = partition.projectSessions
.filter((session) => isKnownActiveSessionDirectory(session, knownDirectories, isVSCode));
const sessions = [...projectSessions, ...partition.chatSessions];
const sessionById = new Map(sessions.map((session) => [session.id, session]));
const projectSessionIds = new Set(projectSessions.map((session) => session.id));
const indexedRootIds = globalStructure?.activeRootIds ?? [];
const indexedRootIdSet = new Set(indexedRootIds);
const rootSessions = [
...indexedRootIds.flatMap((sessionId) => {
if (!projectSessionIds.has(sessionId)) return [];
const session = sessionById.get(sessionId);
return session ? [session] : [];
}),
...projectSessions.filter((session) => (
!indexedRootIdSet.has(session.id) && !parentIdOf(session)
)),
];
return {
chatSessionIds: new Set(partition.chatSessions.map((session) => session.id)),
projectSessions,
rootSessions,
sessionById,
sessions,
hierarchy: globalStructure ? {
rootIds: globalStructure.activeRootIds,
childrenByParentId: globalStructure.activeChildrenByParentId,
} : undefined,
};
};
const orderSidebarSessionStructure = (
structure: ReturnType<typeof buildSidebarSessionStructure>,
pinnedSessionIds: Set<string>,
sessionOrderRanks: ReadonlyMap<string, number>,
) => {
const orderedSessions = orderSessionsByLifecycleScopes(
structure.sessions,
pinnedSessionIds,
sessionOrderRanks,
structure.hierarchy,
);
const childrenMap = new Map<string, Session[]>();
for (const session of orderedSessions) {
const parentID = parentIdOf(session);
if (!parentID) continue;
const siblings = childrenMap.get(parentID) ?? [];
siblings.push(session);
childrenMap.set(parentID, siblings);
}
return {
chatSessions: orderedSessions.filter((session) => structure.chatSessionIds.has(session.id)),
childrenMap,
orderedSessions,
};
};
export const buildSidebarSessionProjection = ({
globalActiveSessions,
liveSessions,
@@ -133,33 +211,17 @@ export const buildSidebarSessionProjection = ({
pinnedSessionIds,
sessionOrderRanks,
}: SidebarSessionProjectionArgs) => {
const visibleSessions = mergeSidebarSessionSources(globalActiveSessions, liveSessions);
const partition = partitionSidebarSessions(visibleSessions, isVSCode);
const projectSessions = partition.projectSessions
.filter((session) => isKnownActiveSessionDirectory(session, knownDirectories, isVSCode));
const orderedSessions = orderSessionsByLifecycleScopes(
[...projectSessions, ...partition.chatSessions],
pinnedSessionIds,
sessionOrderRanks,
);
const chatSessionIds = new Set(partition.chatSessions.map((session) => session.id));
const sessionById = new Map(orderedSessions.map((session) => [session.id, session]));
const childrenMap = new Map<string, Session[]>();
for (const session of sessionById.values()) {
// SAFETY: OpenCode's session records carry parentID for sub-session
// hierarchy; the SDK's base Session type does not currently expose it.
const parentID = (session as Session & { parentID?: string | null }).parentID;
if (!parentID) continue;
const siblings = childrenMap.get(parentID) ?? [];
siblings.push(session);
childrenMap.set(parentID, siblings);
}
const structure = buildSidebarSessionStructure({
globalActiveSessions,
liveSessions,
knownDirectories,
isVSCode,
});
const ordering = orderSidebarSessionStructure(structure, pinnedSessionIds, sessionOrderRanks);
return {
chatSessions: orderedSessions.filter((session) => chatSessionIds.has(session.id)),
childrenMap,
orderedSessions,
projectSessions,
sessionById,
...ordering,
projectSessions: structure.projectSessions,
sessionById: structure.sessionById,
};
};
@@ -178,6 +240,7 @@ export const useSessionProjectCollection = ({
isVisible,
}: UseSessionProjectCollectionArgs) => {
const globalActiveSessions = useGlobalSessionsStore((state) => state.activeSessions);
const globalStructure = useGlobalSessionsStore((state) => state.structure);
const archivedSessions = useGlobalSessionsStore((state) => state.archivedSessions);
const hasAuthoritativeGlobalSessions = useGlobalSessionsStore((state) => state.status === 'ready');
const liveSessions = useAllLiveSessions();
@@ -186,21 +249,25 @@ export const useSessionProjectCollection = ({
(state) => isVisible ? state.rankById : EMPTY_SESSION_ORDER_RANKS,
[isVisible],
));
const projection = React.useMemo(() => buildSidebarSessionProjection({
const structure = React.useMemo(() => buildSidebarSessionStructure({
globalActiveSessions,
globalStructure,
liveSessions,
knownDirectories,
isVSCode,
pinnedSessionIds,
sessionOrderRanks,
}), [globalActiveSessions, isVSCode, knownDirectories, liveSessions, pinnedSessionIds, sessionOrderRanks]);
const { chatSessions, orderedSessions, projectSessions: sessions } = projection;
}), [globalActiveSessions, globalStructure, isVSCode, knownDirectories, liveSessions]);
const ordering = React.useMemo(
() => orderSidebarSessionStructure(structure, pinnedSessionIds, sessionOrderRanks),
[pinnedSessionIds, sessionOrderRanks, structure],
);
const { chatSessions, orderedSessions } = ordering;
const sessions = structure.projectSessions;
const sessionById = React.useMemo(() => new Map(
[...orderedSessions, ...archivedSessions].map((session) => [session.id, session]),
), [archivedSessions, orderedSessions]);
[...structure.sessions, ...archivedSessions].map((session) => [session.id, session]),
), [archivedSessions, structure.sessions]);
const childrenMap = React.useMemo(() => {
const children = new Map<string, Session[]>();
for (const session of sessionById.values()) {
const children = new Map(ordering.childrenMap);
for (const session of archivedSessions) {
// SAFETY: OpenCode's session records carry parentID for sub-session
// hierarchy; the SDK's base Session type does not currently expose it.
const parentID = (session as Session & { parentID?: string | null }).parentID;
@@ -210,7 +277,7 @@ export const useSessionProjectCollection = ({
children.set(parentID, siblings);
}
return children;
}, [sessionById]);
}, [archivedSessions, ordering.childrenMap]);
const getDescendantIdsForAction = React.useCallback(
(sessionId: string, options: { includeArchived: boolean }) => getDescendantIds(childrenMap, sessionId)
.filter((id) => options.includeArchived || !sessionById.get(id)?.time?.archived),
@@ -222,13 +289,13 @@ export const useSessionProjectCollection = ({
childrenMap,
chatSessions,
getDescendantIds: getDescendantIdsForAction,
globalActiveSessions,
hasAuthoritativeGlobalSessions,
liveSessions,
orderedSessions,
pinnedSessionIds,
sessionOrderRanks,
sessions,
rootSessions: structure.rootSessions,
};
};
@@ -258,7 +325,11 @@ export const useRecentSessionCollection = ({
return React.useMemo(() => {
if (!enabled || isVSCode) return [];
return deriveRecentSessions(sessions, activeSessionIdSet)
.sort((left, right) => compareSessionsByLifecycleOrder(left, right, pinnedSessionIds, sessionOrderRanks));
countSyncPerformance('recentCandidatesVisited', sessions.length);
return orderSessionsByLifecycleScopes(
deriveRecentSessions(sessions, activeSessionIdSet),
pinnedSessionIds,
sessionOrderRanks,
);
}, [activeSessionIdSet, enabled, isVSCode, pinnedSessionIds, sessionOrderRanks, sessions]);
};