fix(tasks): avoid weekday checkbox double toggle (#1225)
* fix(tasks): avoid weekday checkbox double toggle * fix(tasks): preserve weekday hover affordance * fix(tasks): remove redundant weekday hover class --------- Co-authored-by: Isaac Sanchez <isanchez-hawkins@arize.com>
This commit is contained in:
committed by
GitHub
co-authored by
Isaac Sanchez
parent
e0ef318751
commit
75ad1d31b5
@@ -1210,19 +1210,22 @@ export function ScheduledTaskEditorDialog(props: {
|
|||||||
{orderedWeekdays.map((weekday) => {
|
{orderedWeekdays.map((weekday) => {
|
||||||
const checked = draft.schedule.weekdays.includes(weekday.value);
|
const checked = draft.schedule.weekdays.includes(weekday.value);
|
||||||
return (
|
return (
|
||||||
<button
|
<div
|
||||||
key={weekday.value}
|
key={weekday.value}
|
||||||
type="button"
|
|
||||||
onClick={() => toggleWeekday(weekday.value, !checked)}
|
|
||||||
className={[
|
className={[
|
||||||
'inline-flex items-center gap-1.5 px-0.5 py-0.5 typography-meta',
|
'group inline-flex items-center gap-1.5 px-0.5 py-0.5 typography-meta',
|
||||||
checked ? 'text-foreground' : 'text-muted-foreground',
|
checked ? 'text-foreground' : 'text-muted-foreground',
|
||||||
'hover:text-foreground',
|
|
||||||
].join(' ')}
|
].join(' ')}
|
||||||
>
|
>
|
||||||
<Checkbox checked={checked} onChange={(next) => toggleWeekday(weekday.value, next)} ariaLabel={weekday.label} />
|
<Checkbox checked={checked} onChange={(next) => toggleWeekday(weekday.value, next)} ariaLabel={weekday.label} />
|
||||||
<span>{weekday.label}</span>
|
<button
|
||||||
</button>
|
type="button"
|
||||||
|
onClick={() => toggleWeekday(weekday.value, !checked)}
|
||||||
|
className="group-hover:text-foreground"
|
||||||
|
>
|
||||||
|
{weekday.label}
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
Reference in New Issue
Block a user