perf: overhaul session loading, caching, and runtime isolation (#2360)

Improve OpenChamber responsiveness under large session workloads while fixing
cache, synchronization, and persistence correctness across runtimes, projects,
directories, and worktrees.

- prioritize selected and visible sessions during bootstrap and defer
  non-critical enrichment work
- reduce redundant message loading, event processing, store publication, and
  hidden sidebar work
- prevent stale session and message requests from overwriting newer
  authoritative state
- preserve existing data when authoritative fetches fail instead of treating
  failures as successful empty responses
- scope session materialization, messages, drafts, queues, todos, pins,
  permissions, folders, tabs, Git state, and pull request data by runtime and
  directory identity
- harden runtime switching, reconnect, cleanup, mutation reconciliation, and
  persisted-state ordering
- preserve live subagent Task linkage when metadata arrives after an older
  message request or while streaming parts are suspended
- coalesce overlapping tail refreshes without losing newer refresh demand
- improve cold-session loading by moving deferrable work out of the critical
  bootstrap path
- isolate URL authentication, mobile credentials, native secrets, and other
  runtime-owned state across endpoint changes
- bound long-lived caches and remove avoidable allocations from event and
  rendering hot paths
- limit virtualization to archive collections where it improves rendering
  without disrupting active sidebar layout
- stabilize session folders, pin ordering, expanded state, and persisted
  sidebar behavior
- open skill files through the same secure editor and outside-workspace grant
  flow used by file navigation, including worktree sessions
- expand regression coverage for stale completions, runtime collisions,
  reconnect behavior, persistence races, authoritative empty results, and
  subagent refresh ordering
- document the updated synchronization, cache ownership, performance, and
  runtime-isolation invariants
This commit is contained in:
Bohdan Triapitsyn
2026-07-21 20:52:20 +03:00
committed by GitHub
parent 485efc7117
commit 85400459e9
197 changed files with 10835 additions and 3400 deletions
+19 -21
View File
@@ -1,5 +1,3 @@
import type {
GitStatus,
GitDiffResponse,
@@ -37,6 +35,7 @@ import type {
} from './api/types';
import { runtimeFetch } from './runtime-fetch';
import { getRuntimeUrlResolver } from './runtime-url';
import { getRuntimeKey } from './runtime-switch';
const API_BASE = '/api/git';
const GIT_STATUS_CACHE_TTL_MS = 1200;
@@ -48,24 +47,22 @@ const gitRepoCache = new Map<string, { value: boolean; expiresAt: number }>();
const gitRepoInFlight = new Map<string, Promise<boolean>>();
const normalizeDirectoryKey = (directory: string): string => directory.trim();
const getStatusCacheKey = (directory: string, mode?: 'light'): string =>
mode === 'light' ? `${normalizeDirectoryKey(directory)}::light` : normalizeDirectoryKey(directory);
const getDirectoryCacheKey = (runtimeKey: string, directory: string): string =>
JSON.stringify([runtimeKey, normalizeDirectoryKey(directory)]);
const getStatusCacheKey = (runtimeKey: string, directory: string, mode?: 'light'): string =>
JSON.stringify([runtimeKey, normalizeDirectoryKey(directory), mode ?? 'full']);
const getStatusCacheVersion = (directory: string): number =>
gitStatusCacheVersions.get(normalizeDirectoryKey(directory)) ?? 0;
const getStatusCacheVersion = (runtimeKey: string, directory: string): number =>
gitStatusCacheVersions.get(getDirectoryCacheKey(runtimeKey, directory)) ?? 0;
const invalidateGitStatusCache = (directory: string): void => {
const key = normalizeDirectoryKey(directory);
gitStatusCacheVersions.set(key, getStatusCacheVersion(directory) + 1);
for (const cacheKey of Array.from(gitStatusCache.keys())) {
if (cacheKey === key || cacheKey.startsWith(`${key}::`)) {
gitStatusCache.delete(cacheKey);
}
}
for (const cacheKey of Array.from(gitStatusInFlight.keys())) {
if (cacheKey === key || cacheKey.startsWith(`${key}::`)) {
gitStatusInFlight.delete(cacheKey);
}
const runtimeKey = getRuntimeKey();
const key = getDirectoryCacheKey(runtimeKey, directory);
gitStatusCacheVersions.set(key, getStatusCacheVersion(runtimeKey, directory) + 1);
for (const mode of [undefined, 'light'] as const) {
const statusKey = getStatusCacheKey(runtimeKey, directory, mode);
gitStatusCache.delete(statusKey);
gitStatusInFlight.delete(statusKey);
}
};
@@ -81,7 +78,7 @@ function buildUrl(
}
export async function checkIsGitRepository(directory: string): Promise<boolean> {
const key = normalizeDirectoryKey(directory);
const key = getDirectoryCacheKey(getRuntimeKey(), directory);
const now = Date.now();
const cached = gitRepoCache.get(key);
if (cached && cached.expiresAt > now) {
@@ -119,7 +116,8 @@ export async function checkIsGitRepository(directory: string): Promise<boolean>
export async function getGitStatus(directory: string, options?: { mode?: 'light' }): Promise<GitStatus> {
const mode = options?.mode;
const key = getStatusCacheKey(directory, mode);
const runtimeKey = getRuntimeKey();
const key = getStatusCacheKey(runtimeKey, directory, mode);
const now = Date.now();
const cached = gitStatusCache.get(key);
if (cached && cached.expiresAt > now) {
@@ -132,13 +130,13 @@ export async function getGitStatus(directory: string, options?: { mode?: 'light'
}
const task = (async () => {
const cacheVersion = getStatusCacheVersion(directory);
const cacheVersion = getStatusCacheVersion(runtimeKey, directory);
const response = await runtimeFetch(buildUrl(`${API_BASE}/status`, directory, mode ? { mode } : undefined));
if (!response.ok) {
throw new Error(`Failed to get git status: ${response.statusText}`);
}
const payload = await response.json() as GitStatus;
if (getStatusCacheVersion(directory) === cacheVersion) {
if (getStatusCacheVersion(runtimeKey, directory) === cacheVersion) {
gitStatusCache.set(key, {
value: payload,
expiresAt: Date.now() + GIT_STATUS_CACHE_TTL_MS,