perf: overhaul session loading, caching, and runtime isolation (#2360)
Improve OpenChamber responsiveness under large session workloads while fixing cache, synchronization, and persistence correctness across runtimes, projects, directories, and worktrees. - prioritize selected and visible sessions during bootstrap and defer non-critical enrichment work - reduce redundant message loading, event processing, store publication, and hidden sidebar work - prevent stale session and message requests from overwriting newer authoritative state - preserve existing data when authoritative fetches fail instead of treating failures as successful empty responses - scope session materialization, messages, drafts, queues, todos, pins, permissions, folders, tabs, Git state, and pull request data by runtime and directory identity - harden runtime switching, reconnect, cleanup, mutation reconciliation, and persisted-state ordering - preserve live subagent Task linkage when metadata arrives after an older message request or while streaming parts are suspended - coalesce overlapping tail refreshes without losing newer refresh demand - improve cold-session loading by moving deferrable work out of the critical bootstrap path - isolate URL authentication, mobile credentials, native secrets, and other runtime-owned state across endpoint changes - bound long-lived caches and remove avoidable allocations from event and rendering hot paths - limit virtualization to archive collections where it improves rendering without disrupting active sidebar layout - stabilize session folders, pin ordering, expanded state, and persisted sidebar behavior - open skill files through the same secure editor and outside-workspace grant flow used by file navigation, including worktree sessions - expand regression coverage for stale completions, runtime collisions, reconnect behavior, persistence races, authoritative empty results, and subagent refresh ordering - document the updated synchronization, cache ownership, performance, and runtime-isolation invariants
This commit is contained in:
committed by
GitHub
parent
485efc7117
commit
85400459e9
@@ -1,6 +1,7 @@
|
||||
import { create } from 'zustand';
|
||||
import { devtools } from 'zustand/middleware';
|
||||
import { opencodeClient, type ProjectFileSearchHit } from '@/lib/opencode/client';
|
||||
import { getRuntimeKey } from '@/lib/runtime-switch';
|
||||
|
||||
const CACHE_TTL_MS = 30_000;
|
||||
const MAX_CACHE_ENTRIES = 40;
|
||||
@@ -22,9 +23,11 @@ interface FileSearchStoreState {
|
||||
options?: { includeHidden?: boolean; respectGitignore?: boolean; type?: 'file' | 'directory' }
|
||||
) => Promise<ProjectFileSearchHit[]>;
|
||||
invalidateDirectory: (directory?: string | null) => void;
|
||||
resetForRuntimeSwitch: () => void;
|
||||
}
|
||||
|
||||
const buildCacheKey = (
|
||||
runtimeKey: string,
|
||||
directory: string,
|
||||
query: string,
|
||||
limit: number,
|
||||
@@ -34,13 +37,13 @@ const buildCacheKey = (
|
||||
) => {
|
||||
const normalizedDirectory = directory.trim();
|
||||
const normalizedQuery = query.trim().toLowerCase();
|
||||
return JSON.stringify([normalizedDirectory, normalizedQuery, limit, includeHidden, respectGitignore, type]);
|
||||
return JSON.stringify([runtimeKey, normalizedDirectory, normalizedQuery, limit, includeHidden, respectGitignore, type]);
|
||||
};
|
||||
|
||||
const cacheKeyMatchesDirectory = (cacheKey: string, directory: string) => {
|
||||
try {
|
||||
const value: unknown = JSON.parse(cacheKey);
|
||||
return Array.isArray(value) && value[0] === directory;
|
||||
return Array.isArray(value) && value[1] === directory;
|
||||
} catch {
|
||||
return false;
|
||||
}
|
||||
@@ -58,11 +61,12 @@ export const useFileSearchStore = create<FileSearchStoreState>()(
|
||||
}
|
||||
|
||||
const normalizedDirectory = directory.trim();
|
||||
const runtimeKey = getRuntimeKey();
|
||||
const normalizedQuery = typeof query === 'string' ? query.trim() : '';
|
||||
const includeHidden = Boolean(options?.includeHidden);
|
||||
const respectGitignore = options?.respectGitignore ?? true;
|
||||
const type = options?.type === 'directory' ? 'directory' : 'file';
|
||||
const key = buildCacheKey(normalizedDirectory, normalizedQuery, limit, includeHidden, respectGitignore, type);
|
||||
const key = buildCacheKey(runtimeKey, normalizedDirectory, normalizedQuery, limit, includeHidden, respectGitignore, type);
|
||||
const now = Date.now();
|
||||
const cached = get().cache[key];
|
||||
|
||||
@@ -159,6 +163,9 @@ export const useFileSearchStore = create<FileSearchStoreState>()(
|
||||
};
|
||||
});
|
||||
},
|
||||
resetForRuntimeSwitch() {
|
||||
set({ cache: {}, cacheKeys: [], inFlight: {} });
|
||||
},
|
||||
}),
|
||||
{
|
||||
name: 'file-search-store',
|
||||
|
||||
Reference in New Issue
Block a user