perf: overhaul session loading, caching, and runtime isolation (#2360)
Improve OpenChamber responsiveness under large session workloads while fixing cache, synchronization, and persistence correctness across runtimes, projects, directories, and worktrees. - prioritize selected and visible sessions during bootstrap and defer non-critical enrichment work - reduce redundant message loading, event processing, store publication, and hidden sidebar work - prevent stale session and message requests from overwriting newer authoritative state - preserve existing data when authoritative fetches fail instead of treating failures as successful empty responses - scope session materialization, messages, drafts, queues, todos, pins, permissions, folders, tabs, Git state, and pull request data by runtime and directory identity - harden runtime switching, reconnect, cleanup, mutation reconciliation, and persisted-state ordering - preserve live subagent Task linkage when metadata arrives after an older message request or while streaming parts are suspended - coalesce overlapping tail refreshes without losing newer refresh demand - improve cold-session loading by moving deferrable work out of the critical bootstrap path - isolate URL authentication, mobile credentials, native secrets, and other runtime-owned state across endpoint changes - bound long-lived caches and remove avoidable allocations from event and rendering hot paths - limit virtualization to archive collections where it improves rendering without disrupting active sidebar layout - stabilize session folders, pin ordering, expanded state, and persisted sidebar behavior - open skill files through the same secure editor and outside-workspace grant flow used by file navigation, including worktree sessions - expand regression coverage for stale completions, runtime collisions, reconnect behavior, persistence races, authoritative empty results, and subagent refresh ordering - document the updated synchronization, cache ownership, performance, and runtime-isolation invariants
This commit is contained in:
committed by
GitHub
parent
485efc7117
commit
85400459e9
@@ -1,8 +1,40 @@
|
||||
import type { Event, Session } from "@opencode-ai/sdk/v2/client"
|
||||
import { useGlobalSessionsStore } from "@/stores/useGlobalSessionsStore"
|
||||
import { isGlobalSessionRecencyOnlyUpdate, useGlobalSessionsStore } from "@/stores/useGlobalSessionsStore"
|
||||
import { getRuntimeKey, subscribeRuntimeEndpointWillChange } from "@/lib/runtime-switch"
|
||||
import { streamPerfCount, streamPerfMark } from "@/stores/utils/streamDebug"
|
||||
import { stripSessionDiffSnapshots } from "./sanitize"
|
||||
import { shouldSkipStaleSessionEvent } from "./session-event-freshness"
|
||||
|
||||
const pendingGlobalSessionUpdates = new Map<string, { runtimeKey: string; session: Session }>()
|
||||
|
||||
const clearPendingGlobalSessionUpdates = (): void => {
|
||||
pendingGlobalSessionUpdates.clear()
|
||||
}
|
||||
|
||||
const flushPendingGlobalSessionUpdate = (sessionID: string): void => {
|
||||
const update = pendingGlobalSessionUpdates.get(sessionID)
|
||||
pendingGlobalSessionUpdates.delete(sessionID)
|
||||
if (!update) return
|
||||
const runtimeKey = getRuntimeKey()
|
||||
if (update.runtimeKey !== runtimeKey) return
|
||||
const currentSession = getGlobalSessionSnapshot(update.session.id)
|
||||
if (
|
||||
!currentSession
|
||||
|| shouldSkipStaleSessionEvent(currentSession, update.session)
|
||||
|| !isGlobalSessionRecencyOnlyUpdate(currentSession, update.session)
|
||||
) return
|
||||
streamPerfMark("global_sessions.event_update_flush")
|
||||
useGlobalSessionsStore.getState().upsertSession(update.session)
|
||||
streamPerfCount("ui.global_sessions.event_update_publication")
|
||||
}
|
||||
|
||||
const scheduleGlobalSessionUpdate = (session: Session): void => {
|
||||
pendingGlobalSessionUpdates.set(session.id, { runtimeKey: getRuntimeKey(), session })
|
||||
streamPerfCount("ui.global_sessions.event_update_deferred")
|
||||
}
|
||||
|
||||
subscribeRuntimeEndpointWillChange(clearPendingGlobalSessionUpdates)
|
||||
|
||||
const getSessionInfoFromPayload = (event: Event): Session | null => {
|
||||
if (event.type !== "session.created" && event.type !== "session.updated" && event.type !== "session.deleted") {
|
||||
return null
|
||||
@@ -32,7 +64,13 @@ const getGlobalSessionSnapshot = (sessionId: string): Session | null => {
|
||||
}
|
||||
|
||||
export const applySessionEventToGlobalSessions = (payload: Event): void => {
|
||||
if (payload.type === "session.created" || payload.type === "session.updated") {
|
||||
if (payload.type === "session.idle" || payload.type === "session.error") {
|
||||
const sessionID = (payload as { properties?: { sessionID?: unknown } }).properties?.sessionID
|
||||
if (typeof sessionID === "string") flushPendingGlobalSessionUpdate(sessionID)
|
||||
return
|
||||
}
|
||||
|
||||
if (payload.type === "session.created") {
|
||||
const session = getSessionInfoFromPayload(payload)
|
||||
if (session) {
|
||||
const currentSession = getGlobalSessionSnapshot(session.id)
|
||||
@@ -43,9 +81,27 @@ export const applySessionEventToGlobalSessions = (payload: Event): void => {
|
||||
return
|
||||
}
|
||||
|
||||
if (payload.type === "session.updated") {
|
||||
const session = getSessionInfoFromPayload(payload)
|
||||
if (session) {
|
||||
const currentSession = getGlobalSessionSnapshot(session.id)
|
||||
if (!shouldSkipStaleSessionEvent(currentSession, session)) {
|
||||
if (currentSession && isGlobalSessionRecencyOnlyUpdate(currentSession, session)) {
|
||||
scheduleGlobalSessionUpdate(session)
|
||||
} else {
|
||||
pendingGlobalSessionUpdates.delete(session.id)
|
||||
useGlobalSessionsStore.getState().upsertSession(session)
|
||||
streamPerfCount("ui.global_sessions.event_update_immediate")
|
||||
}
|
||||
}
|
||||
}
|
||||
return
|
||||
}
|
||||
|
||||
if (payload.type === "session.deleted") {
|
||||
const sessionID = (payload as { properties?: { sessionID?: string } }).properties?.sessionID ?? getSessionInfoFromPayload(payload)?.id
|
||||
if (sessionID) {
|
||||
pendingGlobalSessionUpdates.delete(sessionID)
|
||||
useGlobalSessionsStore.getState().removeSessions([sessionID])
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user