perf: overhaul session loading, caching, and runtime isolation (#2360)

Improve OpenChamber responsiveness under large session workloads while fixing
cache, synchronization, and persistence correctness across runtimes, projects,
directories, and worktrees.

- prioritize selected and visible sessions during bootstrap and defer
  non-critical enrichment work
- reduce redundant message loading, event processing, store publication, and
  hidden sidebar work
- prevent stale session and message requests from overwriting newer
  authoritative state
- preserve existing data when authoritative fetches fail instead of treating
  failures as successful empty responses
- scope session materialization, messages, drafts, queues, todos, pins,
  permissions, folders, tabs, Git state, and pull request data by runtime and
  directory identity
- harden runtime switching, reconnect, cleanup, mutation reconciliation, and
  persisted-state ordering
- preserve live subagent Task linkage when metadata arrives after an older
  message request or while streaming parts are suspended
- coalesce overlapping tail refreshes without losing newer refresh demand
- improve cold-session loading by moving deferrable work out of the critical
  bootstrap path
- isolate URL authentication, mobile credentials, native secrets, and other
  runtime-owned state across endpoint changes
- bound long-lived caches and remove avoidable allocations from event and
  rendering hot paths
- limit virtualization to archive collections where it improves rendering
  without disrupting active sidebar layout
- stabilize session folders, pin ordering, expanded state, and persisted
  sidebar behavior
- open skill files through the same secure editor and outside-workspace grant
  flow used by file navigation, including worktree sessions
- expand regression coverage for stale completions, runtime collisions,
  reconnect behavior, persistence races, authoritative empty results, and
  subagent refresh ordering
- document the updated synchronization, cache ownership, performance, and
  runtime-isolation invariants
This commit is contained in:
Bohdan Triapitsyn
2026-07-21 20:52:20 +03:00
committed by GitHub
parent 485efc7117
commit 85400459e9
197 changed files with 10835 additions and 3400 deletions
+1 -1
View File
@@ -59,7 +59,7 @@ Keep `bridge.ts` as a thin orchestration layer that delegates message handling t
- `bridge-permission-auto-accept-runtime.ts`
- Owns the persisted VS Code permission auto-accept policy and its GET/PUT bridge contract.
- Broadcasts policy snapshots to every active OpenChamber webview. Permission replies remain foreground UI-owned because VS Code does not run the OpenChamber server runtime.
- Serializes reads and read-modify-write updates, persists a monotonic policy revision, and broadcasts the exact committed snapshot to every active OpenChamber webview. Permission replies remain foreground UI-owned because VS Code does not run the OpenChamber server runtime.
## Extension guideline
@@ -24,14 +24,36 @@ describe('VS Code permission auto-accept policy bridge', () => {
}, context, dependencies);
assert.equal(response?.success, true);
assert.deepEqual(response?.data, { sessions: { root: true } });
assert.deepEqual(broadcasts, [{ sessions: { root: true } }]);
assert.deepEqual(response?.data, { sessions: { root: true }, revision: 1 });
assert.deepEqual(broadcasts, [{ sessions: { root: true }, revision: 1 }]);
const reloaded = await handlePermissionAutoAcceptBridgeMessage({
id: '2',
type: 'api:permission-auto-accept:get',
}, context, dependencies);
assert.deepEqual(reloaded?.data, { sessions: { root: true } });
assert.deepEqual(reloaded?.data, { sessions: { root: true }, revision: 1 });
});
test('serializes concurrent writes without losing policy entries', async () => {
const context = createContext();
const dependencies = { broadcast: async () => undefined };
const first = handlePermissionAutoAcceptBridgeMessage({
id: '1',
type: 'api:permission-auto-accept:set',
payload: { sessionId: 'root', enabled: true },
}, context, dependencies);
const second = handlePermissionAutoAcceptBridgeMessage({
id: '2',
type: 'api:permission-auto-accept:set',
payload: { sessionId: 'child', enabled: false },
}, context, dependencies);
await Promise.all([first, second]);
const reloaded = await handlePermissionAutoAcceptBridgeMessage({
id: '3',
type: 'api:permission-auto-accept:get',
}, context, dependencies);
assert.deepEqual(reloaded?.data, { sessions: { root: true, child: false }, revision: 2 });
});
test('rejects malformed policy writes', async () => {
@@ -9,6 +9,7 @@ type PolicyContext = {
export type PermissionAutoAcceptSnapshot = {
sessions: Record<string, boolean>;
revision: number;
};
const normalizeSnapshot = (value: unknown): PermissionAutoAcceptSnapshot => {
@@ -22,25 +23,50 @@ const normalizeSnapshot = (value: unknown): PermissionAutoAcceptSnapshot => {
for (const [sessionId, enabled] of entries) {
if (sessionId && typeof enabled === 'boolean') sessions[sessionId] = enabled;
}
return { sessions };
const revision = Number.isSafeInteger((source as { revision?: unknown }).revision)
&& Number((source as { revision?: unknown }).revision) >= 0
? Number((source as { revision?: unknown }).revision)
: 0;
return { sessions, revision };
};
const readPermissionAutoAcceptPolicy = (context: PolicyContext) =>
normalizeSnapshot(context.globalState.get(STORAGE_KEY));
const operationQueues = new WeakMap<object, Promise<void>>();
const serialize = async <T>(context: PolicyContext, operation: () => Promise<T>): Promise<T> => {
const owner = context.globalState as object;
const previous = operationQueues.get(owner) ?? Promise.resolve();
let release!: () => void;
const current = new Promise<void>((resolve) => { release = resolve; });
const queued = previous.catch(() => undefined).then(() => current);
operationQueues.set(owner, queued);
await previous.catch(() => undefined);
try {
return await operation();
} finally {
release();
if (operationQueues.get(owner) === queued) operationQueues.delete(owner);
}
};
async function setPermissionAutoAcceptPolicy(
context: PolicyContext,
sessionId: string,
enabled: boolean,
broadcast: (snapshot: PermissionAutoAcceptSnapshot) => PromiseLike<unknown>,
) {
const current = readPermissionAutoAcceptPolicy(context);
const snapshot = {
sessions: { ...current.sessions, [sessionId]: enabled },
};
await context.globalState.update(STORAGE_KEY, snapshot);
await broadcast(snapshot);
return snapshot;
return serialize(context, async () => {
const current = readPermissionAutoAcceptPolicy(context);
const snapshot = {
sessions: { ...current.sessions, [sessionId]: enabled },
revision: current.revision + 1,
};
await context.globalState.update(STORAGE_KEY, snapshot);
await broadcast(snapshot);
return snapshot;
});
}
export async function handlePermissionAutoAcceptBridgeMessage(
@@ -54,7 +80,8 @@ export async function handlePermissionAutoAcceptBridgeMessage(
if (!context) return { id: message.id, type: message.type, success: false, error: 'Extension context is unavailable' };
if (message.type === 'api:permission-auto-accept:get') {
return { id: message.id, type: message.type, success: true, data: readPermissionAutoAcceptPolicy(context) };
const snapshot = await serialize(context, async () => readPermissionAutoAcceptPolicy(context));
return { id: message.id, type: message.type, success: true, data: snapshot };
}
const payload = message.payload && typeof message.payload === 'object'
+5 -2
View File
@@ -28,15 +28,18 @@ const readAuthFile = (): AuthFile => {
const writeAuthFile = (auth: AuthFile): void => {
try {
if (!fs.existsSync(OPENCODE_DATA_DIR)) {
fs.mkdirSync(OPENCODE_DATA_DIR, { recursive: true });
fs.mkdirSync(OPENCODE_DATA_DIR, { recursive: true, mode: 0o700 });
}
if (process.platform !== 'win32') fs.chmodSync(OPENCODE_DATA_DIR, 0o700);
if (fs.existsSync(AUTH_FILE)) {
const backupFile = `${AUTH_FILE}.openchamber.backup`;
fs.copyFileSync(AUTH_FILE, backupFile);
if (process.platform !== 'win32') fs.chmodSync(backupFile, 0o600);
}
fs.writeFileSync(AUTH_FILE, JSON.stringify(auth, null, 2), 'utf8');
fs.writeFileSync(AUTH_FILE, JSON.stringify(auth, null, 2), { encoding: 'utf8', mode: 0o600 });
if (process.platform !== 'win32') fs.chmodSync(AUTH_FILE, 0o600);
} catch (error) {
console.error('Failed to write auth file:', error);
throw new Error('Failed to write OpenCode auth configuration');