fix(chat): make linked reference removal focusable (#1156)
Co-authored-by: Isaac Sanchez <isanchez-hawkins@arize.com>
This commit is contained in:
Isaac Sanchez-Hawkins
committed by
GitHub
GitHub
co-authored by
Isaac Sanchez
Isaac Sanchez
parent
817fafbe29
commit
8f1e5c0085
@@ -3408,101 +3408,105 @@ const ChatInputComponent: React.FC<ChatInputProps> = ({ onOpenSettings, scrollTo
|
|||||||
{/* Linked Issue row */}
|
{/* Linked Issue row */}
|
||||||
{linkedIssue && !isVSCode && (
|
{linkedIssue && !isVSCode && (
|
||||||
<div className="pb-2 w-full px-1">
|
<div className="pb-2 w-full px-1">
|
||||||
<button
|
<div className="flex w-full items-center gap-1.5 text-sm h-5 px-1">
|
||||||
type="button"
|
<button
|
||||||
onClick={() => setIssuePickerOpen(true)}
|
type="button"
|
||||||
className="flex w-full items-center gap-1.5 text-sm hover:opacity-80 transition-opacity text-left h-5 px-1"
|
onClick={() => setIssuePickerOpen(true)}
|
||||||
>
|
className="flex min-w-0 flex-1 items-center gap-1.5 text-left hover:opacity-80 transition-opacity"
|
||||||
{linkedIssue.author?.avatarUrl && (
|
>
|
||||||
<img
|
{linkedIssue.author?.avatarUrl && (
|
||||||
src={linkedIssue.author.avatarUrl}
|
<img
|
||||||
alt={linkedIssue.author.login}
|
src={linkedIssue.author.avatarUrl}
|
||||||
className="h-5 w-5 rounded-full flex-shrink-0"
|
alt={linkedIssue.author.login}
|
||||||
/>
|
className="h-5 w-5 rounded-full flex-shrink-0"
|
||||||
)}
|
/>
|
||||||
<span className="text-muted-foreground flex-shrink-0">
|
|
||||||
#{linkedIssue.number}
|
|
||||||
{linkedIssue.author && (
|
|
||||||
<span className="ml-1">{t('chat.chatInput.linked.byAuthor', { author: linkedIssue.author.login })}</span>
|
|
||||||
)}
|
)}
|
||||||
</span>
|
<span className="text-muted-foreground flex-shrink-0">
|
||||||
<span className="text-foreground truncate">
|
#{linkedIssue.number}
|
||||||
{linkedIssue.title}
|
{linkedIssue.author && (
|
||||||
</span>
|
<span className="ml-1">{t('chat.chatInput.linked.byAuthor', { author: linkedIssue.author.login })}</span>
|
||||||
|
)}
|
||||||
|
</span>
|
||||||
|
<span className="text-foreground truncate">
|
||||||
|
{linkedIssue.title}
|
||||||
|
</span>
|
||||||
|
</button>
|
||||||
<span className="flex items-center gap-0.5 flex-shrink-0">
|
<span className="flex items-center gap-0.5 flex-shrink-0">
|
||||||
<a
|
<a
|
||||||
href={linkedIssue.url}
|
href={linkedIssue.url}
|
||||||
target="_blank"
|
target="_blank"
|
||||||
rel="noopener noreferrer"
|
rel="noopener noreferrer"
|
||||||
onClick={(e) => e.stopPropagation()}
|
|
||||||
className="flex items-center justify-center h-6 w-6 hover:bg-[var(--interactive-hover)] rounded-full transition-colors"
|
className="flex items-center justify-center h-6 w-6 hover:bg-[var(--interactive-hover)] rounded-full transition-colors"
|
||||||
aria-label={t('chat.chatInput.linked.issue.openInBrowserAria')}
|
aria-label={t('chat.chatInput.linked.issue.openInBrowserAria')}
|
||||||
>
|
>
|
||||||
<RiExternalLinkLine className="h-4 w-4 text-muted-foreground" />
|
<RiExternalLinkLine className="h-4 w-4 text-muted-foreground" />
|
||||||
</a>
|
</a>
|
||||||
<span
|
<button
|
||||||
onClick={(e) => {
|
type="button"
|
||||||
e.stopPropagation();
|
onClick={() => {
|
||||||
setLinkedIssue(null);
|
setLinkedIssue(null);
|
||||||
}}
|
}}
|
||||||
className="flex items-center justify-center h-6 w-6 hover:bg-[var(--interactive-hover)] rounded-full transition-colors cursor-pointer"
|
className="flex items-center justify-center h-6 w-6 hover:bg-[var(--interactive-hover)] rounded-full transition-colors"
|
||||||
aria-label={t('chat.chatInput.linked.issue.removeAria')}
|
aria-label={t('chat.chatInput.linked.issue.removeAria')}
|
||||||
|
title={t('chat.chatInput.linked.issue.removeAria')}
|
||||||
>
|
>
|
||||||
<RiCloseLine className="h-4 w-4 text-muted-foreground" />
|
<RiCloseLine className="h-4 w-4 text-muted-foreground" />
|
||||||
</span>
|
</button>
|
||||||
</span>
|
</span>
|
||||||
</button>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
{linkedPr && !isVSCode && (
|
{linkedPr && !isVSCode && (
|
||||||
<div className="pb-2 w-full px-1">
|
<div className="pb-2 w-full px-1">
|
||||||
<button
|
<div className="flex w-full items-center gap-1.5 text-sm h-5 px-1">
|
||||||
type="button"
|
<button
|
||||||
onClick={() => setPrPickerOpen(true)}
|
type="button"
|
||||||
className="flex w-full items-center gap-1.5 text-sm hover:opacity-80 transition-opacity text-left h-5 px-1"
|
onClick={() => setPrPickerOpen(true)}
|
||||||
>
|
className="flex min-w-0 flex-1 items-center gap-1.5 text-left hover:opacity-80 transition-opacity"
|
||||||
{linkedPr.author?.avatarUrl && (
|
>
|
||||||
<img
|
{linkedPr.author?.avatarUrl && (
|
||||||
src={linkedPr.author.avatarUrl}
|
<img
|
||||||
alt={linkedPr.author.login}
|
src={linkedPr.author.avatarUrl}
|
||||||
className="h-5 w-5 rounded-full flex-shrink-0"
|
alt={linkedPr.author.login}
|
||||||
/>
|
className="h-5 w-5 rounded-full flex-shrink-0"
|
||||||
)}
|
/>
|
||||||
<span className="text-muted-foreground flex-shrink-0">
|
|
||||||
{t('chat.chatInput.linked.pr.number', { number: linkedPr.number })}
|
|
||||||
{linkedPr.author && (
|
|
||||||
<span className="ml-1">{t('chat.chatInput.linked.byAuthor', { author: linkedPr.author.login })}</span>
|
|
||||||
)}
|
)}
|
||||||
</span>
|
<span className="text-muted-foreground flex-shrink-0">
|
||||||
<span className="text-foreground truncate">
|
{t('chat.chatInput.linked.pr.number', { number: linkedPr.number })}
|
||||||
{linkedPr.title}
|
{linkedPr.author && (
|
||||||
</span>
|
<span className="ml-1">{t('chat.chatInput.linked.byAuthor', { author: linkedPr.author.login })}</span>
|
||||||
<span className="text-muted-foreground flex-shrink-0 typography-meta">
|
)}
|
||||||
{linkedPr.head} → {linkedPr.base}
|
</span>
|
||||||
</span>
|
<span className="text-foreground truncate">
|
||||||
|
{linkedPr.title}
|
||||||
|
</span>
|
||||||
|
<span className="text-muted-foreground flex-shrink-0 typography-meta">
|
||||||
|
{linkedPr.head} → {linkedPr.base}
|
||||||
|
</span>
|
||||||
|
</button>
|
||||||
<span className="flex items-center gap-0.5 flex-shrink-0">
|
<span className="flex items-center gap-0.5 flex-shrink-0">
|
||||||
<a
|
<a
|
||||||
href={linkedPr.url}
|
href={linkedPr.url}
|
||||||
target="_blank"
|
target="_blank"
|
||||||
rel="noopener noreferrer"
|
rel="noopener noreferrer"
|
||||||
onClick={(e) => e.stopPropagation()}
|
|
||||||
className="flex items-center justify-center h-6 w-6 hover:bg-[var(--interactive-hover)] rounded-full transition-colors"
|
className="flex items-center justify-center h-6 w-6 hover:bg-[var(--interactive-hover)] rounded-full transition-colors"
|
||||||
aria-label={t('chat.chatInput.linked.pr.openInBrowserAria')}
|
aria-label={t('chat.chatInput.linked.pr.openInBrowserAria')}
|
||||||
>
|
>
|
||||||
<RiExternalLinkLine className="h-4 w-4 text-muted-foreground" />
|
<RiExternalLinkLine className="h-4 w-4 text-muted-foreground" />
|
||||||
</a>
|
</a>
|
||||||
<span
|
<button
|
||||||
onClick={(e) => {
|
type="button"
|
||||||
e.stopPropagation();
|
onClick={() => {
|
||||||
setLinkedPr(null);
|
setLinkedPr(null);
|
||||||
}}
|
}}
|
||||||
className="flex items-center justify-center h-6 w-6 hover:bg-[var(--interactive-hover)] rounded-full transition-colors cursor-pointer"
|
className="flex items-center justify-center h-6 w-6 hover:bg-[var(--interactive-hover)] rounded-full transition-colors"
|
||||||
aria-label={t('chat.chatInput.linked.pr.removeAria')}
|
aria-label={t('chat.chatInput.linked.pr.removeAria')}
|
||||||
|
title={t('chat.chatInput.linked.pr.removeAria')}
|
||||||
>
|
>
|
||||||
<RiCloseLine className="h-4 w-4 text-muted-foreground" />
|
<RiCloseLine className="h-4 w-4 text-muted-foreground" />
|
||||||
</span>
|
</button>
|
||||||
</span>
|
</span>
|
||||||
</button>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
<MemoStatusRow
|
<MemoStatusRow
|
||||||
|
|||||||
Reference in New Issue
Block a user