feat: improve GitHub picker dialogs layout and mobile cleanup fixes #336 (#338)

This commit is contained in:
gsxdsm
2026-02-06 12:29:26 +02:00
committed by GitHub
parent f25d20a61e
commit 9e9fbbe0ce
3 changed files with 105 additions and 96 deletions
@@ -587,7 +587,7 @@ Do not implement changes until I confirm; end with: “Next actions: <1 sentence
<div className="mt-4 p-3 bg-muted/30 rounded-lg"> <div className="mt-4 p-3 bg-muted/30 rounded-lg">
<p className="typography-meta text-muted-foreground font-medium mb-2">Actions</p> <p className="typography-meta text-muted-foreground font-medium mb-2">Actions</p>
<div className="flex items-center gap-2"> <div className="flex flex-col gap-3 sm:flex-row sm:items-center sm:gap-2">
<div <div
className="flex items-center gap-2 cursor-pointer" className="flex items-center gap-2 cursor-pointer"
role="button" role="button"
@@ -618,9 +618,10 @@ Do not implement changes until I confirm; end with: “Next actions: <1 sentence
)} )}
</button> </button>
<span className="typography-meta text-muted-foreground">Create in worktree</span> <span className="typography-meta text-muted-foreground">Create in worktree</span>
<span className="typography-meta text-muted-foreground/70">(issue-&lt;number&gt;-&lt;slug&gt;)</span> <span className="typography-meta text-muted-foreground/70 hidden sm:inline">(issue-&lt;number&gt;-&lt;slug&gt;)</span>
</div> </div>
<div className="flex-1" /> <div className="hidden sm:block sm:flex-1" />
<div className="flex items-center gap-2">
{repoUrl ? ( {repoUrl ? (
<Button variant="outline" size="sm" asChild> <Button variant="outline" size="sm" asChild>
<a href={repoUrl} target="_blank" rel="noopener noreferrer"> <a href={repoUrl} target="_blank" rel="noopener noreferrer">
@@ -634,6 +635,7 @@ Do not implement changes until I confirm; end with: “Next actions: <1 sentence
</Button> </Button>
</div> </div>
</div> </div>
</div>
</DialogContent> </DialogContent>
</Dialog> </Dialog>
); );
@@ -743,7 +743,8 @@ Nice-to-have:
<div className="mt-4 p-3 bg-muted/30 rounded-lg"> <div className="mt-4 p-3 bg-muted/30 rounded-lg">
<p className="typography-meta text-muted-foreground font-medium mb-2">Actions</p> <p className="typography-meta text-muted-foreground font-medium mb-2">Actions</p>
<div className="flex items-center gap-2"> <div className="flex flex-col gap-3 sm:flex-row sm:flex-wrap sm:items-center sm:gap-x-4 sm:gap-y-2">
<div className="flex flex-col gap-2 sm:flex-row sm:gap-4">
<div <div
className="flex items-center gap-2 cursor-pointer" className="flex items-center gap-2 cursor-pointer"
role="button" role="button"
@@ -773,10 +774,9 @@ Nice-to-have:
<RiCheckboxBlankLine className="h-4 w-4" /> <RiCheckboxBlankLine className="h-4 w-4" />
)} )}
</button> </button>
<span className="typography-meta text-muted-foreground">Create session in PR worktree</span> <span className="typography-meta text-muted-foreground">Create in PR worktree</span>
</div> </div>
<div <div
className="flex items-center gap-2 cursor-pointer" className="flex items-center gap-2 cursor-pointer"
role="button" role="button"
@@ -808,8 +808,10 @@ Nice-to-have:
</button> </button>
<span className="typography-meta text-muted-foreground">Include full diff</span> <span className="typography-meta text-muted-foreground">Include full diff</span>
</div> </div>
</div>
<div className="flex-1" /> <div className="hidden sm:block sm:flex-1" />
<div className="flex items-center gap-2">
{repoUrl ? ( {repoUrl ? (
<Button variant="outline" size="sm" asChild> <Button variant="outline" size="sm" asChild>
<a href={repoUrl} target="_blank" rel="noopener noreferrer"> <a href={repoUrl} target="_blank" rel="noopener noreferrer">
@@ -823,6 +825,7 @@ Nice-to-have:
</Button> </Button>
</div> </div>
</div> </div>
</div>
</DialogContent> </DialogContent>
</Dialog> </Dialog>
); );
@@ -1800,20 +1800,12 @@ export const SessionSidebar: React.FC<SessionSidebarProps> = ({
if (projectKey !== activeProjectId) { if (projectKey !== activeProjectId) {
setActiveProject(projectKey); setActiveProject(projectKey);
} }
setActiveMainTab('chat');
if (mobileVariant) {
setSessionSwitcherOpen(false);
}
setIssuePickerOpen(true); setIssuePickerOpen(true);
}} }}
onNewSessionFromGitHubPR={() => { onNewSessionFromGitHubPR={() => {
if (projectKey !== activeProjectId) { if (projectKey !== activeProjectId) {
setActiveProject(projectKey); setActiveProject(projectKey);
} }
setActiveMainTab('chat');
if (mobileVariant) {
setSessionSwitcherOpen(false);
}
setPullRequestPickerOpen(true); setPullRequestPickerOpen(true);
}} }}
onOpenMultiRunLauncher={() => { onOpenMultiRunLauncher={() => {
@@ -1870,12 +1862,24 @@ export const SessionSidebar: React.FC<SessionSidebarProps> = ({
<GitHubIssuePickerDialog <GitHubIssuePickerDialog
open={issuePickerOpen} open={issuePickerOpen}
onOpenChange={setIssuePickerOpen} onOpenChange={(open) => {
setIssuePickerOpen(open);
if (!open && mobileVariant) {
setActiveMainTab('chat');
setSessionSwitcherOpen(false);
}
}}
/> />
<GitHubPullRequestPickerDialog <GitHubPullRequestPickerDialog
open={pullRequestPickerOpen} open={pullRequestPickerOpen}
onOpenChange={setPullRequestPickerOpen} onOpenChange={(open) => {
setPullRequestPickerOpen(open);
if (!open && mobileVariant) {
setActiveMainTab('chat');
setSessionSwitcherOpen(false);
}
}}
/> />
</div> </div>
); );