BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: remove flaky peak queue assertion in relay flow control test

Browse Source
This commit is contained in:
Bohdan Triapitsyn
2026-09-09 23:51:17 +03:00
parent 94479ff714
commit a052941e3d
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/web/server/lib/relay/flow-control.test.js
+3 -7
View File
@@ -46,8 +46,6 @@ async function exercise({ clientFlow = true, hostFlow = true, batch = true, canc
let hostData; let hostData;
const waiting = []; const waiting = [];
const down = []; const down = [];
let pendingBytes = 0;
let peakBytes = 0;
// This fixture brokers an isolated room only; it does not replace production // This fixture brokers an isolated room only; it does not replace production
// relay authentication. Neither WebSocket leg fails or drops a frame. // relay authentication. Neither WebSocket leg fails or drops a frame.
relay.on('connection', (socket, req) => { relay.on('connection', (socket, req) => {
@@ -67,8 +65,6 @@ async function exercise({ clientFlow = true, hostFlow = true, batch = true, canc
for (const frame of waiting.splice(0)) socket.send(frame.data, { binary: frame.binary }); for (const frame of waiting.splice(0)) socket.send(frame.data, { binary: frame.binary });
socket.on('message', (data, binary) => { socket.on('message', (data, binary) => {
down.push({ data, binary }); down.push({ data, binary });
pendingBytes += data.length;
peakBytes = Math.max(peakBytes, pendingBytes);
}); });
} }
}); });
@@ -80,7 +76,6 @@ async function exercise({ clientFlow = true, hostFlow = true, batch = true, canc
while (down.length && down[0].data.length <= credit) { while (down.length && down[0].data.length <= credit) {
const frame = down.shift(); const frame = down.shift();
credit -= frame.data.length; credit -= frame.data.length;
pendingBytes -= frame.data.length;
clientSocket.send(frame.data, { binary: frame.binary }); clientSocket.send(frame.data, { binary: frame.binary });
} }
}, 5); }, 5);
@@ -141,7 +136,7 @@ async function exercise({ clientFlow = true, hostFlow = true, batch = true, canc
if (!cancel) expect(Buffer.concat(chunks).equals(content)).toBe(true); if (!cancel) expect(Buffer.concat(chunks).equals(content)).toBe(true);
if (websocket) expect(wsMessages).toBe(2); if (websocket) expect(wsMessages).toBe(2);
expect(states).toEqual(['connected']); expect(states).toEqual(['connected']);
return { bytesAtProbe, peakBytes, total }; return { bytesAtProbe, total };
} finally { } finally {
client.close(); client.close();
host.stop(); host.stop();
@@ -159,7 +154,8 @@ describe('end-to-end downstream credit', () => {
test('small HTTP response overtakes bulk output without losing bytes or reconnecting', async () => { test('small HTTP response overtakes bulk output without losing bytes or reconnecting', async () => {
const result = await exercise(); const result = await exercise();
expect(result.bytesAtProbe).toBeLessThan(result.total / 2); expect(result.bytesAtProbe).toBeLessThan(result.total / 2);
expect(result.peakBytes).toBeLessThan(192 * 1024); // Queue peaks depend on real ACK timing and include encryption overhead.
// downstream-scheduler.test.js checks credit bounds with a controlled clock.
}); });
test('works without batching', async () => { test('works without batching', async () => {
const result = await exercise({ batch: false }); const result = await exercise({ batch: false });