BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ui): hide dirty branch warning on mobile

Browse Source 
Remove the uncommitted-changes tooltip, warning icon, and tooltip timer from mobile draft target triggers. Drop the unused mobile warning props while preserving desktop behavior.

Validation: UI type-check and lint passed. Oxlint and dead-code reported existing findings outside the changes. Visual validation was unavailable because the in-app browser timed out.
This commit is contained in:
Bohdan Triapitsyn
2026-09-09 23:05:06 +03:00
parent 655c0e6daf
commit b41ffc58be
2 changed files with 11 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/chat/ChatInput.tsx
-2
View File
@@ -3322,8 +3322,6 @@ const ChatInputComponent: React.FC<ChatInputProps> = ({
<MobileDraftTargetTriggers <MobileDraftTargetTriggers
selectedProject={selectedDraftProject} selectedProject={selectedDraftProject}
selectedBranchLabel={selectedDraftBranchLabel} selectedBranchLabel={selectedDraftBranchLabel}
hasUncommittedChanges={selectedDraftDirectoryHasUncommittedChanges}
announceDirtyState={newSessionDraftAnnouncesDirtyState}
showBranchSelector={shouldShowDraftBranchSelector} showBranchSelector={shouldShowDraftBranchSelector}
theme={currentTheme} theme={currentTheme}
onOpenPicker={setMobileDraftPicker} onOpenPicker={setMobileDraftPicker}
packages/ui/src/components/chat/composer/ui/DraftTargetSelectors.tsx
+11 -28
View File
@@ -64,7 +64,7 @@ export interface DraftTargetProps {
* unprompted. Off for a draft the app opened on its own at boot: that * unprompted. Off for a draft the app opened on its own at boot: that
* draft is often only a placeholder until the last session restores, and * draft is often only a placeholder until the last session restores, and
* a tooltip on an otherwise empty screen reads as a glitch. The warning * a tooltip on an otherwise empty screen reads as a glitch. The warning
* icon still shows and the tooltip stays reachable by hover or long press. * icon still shows on desktop and the tooltip stays reachable by hover.
*/ */
announceDirtyState: boolean; announceDirtyState: boolean;
projectRootBranchOption: BranchOption | null; projectRootBranchOption: BranchOption | null;
@@ -483,12 +483,11 @@ export function DraftTargetSelectors(props: DraftTargetProps) {
/** Mobile: buttons that open the bottom sheets below. */ /** Mobile: buttons that open the bottom sheets below. */
export function MobileDraftTargetTriggers( export function MobileDraftTargetTriggers(
props: Pick<DraftTargetProps, 'selectedProject' | 'selectedBranchLabel' | 'showBranchSelector' | 'hasUncommittedChanges' | 'announceDirtyState' | 'theme'> props: Pick<DraftTargetProps, 'selectedProject' | 'selectedBranchLabel' | 'showBranchSelector' | 'theme'>
& { onOpenPicker: (picker: 'project' | 'branch') => void }, & { onOpenPicker: (picker: 'project' | 'branch') => void },
) { ) {
const { t } = useI18n(); const { t } = useI18n();
const { selectedProject, selectedBranchLabel, showBranchSelector, hasUncommittedChanges, announceDirtyState, theme, onOpenPicker } = props; const { selectedProject, selectedBranchLabel, showBranchSelector, theme, onOpenPicker } = props;
const dirtyTooltip = useDirtyFlashTooltip(hasUncommittedChanges, announceDirtyState);
return ( return (
<div className="mb-1.5 flex min-w-0 items-center gap-x-2 px-0.5"> <div className="mb-1.5 flex min-w-0 items-center gap-x-2 px-0.5">
@@ -503,30 +502,14 @@ export function MobileDraftTargetTriggers(
<Icon name="arrow-down-s" className="h-3.5 w-3.5 flex-shrink-0 text-muted-foreground" /> <Icon name="arrow-down-s" className="h-3.5 w-3.5 flex-shrink-0 text-muted-foreground" />
</button> </button>
{showBranchSelector ? ( {showBranchSelector ? (
<Tooltip open={dirtyTooltip.open} onOpenChange={dirtyTooltip.onOpenChange}> <button
<TooltipTrigger asChild> type="button"
<button className="inline-flex h-7 min-w-0 max-w-[48vw] flex-shrink cursor-pointer items-center gap-1 rounded-lg px-1.5 typography-micro font-medium text-foreground/80 hover:bg-[var(--interactive-hover)]"
type="button" onClick={() => onOpenPicker('branch')}
className="inline-flex h-7 min-w-0 max-w-[48vw] flex-shrink cursor-pointer items-center gap-1 rounded-lg px-1.5 typography-micro font-medium text-foreground/80 hover:bg-[var(--interactive-hover)]" >
onClick={() => onOpenPicker('branch')} <span className="truncate">{selectedBranchLabel ?? t('chat.chatInput.branch')}</span>
> <Icon name="arrow-down-s" className="h-3.5 w-3.5 flex-shrink-0 text-muted-foreground" />
{hasUncommittedChanges ? ( </button>
<Icon
name="alert"
className="h-3.5 w-3.5 flex-shrink-0 text-[var(--status-warning)]"
aria-label={t('chat.draftDirtyNotice.indicatorAria')}
/>
) : null}
<span className="truncate">{selectedBranchLabel ?? t('chat.chatInput.branch')}</span>
<Icon name="arrow-down-s" className="h-3.5 w-3.5 flex-shrink-0 text-muted-foreground" />
</button>
</TooltipTrigger>
{hasUncommittedChanges ? (
<TooltipContent showArrow side="top" sideOffset={8} className="max-w-72">
<span className="block whitespace-pre-line">{t('chat.draftDirtyNotice.tooltip')}</span>
</TooltipContent>
) : null}
</Tooltip>
) : null} ) : null}
</div> </div>
); );