feat: session goals - server-driven goal loop with independent small-model audit (#2148)
Arm the target button in the composer and the next prompt becomes a goal: the server keeps the session working toward it (idle tick -> small-model audit -> continuation) until the objective is verifiably complete, blocked, or out of budget — even with the UI closed. Server (packages/web/server/lib/session-goal): - event-driven loop on the global SSE hub; goal state lives in session.metadata.openchamber.goal (merge-safe patches, stale-write guard by goal id), so it survives restarts and syncs to every client for free - the small-model audit (objective + last assistant turn only, language pinned to the objective) is the sole termination authority; blocked needs 3 consecutive verdicts, audit outages tolerate one unaudited continuation then stop the goal as resumable-blocked - hard stops: optional token budget, auto-continuation cap (Resume grants a fresh allowance), turn errors; user abort pauses the goal instead of blocking it, and resuming over an aborted tail nudges immediately - token accounting as a snapshot of the latest turn (input + cache.read + output), goal-relative via a creation baseline and segmented across compactions; a compaction summary skips the audit and continues - continuations reuse the session's own provider/model/agent/variant UI: - three-mode target button (arm / disarm / manage dialog), informational goal strip with inline pause/resume and an Evaluating indicator, sidebar state glyph, objective length counter (2000-char server clamp), read-only completed goals - goal entry points: composer (sessions and drafts), start-new-session- from-answer dialog, plan implement dialog (plan content becomes the objective), scheduled tasks (Run as goal + budget) - Settings -> Chat -> Goal: feature toggle + default token budget with three-layer parity (web server, client persistence, VS Code bridge); VS Code renders goal state but hides the entry points (the loop runs in the web server only) Notifications: per-turn "ready" notifications are suppressed while a goal is active; settling sends one final notification (desktop, web-push, APNs generic titles with the session name as body) honoring the completion toggle. Error/question/permission notifications are untouched. Docs: user guide (session-goals) in all 9 locales + sidebar entry, scheduled-tasks cross-reference, server module DOCUMENTATION.md.
This commit is contained in:
committed by
GitHub
parent
82c039117a
commit
bb45164ae8
@@ -0,0 +1,140 @@
|
||||
import React from 'react';
|
||||
import { Icon } from '@/components/icon/Icon';
|
||||
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';
|
||||
import { useSessionGoal } from '@/hooks/useSessionGoal';
|
||||
import { useSessionGoalArmStore } from '@/stores/useSessionGoalArmStore';
|
||||
import { SESSION_GOAL_OBJECTIVE_CHAR_LIMIT } from '@/lib/sessionGoalMetadata';
|
||||
import { SessionGoalDialog } from '@/components/chat/SessionGoalDialog';
|
||||
import { isVSCodeRuntime } from '@/lib/desktop';
|
||||
import { useI18n } from '@/lib/i18n';
|
||||
import { cn } from '@/lib/utils';
|
||||
|
||||
interface SessionGoalButtonProps {
|
||||
sessionId: string | null;
|
||||
directory?: string;
|
||||
/** Session draft is open — the goal arms for the session the draft creates. */
|
||||
draftOpen?: boolean;
|
||||
footerIconButtonClass: string;
|
||||
iconSizeClass: string;
|
||||
withTooltip?: boolean;
|
||||
}
|
||||
|
||||
// Composer target button — the goal switch. With no live goal one tap arms
|
||||
// goal mode (the next sent prompt becomes the objective; works on drafts
|
||||
// too) and a second tap disarms. While a goal is live the target stays lit
|
||||
// (info while running, success when complete, error when blocked / out of
|
||||
// budget) and tapping opens the manage dialog.
|
||||
export const SessionGoalButton: React.FC<SessionGoalButtonProps> = React.memo(({
|
||||
sessionId,
|
||||
directory,
|
||||
draftOpen = false,
|
||||
footerIconButtonClass,
|
||||
iconSizeClass,
|
||||
withTooltip = false,
|
||||
}) => {
|
||||
const { t } = useI18n();
|
||||
const { goal, enabled } = useSessionGoal(sessionId ?? '', directory);
|
||||
const armed = useSessionGoalArmStore((state) => state.armed);
|
||||
const setArmed = useSessionGoalArmStore((state) => state.setArmed);
|
||||
const [dialogOpen, setDialogOpen] = React.useState(false);
|
||||
|
||||
// The goal loop runs in the web server; the VS Code extension only renders
|
||||
// goal state. Arming a goal there would create one nothing drives, so the
|
||||
// entry point is hidden entirely.
|
||||
if (isVSCodeRuntime() || !enabled || (!sessionId && !draftOpen)) {
|
||||
return null;
|
||||
}
|
||||
|
||||
// A settled goal no longer drives the loop — the button goes back to being
|
||||
// an arm switch, while still tinting with the outcome color.
|
||||
const liveGoal = goal && goal.status !== 'complete' ? goal : null;
|
||||
const isEngaged = armed || Boolean(liveGoal);
|
||||
|
||||
const colorClass = (() => {
|
||||
if (goal?.status === 'complete') return 'text-[var(--status-success)]';
|
||||
if (goal?.status === 'blocked' || goal?.status === 'budgetLimited') return 'text-[var(--status-error)]';
|
||||
if (armed || goal?.status === 'active' || goal?.status === 'paused') return 'text-[var(--status-info)]';
|
||||
return '';
|
||||
})();
|
||||
|
||||
const label = goal
|
||||
? t('chat.goal.button.manageAria')
|
||||
: (armed ? t('chat.goal.button.disarmAria') : t('chat.goal.button.armAria'));
|
||||
|
||||
// Any existing goal (live or completed) opens the manage dialog — a
|
||||
// completed goal must be removed there before a new one can be armed.
|
||||
const handleClick = () => {
|
||||
if (goal) {
|
||||
setDialogOpen(true);
|
||||
return;
|
||||
}
|
||||
setArmed(!armed);
|
||||
};
|
||||
|
||||
const button = (
|
||||
<button
|
||||
type="button"
|
||||
className={cn(footerIconButtonClass, colorClass)}
|
||||
onClick={handleClick}
|
||||
aria-label={label}
|
||||
aria-pressed={isEngaged}
|
||||
{...(withTooltip ? {} : { title: label })}
|
||||
>
|
||||
{isEngaged || goal ? (
|
||||
<Icon name="target-fill" className={cn(iconSizeClass, 'text-current')} aria-hidden="true" />
|
||||
) : (
|
||||
<Icon name="target" className={cn(iconSizeClass, 'text-current')} aria-hidden="true" />
|
||||
)}
|
||||
</button>
|
||||
);
|
||||
|
||||
return (
|
||||
<>
|
||||
{withTooltip ? (
|
||||
<Tooltip>
|
||||
<TooltipTrigger asChild>{button}</TooltipTrigger>
|
||||
<TooltipContent side="top" sideOffset={6}>{label}</TooltipContent>
|
||||
</Tooltip>
|
||||
) : button}
|
||||
{sessionId ? (
|
||||
<SessionGoalDialog open={dialogOpen} onOpenChange={setDialogOpen} sessionId={sessionId} directory={directory} />
|
||||
) : null}
|
||||
</>
|
||||
);
|
||||
});
|
||||
|
||||
SessionGoalButton.displayName = 'SessionGoalButton';
|
||||
|
||||
interface SessionGoalObjectiveCounterProps {
|
||||
/** Current composer text length — the armed message becomes the objective. */
|
||||
length: number;
|
||||
}
|
||||
|
||||
// Tiny hot-path leaf next to the target button: while goal mode is armed the
|
||||
// typed message becomes the objective, which the server clamps to 2000
|
||||
// chars — surface that limit during typing instead of truncating silently.
|
||||
// Renders null when not armed, so normal typing shows nothing.
|
||||
export const SessionGoalObjectiveCounter: React.FC<SessionGoalObjectiveCounterProps> = React.memo(({ length }) => {
|
||||
const { t } = useI18n();
|
||||
const armed = useSessionGoalArmStore((state) => state.armed);
|
||||
|
||||
if (!armed || length === 0) {
|
||||
return null;
|
||||
}
|
||||
|
||||
const over = length > SESSION_GOAL_OBJECTIVE_CHAR_LIMIT;
|
||||
return (
|
||||
<span
|
||||
className={cn(
|
||||
'flex-shrink-0 self-center typography-micro tabular-nums',
|
||||
over ? 'text-[var(--status-error)]' : 'text-muted-foreground/70',
|
||||
)}
|
||||
aria-label={t('chat.goal.counter.aria')}
|
||||
title={t('chat.goal.counter.aria')}
|
||||
>
|
||||
{length}/{SESSION_GOAL_OBJECTIVE_CHAR_LIMIT}
|
||||
</span>
|
||||
);
|
||||
});
|
||||
|
||||
SessionGoalObjectiveCounter.displayName = 'SessionGoalObjectiveCounter';
|
||||
Reference in New Issue
Block a user