feat: persist permission auto-accept on server (#2158)
Move per-session permission auto-accept policy ownership from the UI to the OpenChamber server so enabled sessions continue running when clients disconnect or the server restarts. - persist explicit per-session policies in OpenChamber settings - inherit the nearest explicit policy across subagent session hierarchies - allow child sessions to opt out of an inherited parent policy - immediately accept matching global and directory-scoped pending requests - process future requests without requiring a connected UI client - reconcile pending permissions after startup and event-stream reconnects - deduplicate concurrent requests and retry transient reply failures - synchronize policy updates across connected clients - migrate existing browser-persisted policies to server storage - suppress auto-accepted permission cards before they enter UI state - show deduplicated permission toasts for inactive sessions - preserve foreground-only permission handling in VS Code - integrate directory-aware notification routing from main - add coverage for persistence, inheritance, retries, reconciliation, pending requests, client hydration, and inactive-session toasts
This commit is contained in:
committed by
GitHub
parent
3d90eddcaf
commit
d738d41574
@@ -0,0 +1,48 @@
|
||||
import { describe, expect, test } from 'bun:test';
|
||||
import type { PermissionRequest } from '@/types/permission';
|
||||
import { showPermissionNeededToast } from './permission-toast';
|
||||
|
||||
const permission = {
|
||||
id: 'permission-1',
|
||||
sessionID: 'inactive-session',
|
||||
permission: 'bash',
|
||||
} as PermissionRequest;
|
||||
|
||||
describe('permission needed toast', () => {
|
||||
test('shows for an inactive session and opens that session', () => {
|
||||
const shown: Array<{ title: string; options: Parameters<Parameters<typeof showPermissionNeededToast>[0]['show']>[1] }> = [];
|
||||
const opened: Array<[string, string]> = [];
|
||||
const show: Parameters<typeof showPermissionNeededToast>[0]['show'] = (title, options) => { shown.push({ title, options }); };
|
||||
const openSession = (sessionId: string, directory: string) => { opened.push([sessionId, directory]); };
|
||||
const pendingIds = new Set<string>();
|
||||
|
||||
expect(showPermissionNeededToast({
|
||||
permission,
|
||||
directory: '/project',
|
||||
isViewed: false,
|
||||
pendingIds,
|
||||
show,
|
||||
openSession,
|
||||
})).toBe(true);
|
||||
|
||||
expect(shown.length).toBe(1);
|
||||
const { options } = shown[0];
|
||||
expect(options.id).toBe('permission-inactive-session:permission-1');
|
||||
expect(options.description).toBe('bash');
|
||||
options.action.onClick();
|
||||
expect(opened).toEqual([['inactive-session', '/project']]);
|
||||
});
|
||||
|
||||
test('does not show for the viewed session or duplicate a pending toast', () => {
|
||||
const shown: string[] = [];
|
||||
const show: Parameters<typeof showPermissionNeededToast>[0]['show'] = (title) => { shown.push(title); };
|
||||
const openSession: Parameters<typeof showPermissionNeededToast>[0]['openSession'] = () => {};
|
||||
const pendingIds = new Set<string>();
|
||||
const base = { permission, directory: '/project', pendingIds, show, openSession };
|
||||
|
||||
expect(showPermissionNeededToast({ ...base, isViewed: true })).toBe(false);
|
||||
expect(showPermissionNeededToast({ ...base, isViewed: false })).toBe(true);
|
||||
expect(showPermissionNeededToast({ ...base, isViewed: false })).toBe(false);
|
||||
expect(shown.length).toBe(1);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user