From de0455e10e524fd9a1e74f6c47b4752a62c1da50 Mon Sep 17 00:00:00 2001 From: Serhii Dziupin Date: Sat, 15 Aug 2026 03:42:45 +0000 Subject: [PATCH] test(ui): drop tautological #2903 enabled-gate helper The helper reimplemented `if (!enabled) return []` locally, so those cases never exercised the real hook. Keep the snapshot-builder and source-contract coverage instead. Co-authored-by: Serhii Dziupin --- ...ue-2903-subagent-status-line-only.test.tsx | 35 ------------------- 1 file changed, 35 deletions(-) diff --git a/packages/ui/src/components/chat/__tests__/issue-2903-subagent-status-line-only.test.tsx b/packages/ui/src/components/chat/__tests__/issue-2903-subagent-status-line-only.test.tsx index a2b44f9c..d8658eda 100644 --- a/packages/ui/src/components/chat/__tests__/issue-2903-subagent-status-line-only.test.tsx +++ b/packages/ui/src/components/chat/__tests__/issue-2903-subagent-status-line-only.test.tsx @@ -64,21 +64,6 @@ const buildFourteenMessageSnapshot = () => { return materializeSessionSnapshots({ message: {}, part: {} }, SESSION_ID, records); }; -/** - * Cold-start `useSessionMessageRecords` when `enabled === false` and no prior - * snapshot exists for the session: getSnapshot returns EMPTY records even - * though the store already holds a renderable transcript. - */ -const readRecordsThroughEnabledGate = ( - storeMessages: ReturnType['list'], - enabled: boolean, -) => { - if (enabled === false) { - return []; - } - return storeMessages; -}; - describe('issue #2903 busy embedded subagent status-line-only', () => { test('materialized 14-message subagent is renderable and snapshottable', () => { const materialized = buildFourteenMessageSnapshot(); @@ -99,26 +84,6 @@ describe('issue #2903 busy embedded subagent status-line-only', () => { ); }); - test('inactive enabled:false hides a fully-renderable session (0 records)', () => { - const materialized = buildFourteenMessageSnapshot(); - const records = buildSessionMessageRecordsSnapshot( - { ...INITIAL_STATE, message: materialized.message, part: materialized.part }, - SESSION_ID, - ); - expect(getSessionMaterializationStatus(materialized, SESSION_ID).renderable).toBe(true); - expect(records.list).toHaveLength(14); - expect(readRecordsThroughEnabledGate(records.list, false)).toHaveLength(0); - }); - - test('enabled:true reveals all 14 materialized records', () => { - const materialized = buildFourteenMessageSnapshot(); - const records = buildSessionMessageRecordsSnapshot( - { ...INITIAL_STATE, message: materialized.message, part: materialized.part }, - SESSION_ID, - ); - expect(readRecordsThroughEnabledGate(records.list, true)).toHaveLength(14); - }); - test('sync gate still returns empty on cold disabled reads', () => { const hookStart = syncContextSource.indexOf('export function useSessionMessageRecords('); const hookBody = syncContextSource.slice(hookStart, hookStart + 1800);