BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ui): bound settings mutation history

Browse Source 
Skip mutation history when no settings operation is in flight and merge updates that share the same operation visibility window. This keeps stale-response reconciliation unchanged while preventing history from growing with repeated debounced updates.

Add a repeated-update regression covering an older pending load and latest-value reconciliation.

Tests: bun test src/lib/persistence.test.ts
This commit is contained in:
c_w_xiaohei
2026-08-26 00:42:37 +08:00
parent 4454bf7e14
commit df924aa532
2 changed files with 50 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/lib/persistence.ts
+13 -1
View File
@@ -1679,7 +1679,19 @@ class SettingsMutationTracker {
record(changes: Partial<DesktopSettings>): number {
this.revision += 1;
this.mutations.push({ revision: this.revision, changes });
if (this.operations.size > 0) {
const latest = this.mutations.at(-1);
// A new segment is only needed when an operation started after the last one.
const crossedOperationBoundary = latest
? [...this.operations].some((operation) => operation.revision >= latest.revision)
: true;
if (latest && !crossedOperationBoundary) {
latest.revision = this.revision;
latest.changes = { ...latest.changes, ...changes };
} else {
this.mutations.push({ revision: this.revision, changes });
}
}
return this.revision;
}