fix(ui): guard the remaining comment inputs against IME composition

The IME fix covered the diff/file comment input and the browser annotation overlay, but two other places where a user writes a comment still acted on the Enter that confirms an IME candidate: the chat quote comment in the text selection menu, and the in-place comment editor on a composer context chip. Confirming a candidate there attached or committed the half-typed reading and closed the input. Escape, which abandons a candidate, had the same problem. Both handlers now return early on a composing keystroke, and a single test asserts the guard across every comment input so the next one added does not quietly skip it.
2026-09-05 14:48:17 +03:00
parent 904334de88
commit e24d2b2cbd
3 changed files with 73 additions and 0 deletions
@@ -0,0 +1,64 @@
+import { describe, expect, test } from 'bun:test';
+import { readFileSync } from 'node:fs';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+/**
+ * Every place a user writes a comment submits on a bare Enter, and Enter is
+ * also how an IME confirms a candidate. Without a composition guard the first
+ * confirmation posts the half-typed reading and closes the input, so the guard
+ * is a contract across all of these surfaces rather than a per-component
+ * detail. `keyCode === 229` is part of it: WebKit reports the confirming Enter
+ * that way after `compositionend`.
+ */
+const srcDir = join(dirname(fileURLToPath(import.meta.url)), '..');
+
+const COMMENT_INPUTS: Array<{ name: string; file: string; handler: string; guard: RegExp }> = [
+  {
+    name: 'diff and file comments',
+    file: 'components/comments/InlineCommentInput.tsx',
+    handler: 'const handleKeyDown',
+    guard: /isIMECompositionEvent\(e\)\) return;/,
+  },
+  {
+    name: 'chat quote comments',
+    file: 'components/chat/message/TextSelectionMenu.tsx',
+    handler: 'ref={commentInputRef}',
+    guard: /isIMECompositionEvent\(event\)\) return;/,
+  },
+  {
+    name: 'composer context chip editor',
+    file: 'components/chat/composer/ui/ComposerContextChips.tsx',
+    handler: 'ref={editRef}',
+    guard: /isIMECompositionEvent\(event\)\) return;/,
+  },
+  {
+    name: 'browser annotation input',
+    file: 'lib/browser/annotationOverlay.ts',
+    handler: 'var onCommentKeyDown = function (event) {',
+    guard: /event\.isComposing \|\| event\.keyCode === 229\) return;/,
+  },
+  {
+    name: 'browser annotation escape',
+    file: 'lib/browser/annotationOverlay.ts',
+    handler: 'var onKeyDown = function (event) {',
+    guard: /event\.isComposing \|\| event\.keyCode === 229\) return;/,
+  },
+];
+
+describe('comment inputs ignore IME composition keystrokes', () => {
+  for (const input of COMMENT_INPUTS) {
+    test(input.name, () => {
+      const source = readFileSync(join(srcDir, input.file), 'utf-8');
+      const start = source.indexOf(input.handler);
+      expect(start).toBeGreaterThan(-1);
+
+      const handler = source.slice(start, start + 900);
+      const guardIndex = handler.search(input.guard);
+      const keyIndex = handler.search(/(event|e)\.key === '(Enter|Escape)'/);
+
+      expect(guardIndex).toBeGreaterThan(-1);
+      expect(keyIndex).toBeGreaterThan(guardIndex);
+    });
+  }
+});