BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: force auto scroll behavior in virtualized message list navigation

Browse Source 
Removed smooth scroll option to prevent offset issues on unmount
Ensured consistent auto-reconciliation for variable-height rows during scroll
This commit is contained in:
Bohdan Triapitsyn
2026-07-24 20:59:10 +03:00
parent 18b58bdb6b
commit ea157c9aa8
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/components/chat/MessageList.tsx
+9 -5
View File
@@ -1587,7 +1587,7 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
return container.querySelector(`[data-message-id="${messageId}"]`); return container.querySelector(`[data-message-id="${messageId}"]`);
}, [resolveScrollContainer]); }, [resolveScrollContainer]);
const scrollHistoryIndexIntoView = React.useCallback((index: number, behavior: ScrollBehavior = 'auto') => { const scrollHistoryIndexIntoView = React.useCallback((index: number) => {
if (index < 0 || index >= historyEntries.length) { if (index < 0 || index >= historyEntries.length) {
return false; return false;
} }
@@ -1601,7 +1601,11 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
return false; return false;
} }
virtualizer.scrollToIndex(index, { align: 'start', behavior: behavior === 'smooth' ? 'smooth' : 'auto' }); // Smooth scrolling can stop at a stale offset while unmounted,
// variable-height rows replace estimates with real measurements. Use
// exact auto-reconciliation; mounted targets still take the smooth DOM
// path below.
virtualizer.scrollToIndex(index, { align: 'start', behavior: 'auto' });
return true; return true;
}, [historyEntries.length, shouldVirtualizeHistory]); }, [historyEntries.length, shouldVirtualizeHistory]);
@@ -1651,7 +1655,7 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
return false; return false;
} }
return scrollHistoryIndexIntoView(index, behavior); return scrollHistoryIndexIntoView(index);
}, },
scrollToMessageId: (messageId: string, options?: { behavior?: ScrollBehavior }) => { scrollToMessageId: (messageId: string, options?: { behavior?: ScrollBehavior }) => {
@@ -1665,7 +1669,7 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
|| ( || (
trailingStreamingEntry !== undefined && index >= historyEntries.length trailingStreamingEntry !== undefined && index >= historyEntries.length
? false ? false
: scrollHistoryIndexIntoView(index, behavior) : scrollHistoryIndexIntoView(index)
); );
}, },
@@ -1774,7 +1778,7 @@ const MessageList = React.forwardRef<MessageListHandle, MessageListProps>(({
if (!applyAnchor()) { if (!applyAnchor()) {
const index = messageIndexMap.get(anchor.messageId); const index = messageIndexMap.get(anchor.messageId);
if (typeof index === 'number' && index < historyEntries.length) { if (typeof index === 'number' && index < historyEntries.length) {
return scrollHistoryIndexIntoView(index, 'auto'); return scrollHistoryIndexIntoView(index);
} }
} }