perf(chat): make session switching feel instant
Switching sessions ran as one synchronous commit: sidebar highlight, URL, a full timeline remount with markdown re-parse, and around nine requests, so nothing changed on screen for 150-250ms after the click. - ChatContainer swaps the timeline on a deferred copy of the selection, so the active row, URL, and tab commit first and the timeline renders behind them; selection policy keeps reading the live store value. - The message fetch starts before the selection is published. - Sidebar rows stop re-rendering on a project switch: directory-scoped sync hooks read the runtime context and a subscribable current-directory source instead of the directory-bearing context; the grouping builder reads git branches through a ref and section caches key the branches they use; descendant ids are keyed by content. Rows per switch went from 73 to 8. - Markdown skips the async re-render when the settled cached blocks are already painted, and mounts synchronously once its lazy module is loaded; the module is preloaded at boot. - A timeline reveal gate holds a freshly opened session at opacity 0 while any provisional markdown paint catches up (250ms cap), then fades the whole timeline in once, so text, tools, and recap appear together. - Switch fan-out trimmed: knowledge summary deduped, MCP status refreshed only when stale, non-repo directories cached by the git repo check, OpenChamber defaults cached briefly, agent memory reused for the same project, goal text cached, PWA manifest rebuilt after the switch settles. - Header tabs snap into the active state and keep the title at the same height in both states. - Prefetch on row press; composer focus moved off the commit. `bun run profile:switch` records ack/content latency, longest task, and requests per switch, cold and warm, and compares runs against a baseline. Measured warm switch: ack 228ms to about 40-60ms, content 228ms to about 100-120ms.
This commit is contained in:
@@ -11,6 +11,7 @@ import { Skeleton } from '@/components/ui/skeleton';
|
||||
import ChatEmptyState from './ChatEmptyState';
|
||||
import { useGlobalSyncStore } from '@/sync/global-sync-store';
|
||||
import MessageList, { type MessageListHandle } from './MessageList';
|
||||
import { createTimelineRevealGate, TIMELINE_REVEAL_CAP_MS, TimelineRevealGateContext } from './timelineRevealGate';
|
||||
import { PermissionCard } from './PermissionCard';
|
||||
import { QuestionCard } from './QuestionCard';
|
||||
import { hasActiveQuestionToolInCurrentTurn, recoverPendingQuestionWithRetry } from '@/sync/question-recovery';
|
||||
@@ -175,9 +176,6 @@ type ChatViewportProps = {
|
||||
} | null;
|
||||
scrollToBottom: () => void;
|
||||
endPinningReleased: boolean;
|
||||
// One-shot fade for content that replaced the hydration skeleton;
|
||||
// cached sessions render instantly without it.
|
||||
revealContent: boolean;
|
||||
sessionQuestions: QuestionRequest[];
|
||||
sessionPermissions: PermissionRequest[];
|
||||
isProgrammaticFollowActive: boolean;
|
||||
@@ -214,7 +212,6 @@ const ChatViewport = React.memo(({
|
||||
retryOverlay,
|
||||
scrollToBottom,
|
||||
endPinningReleased,
|
||||
revealContent,
|
||||
sessionQuestions,
|
||||
sessionPermissions,
|
||||
isProgrammaticFollowActive,
|
||||
@@ -368,6 +365,45 @@ const ChatViewport = React.memo(({
|
||||
</>
|
||||
), [currentSessionId, directory, isMobile, sessionPermissions, sessionQuestions]);
|
||||
|
||||
// Opening a session paints the timeline as one finished picture: the root
|
||||
// stays invisible while any renderer holds a provisional first paint, then
|
||||
// everything appears together. A warm switch, where nothing is held,
|
||||
// reveals in the same frame; a cold open fades in once as a whole.
|
||||
const timelineRootRef = React.useRef<HTMLDivElement | null>(null);
|
||||
const revealGate = React.useMemo(() => createTimelineRevealGate(), [currentSessionKey]);
|
||||
React.useLayoutEffect(() => {
|
||||
const root = timelineRootRef.current;
|
||||
if (!root) return;
|
||||
root.setAttribute('data-timeline-reveal', 'pending');
|
||||
let finished = false;
|
||||
let timer: number | null = null;
|
||||
const reveal = (fade: boolean) => {
|
||||
if (finished) return;
|
||||
finished = true;
|
||||
if (timer !== null) window.clearTimeout(timer);
|
||||
if (fade) root.setAttribute('data-timeline-reveal', 'fading');
|
||||
else root.removeAttribute('data-timeline-reveal');
|
||||
};
|
||||
// Holds are taken in layout effects, including those of rows the list
|
||||
// mounts in a nested synchronous pass; a microtask runs after all of
|
||||
// them and still before the browser paints this commit.
|
||||
queueMicrotask(() => {
|
||||
if (finished) return;
|
||||
revealGate.close();
|
||||
if (revealGate.holds === 0) {
|
||||
reveal(false);
|
||||
return;
|
||||
}
|
||||
revealGate.onEmpty = () => reveal(true);
|
||||
timer = window.setTimeout(() => reveal(true), TIMELINE_REVEAL_CAP_MS);
|
||||
});
|
||||
return () => {
|
||||
finished = true;
|
||||
if (timer !== null) window.clearTimeout(timer);
|
||||
revealGate.onEmpty = null;
|
||||
};
|
||||
}, [revealGate]);
|
||||
|
||||
const scrollContainerProps = React.useMemo(() => ({
|
||||
className: 'absolute inset-0 overflow-y-auto overflow-x-hidden z-0 chat-scroll overlay-scrollbar-target',
|
||||
style: CHAT_SCROLL_STYLE,
|
||||
@@ -385,11 +421,12 @@ const ChatViewport = React.memo(({
|
||||
isDesktopExpandedInput
|
||||
? 'absolute inset-0 opacity-0 pointer-events-none'
|
||||
: 'flex-1',
|
||||
revealContent && !isDesktopExpandedInput && 'oc-chat-hydration-reveal',
|
||||
)}
|
||||
ref={timelineRootRef}
|
||||
aria-hidden={isDesktopExpandedInput}
|
||||
>
|
||||
<div className="absolute inset-0">
|
||||
<TimelineRevealGateContext.Provider value={revealGate}>
|
||||
<MessageList
|
||||
key={currentSessionKey}
|
||||
ref={messageListRef}
|
||||
@@ -417,6 +454,7 @@ const ChatViewport = React.memo(({
|
||||
listFooter={listFooter}
|
||||
scrollContainerProps={scrollContainerProps}
|
||||
/>
|
||||
</TimelineRevealGateContext.Provider>
|
||||
<OverlayScrollbar containerRef={scrollRef} disableHorizontal suppressVisibility={isProgrammaticFollowActive} userIntentOnly observeMutations={false} />
|
||||
{showPromptNavigator && promptTurnIds.length >= 2 ? (
|
||||
<PromptNavigatorRail
|
||||
@@ -448,7 +486,6 @@ const ChatViewport = React.memo(({
|
||||
&& prev.retryOverlay === next.retryOverlay
|
||||
&& prev.scrollToBottom === next.scrollToBottom
|
||||
&& prev.endPinningReleased === next.endPinningReleased
|
||||
&& prev.revealContent === next.revealContent
|
||||
&& prev.sessionQuestions === next.sessionQuestions
|
||||
&& prev.sessionPermissions === next.sessionPermissions
|
||||
&& prev.isProgrammaticFollowActive === next.isProgrammaticFollowActive
|
||||
@@ -824,9 +861,6 @@ export const ChatContainer: React.FC<ChatContainerProps> = ({
|
||||
return () => setWorkStatusPanelVisible(false);
|
||||
}, [setWorkStatusPanelVisible, showWorkStatusPanel]);
|
||||
const messageListRef = React.useRef<MessageListHandle | null>(null);
|
||||
// Session keys that showed the hydration skeleton this app run; their
|
||||
// content gets a one-shot reveal fade once it replaces the skeleton.
|
||||
const hydrationRevealKeyRef = React.useRef<string | null>(null);
|
||||
|
||||
const currentSession = useSession(currentSessionId, effectiveSessionDirectory);
|
||||
const parentSession = useParentSession(currentSessionId, effectiveSessionDirectory);
|
||||
@@ -1163,15 +1197,6 @@ export const ChatContainer: React.FC<ChatContainerProps> = ({
|
||||
const isSessionHydrating =
|
||||
Boolean(currentSessionId)
|
||||
&& !hasRenderableSessionSnapshot;
|
||||
React.useEffect(() => {
|
||||
if (isSessionHydrating || hydrationRevealKeyRef.current === null) return;
|
||||
// One-shot: forget the key after the reveal animation has played so a
|
||||
// later (now cached) visit to the same session opens instantly.
|
||||
const timer = setTimeout(() => {
|
||||
hydrationRevealKeyRef.current = null;
|
||||
}, 400);
|
||||
return () => clearTimeout(timer);
|
||||
}, [isSessionHydrating, currentSessionKey]);
|
||||
const retrySessionLoad = React.useCallback(() => {
|
||||
if (!messagesEnabled || !currentSessionId) return;
|
||||
void sync.ensureSessionRenderable(currentSessionId, true, effectiveSessionDirectory);
|
||||
@@ -1310,9 +1335,6 @@ export const ChatContainer: React.FC<ChatContainerProps> = ({
|
||||
}
|
||||
|
||||
const showHydrationSkeleton = isSessionHydrating && sessionMessages.length === 0 && !sessionIsWorking;
|
||||
if (showHydrationSkeleton) {
|
||||
hydrationRevealKeyRef.current = currentSessionKey ?? currentSessionId ?? null;
|
||||
}
|
||||
if (showHydrationSkeleton) {
|
||||
if (sessionMessageLoadState.status === 'error') {
|
||||
return (
|
||||
@@ -1415,7 +1437,6 @@ export const ChatContainer: React.FC<ChatContainerProps> = ({
|
||||
retryOverlay={retryOverlay}
|
||||
scrollToBottom={resumeToLatestInstant}
|
||||
endPinningReleased={userOwnsScroll}
|
||||
revealContent={hydrationRevealKeyRef.current !== null && hydrationRevealKeyRef.current === (currentSessionKey ?? currentSessionId ?? null)}
|
||||
sessionQuestions={sessionQuestions}
|
||||
sessionPermissions={sessionPermissions}
|
||||
isProgrammaticFollowActive={isFollowingProgrammatically}
|
||||
|
||||
@@ -72,8 +72,8 @@ import { useChatSearchDirectory } from '@/hooks/useChatSearchDirectory';
|
||||
import { opencodeClient } from '@/lib/opencode/client';
|
||||
import { useGitStore, useIsGitRepo } from '@/stores/useGitStore';
|
||||
import { useDirectoryStore } from '@/stores/useDirectoryStore';
|
||||
import { useSkillsStore } from '@/stores/useSkillsStore';
|
||||
import { useCommandsStore } from '@/stores/useCommandsStore';
|
||||
import { selectSkillsForDirectory, useSkillsStore } from '@/stores/useSkillsStore';
|
||||
import { selectCommandsForDirectory, useCommandsStore } from '@/stores/useCommandsStore';
|
||||
import { useRuntimeAPIs } from '@/hooks/useRuntimeAPIs';
|
||||
import { useEffectiveDirectory } from '@/hooks/useEffectiveDirectory';
|
||||
import { usePermissionStore } from '@/stores/permissionStore';
|
||||
@@ -602,8 +602,8 @@ const ChatInputComponent: React.FC<ChatInputProps> = ({
|
||||
|
||||
// Known slash-invocations (commands + skills + built-ins) used to highlight
|
||||
// matching /tokens in the composer, the same way confirmed @files are.
|
||||
const availableCommands = useCommandsStore((s) => s.commands);
|
||||
const availableSkills = useSkillsStore((s) => s.skills);
|
||||
const availableCommands = useCommandsStore((s) => selectCommandsForDirectory(s, currentDirectory));
|
||||
const availableSkills = useSkillsStore((s) => selectSkillsForDirectory(s, currentDirectory));
|
||||
const knownSlashNames = React.useMemo(() => {
|
||||
const names = new Set<string>([
|
||||
'init', 'review', 'undo', 'redo', 'timeline', 'compact', 'btw', 'summary', 'workspace-review', 'plan-feature', 'craft-goal', 'schedule-task', 'catch-up', 'debug', 'weigh', 'explore',
|
||||
@@ -1140,7 +1140,7 @@ const ChatInputComponent: React.FC<ChatInputProps> = ({
|
||||
: [];
|
||||
|
||||
const availableSkillNames = new Set(
|
||||
useSkillsStore.getState().skills.map((skill) => skill.name),
|
||||
selectSkillsForDirectory(useSkillsStore.getState(), currentDirectory).map((skill) => skill.name),
|
||||
);
|
||||
|
||||
const outgoing = buildOutgoingMessage({
|
||||
@@ -2262,10 +2262,14 @@ const ChatInputComponent: React.FC<ChatInputProps> = ({
|
||||
};
|
||||
|
||||
React.useEffect(() => {
|
||||
|
||||
if (active && currentSessionId && composerRef.current && !isMobile) {
|
||||
composerRef.current.focus();
|
||||
}
|
||||
if (!active || !currentSessionId || isMobile) return;
|
||||
// Focusing forces layout. Right after a session switch the layout is
|
||||
// dirty from the whole timeline mounting, so the focus call would pay
|
||||
// for that layout inside the commit; a frame later it is nearly free.
|
||||
const frame = window.requestAnimationFrame(() => {
|
||||
composerRef.current?.focus();
|
||||
});
|
||||
return () => window.cancelAnimationFrame(frame);
|
||||
}, [active, currentSessionId, isMobile]);
|
||||
|
||||
React.useEffect(() => {
|
||||
|
||||
@@ -2,7 +2,7 @@ import React from 'react';
|
||||
import { lazyWithChunkRecovery } from '@/lib/chunkLoadRecovery';
|
||||
import { isMobileSurfaceRuntime } from '@/lib/runtimeSurface';
|
||||
import { cn } from '@/lib/utils';
|
||||
import { loadMarkdownRendererModule } from './markdownRendererLoader';
|
||||
import { getLoadedMarkdownRendererModule, loadMarkdownRendererModule } from './markdownRendererLoader';
|
||||
|
||||
// Thin lazy wrapper around the MarkdownRenderer implementation.
|
||||
// The full implementation (marked + Shiki highlighting + KaTeX + morphdom
|
||||
@@ -41,21 +41,29 @@ const MobileMarkdownFallback = (props: { content?: unknown; className?: unknown;
|
||||
);
|
||||
};
|
||||
|
||||
export const MarkdownRenderer: React.FC<React.ComponentPropsWithoutRef<typeof MarkdownRendererLazy>> = (props) => (
|
||||
<React.Suspense fallback={<MobileMarkdownFallback {...props} />}>
|
||||
<MarkdownRendererLazy {...props} />
|
||||
</React.Suspense>
|
||||
);
|
||||
export const MarkdownRenderer: React.FC<React.ComponentPropsWithoutRef<typeof MarkdownRendererLazy>> = (props) => {
|
||||
const loaded = getLoadedMarkdownRendererModule();
|
||||
if (loaded) return <loaded.MarkdownRenderer {...props} />;
|
||||
return (
|
||||
<React.Suspense fallback={<MobileMarkdownFallback {...props} />}>
|
||||
<MarkdownRendererLazy {...props} />
|
||||
</React.Suspense>
|
||||
);
|
||||
};
|
||||
|
||||
type SimpleMarkdownRendererProps = React.ComponentPropsWithoutRef<typeof SimpleMarkdownRendererLazy> & {
|
||||
fallbackContent?: React.ReactNode;
|
||||
};
|
||||
|
||||
export const SimpleMarkdownRenderer: React.FC<SimpleMarkdownRendererProps> = ({ fallbackContent, ...props }) => (
|
||||
<React.Suspense fallback={fallbackContent ?? <MobileMarkdownFallback {...props} />}>
|
||||
<SimpleMarkdownRendererLazy {...props} />
|
||||
</React.Suspense>
|
||||
);
|
||||
export const SimpleMarkdownRenderer: React.FC<SimpleMarkdownRendererProps> = ({ fallbackContent, ...props }) => {
|
||||
const loaded = getLoadedMarkdownRendererModule();
|
||||
if (loaded) return <loaded.SimpleMarkdownRenderer {...props} />;
|
||||
return (
|
||||
<React.Suspense fallback={fallbackContent ?? <MobileMarkdownFallback {...props} />}>
|
||||
<SimpleMarkdownRendererLazy {...props} />
|
||||
</React.Suspense>
|
||||
);
|
||||
};
|
||||
|
||||
export const MarkdownImageGallery: React.FC<React.ComponentPropsWithoutRef<typeof MarkdownImageGalleryLazy>> = (props) => (
|
||||
<React.Suspense fallback={null}>
|
||||
|
||||
@@ -193,6 +193,8 @@ const fakeReact = {
|
||||
return hookStates[index] as { current: T };
|
||||
},
|
||||
memo: <T>(component: T): T => component,
|
||||
createContext: <T>(defaultValue: T) => ({ Provider: 'provider', defaultValue }),
|
||||
useContext: <T>(context: { defaultValue: T }): T => context.defaultValue,
|
||||
};
|
||||
|
||||
const fakeJsx = (_type: string, props: FakeJsxProps | null, ...children: FakeElement[]): FakeElement => {
|
||||
|
||||
@@ -51,6 +51,7 @@ import {
|
||||
import { fileReferenceExists } from './fileReferenceStat';
|
||||
import { streamPerfCount, streamPerfObserve } from '@/stores/utils/streamDebug';
|
||||
import { detachedMarkdownDomCache, type DetachedMarkdownDomKey } from './markdown/detachedMarkdownDomCache';
|
||||
import { TimelineRevealGateContext } from './timelineRevealGate';
|
||||
import { getRuntimeKey } from '@/lib/runtime-switch';
|
||||
|
||||
const useCurrentMermaidTheme = () => {
|
||||
@@ -692,6 +693,30 @@ const useMermaidInlineInteractions = ({
|
||||
const MERMAID_RENDER_CACHE = new Map<string, MermaidRender>();
|
||||
const MERMAID_RENDER_CACHE_MAX = 100;
|
||||
const MARKDOWN_DECORATION_ID_ATTR = 'data-md-decoration-id';
|
||||
|
||||
// True when the container already holds exactly these settled blocks with the
|
||||
// current decoration. The first paint of a remounted message is served from
|
||||
// the block cache; when that paint is already final, the async render would
|
||||
// only parse, highlight, sanitize, and morph the same HTML into place again.
|
||||
const domMatchesRenderedBlocks = (
|
||||
target: HTMLElement,
|
||||
blocks: ReadonlyArray<{ id: string }>,
|
||||
decorationId: string,
|
||||
): boolean => {
|
||||
const children = target.children;
|
||||
if (children.length !== blocks.length) return false;
|
||||
for (let index = 0; index < blocks.length; index += 1) {
|
||||
const child = children[index];
|
||||
if (
|
||||
!child
|
||||
|| child.getAttribute('data-md-id') !== blocks[index]?.id
|
||||
|| child.getAttribute(MARKDOWN_DECORATION_ID_ATTR) !== decorationId
|
||||
) {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
return true;
|
||||
};
|
||||
const MARKDOWN_DECORATION_IDS = new WeakMap<DecorateContext, string>();
|
||||
let nextMarkdownDecorationId = 0;
|
||||
const MARKDOWN_DOM_CACHE_MAX_SOURCE_CHARS = 200_000;
|
||||
@@ -804,6 +829,16 @@ const useMorphdomMarkdown = ({
|
||||
|
||||
const mermaidViewerRef = React.useRef<ReturnType<typeof createMermaidViewerRegistry> | null>(null);
|
||||
const renderRevisionRef = React.useRef(0);
|
||||
// A provisional first paint (blocks not in the settled cache) holds the
|
||||
// timeline reveal until the async render lands, so the session opens with
|
||||
// final code highlighting instead of a visible restyle.
|
||||
const revealGate = React.useContext(TimelineRevealGateContext);
|
||||
const releaseRevealHoldRef = React.useRef<(() => void) | null>(null);
|
||||
const releaseRevealHold = React.useCallback(() => {
|
||||
releaseRevealHoldRef.current?.();
|
||||
releaseRevealHoldRef.current = null;
|
||||
}, []);
|
||||
React.useEffect(() => releaseRevealHold, [releaseRevealHold]);
|
||||
// Only DOM that was actually restored or completed by the async pipeline is
|
||||
// eligible for capture. A fallback from an earlier content revision is not.
|
||||
const mountedDomRef = React.useRef<{
|
||||
@@ -909,6 +944,9 @@ const useMorphdomMarkdown = ({
|
||||
}
|
||||
if (hasMermaidBlock) refreshMermaidViewers();
|
||||
} else {
|
||||
if (!streaming && !releaseRevealHoldRef.current) {
|
||||
releaseRevealHoldRef.current = revealGate?.hold() ?? null;
|
||||
}
|
||||
const block = document.createElement('div');
|
||||
block.setAttribute('data-md-block', '');
|
||||
block.style.display = 'contents';
|
||||
@@ -939,6 +977,18 @@ const useMorphdomMarkdown = ({
|
||||
const renderRevision = renderRevisionRef.current;
|
||||
const decorationId = getMarkdownDecorationId(ctx);
|
||||
|
||||
if (!streaming) {
|
||||
const cachedBlocks = getCachedMarkdownBlocks(text, imageMode);
|
||||
if (cachedBlocks && domMatchesRenderedBlocks(target, cachedBlocks, decorationId)) {
|
||||
mountedDomRef.current = domCacheKey
|
||||
? { key: domCacheKey, copiedLabel: ctx.labels.copied }
|
||||
: null;
|
||||
streamPerfCount('ui.markdown_renderer.settled_paint.reused');
|
||||
releaseRevealHold();
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
void renderMarkdownBlocks(text, streaming, imageMode).then((blocks) => {
|
||||
if (!active || renderRevisionRef.current !== renderRevision) return;
|
||||
const existing = Array.from(target.children) as HTMLElement[];
|
||||
@@ -1028,12 +1078,13 @@ const useMorphdomMarkdown = ({
|
||||
mountedDomRef.current = domCacheKey
|
||||
? { key: domCacheKey, copiedLabel: ctx.labels.copied }
|
||||
: null;
|
||||
releaseRevealHold();
|
||||
});
|
||||
|
||||
return () => {
|
||||
active = false;
|
||||
};
|
||||
}, [containerRef, ctx, domCacheKey, imageMode, refreshMermaidViewers, streaming, text]);
|
||||
}, [containerRef, ctx, domCacheKey, imageMode, refreshMermaidViewers, releaseRevealHold, streaming, text]);
|
||||
|
||||
React.useEffect(() => {
|
||||
const container = containerRef.current;
|
||||
|
||||
@@ -1,13 +1,31 @@
|
||||
let markdownRendererModulePromise: Promise<typeof import('./MarkdownRendererImpl')> | null = null;
|
||||
type MarkdownRendererModule = typeof import('./MarkdownRendererImpl');
|
||||
|
||||
let markdownRendererModulePromise: Promise<MarkdownRendererModule> | null = null;
|
||||
let markdownRendererModule: MarkdownRendererModule | null = null;
|
||||
|
||||
export const loadMarkdownRendererModule = () => {
|
||||
markdownRendererModulePromise ??= import('./MarkdownRendererImpl').catch((error) => {
|
||||
markdownRendererModulePromise = null;
|
||||
throw error;
|
||||
});
|
||||
markdownRendererModulePromise ??= import('./MarkdownRendererImpl')
|
||||
.then((module) => {
|
||||
markdownRendererModule = module;
|
||||
return module;
|
||||
})
|
||||
.catch((error) => {
|
||||
markdownRendererModulePromise = null;
|
||||
throw error;
|
||||
});
|
||||
return markdownRendererModulePromise;
|
||||
};
|
||||
|
||||
/**
|
||||
* The module once it has loaded, so a renderer can mount synchronously instead
|
||||
* of suspending. A lazy component that suspends — even on an already-resolved
|
||||
* promise — shows its fallback for a tick, and React then throttles the reveal
|
||||
* of every boundary that resolves in the following ~300ms, which is how a
|
||||
* freshly opened session showed user text first and assistant text a third of
|
||||
* a second later.
|
||||
*/
|
||||
export const getLoadedMarkdownRendererModule = () => markdownRendererModule;
|
||||
|
||||
export const preloadMarkdownRenderer = () => {
|
||||
void loadMarkdownRendererModule().catch(() => undefined);
|
||||
};
|
||||
|
||||
@@ -0,0 +1,54 @@
|
||||
import React from 'react';
|
||||
|
||||
/**
|
||||
* Coordinates the first paint of a freshly opened session so the timeline
|
||||
* appears as one finished picture instead of arriving in pieces.
|
||||
*
|
||||
* Renderers that mount with a provisional paint (markdown whose blocks are not
|
||||
* in the settled cache yet, so code is unhighlighted) take a hold while they
|
||||
* catch up. The timeline stays invisible while any hold is open, then reveals
|
||||
* everything at once. The gate accepts holds only during the opening commit:
|
||||
* rows that mount later, while scrolling, must never hide the timeline.
|
||||
*
|
||||
* A hold that never releases must not hide the chat forever, so the owner
|
||||
* reveals after `TIMELINE_REVEAL_CAP_MS` regardless.
|
||||
*/
|
||||
type TimelineRevealGate = {
|
||||
/** Take a hold; returns the release. Returns null once the gate is closed. */
|
||||
hold: () => (() => void) | null;
|
||||
/** Stops accepting holds. Existing holds still count. */
|
||||
close: () => void;
|
||||
readonly holds: number;
|
||||
/** Called when the last hold releases, if the gate is closed by then. */
|
||||
onEmpty: (() => void) | null;
|
||||
};
|
||||
|
||||
export const TIMELINE_REVEAL_CAP_MS = 250;
|
||||
|
||||
export const createTimelineRevealGate = (): TimelineRevealGate => {
|
||||
let holds = 0;
|
||||
let accepting = true;
|
||||
const gate: TimelineRevealGate = {
|
||||
hold: () => {
|
||||
if (!accepting) return null;
|
||||
holds += 1;
|
||||
let released = false;
|
||||
return () => {
|
||||
if (released) return;
|
||||
released = true;
|
||||
holds -= 1;
|
||||
if (holds === 0 && !accepting) gate.onEmpty?.();
|
||||
};
|
||||
},
|
||||
close: () => {
|
||||
accepting = false;
|
||||
},
|
||||
get holds() {
|
||||
return holds;
|
||||
},
|
||||
onEmpty: null,
|
||||
};
|
||||
return gate;
|
||||
};
|
||||
|
||||
export const TimelineRevealGateContext = React.createContext<TimelineRevealGate | null>(null);
|
||||
@@ -13,6 +13,8 @@ type Props = {
|
||||
directory: string | null;
|
||||
};
|
||||
|
||||
const MCP_STATUS_MAX_AGE_MS = 60_000;
|
||||
|
||||
/**
|
||||
* MCP servers with their connection switches, reusing the dropdown's own
|
||||
* connect/disconnect actions.
|
||||
@@ -23,17 +25,19 @@ export const WorkStatusMcpSection: React.FC<Props> = ({ directory }) => {
|
||||
const mcpStatus = useMcpStore(
|
||||
React.useCallback((state) => state.getStatusForDirectory(directory), [directory]),
|
||||
);
|
||||
const refreshMcp = useMcpStore((state) => state.refresh);
|
||||
const ensureMcpFresh = useMcpStore((state) => state.ensureFresh);
|
||||
const connect = useMcpStore((state) => state.connect);
|
||||
const disconnect = useMcpStore((state) => state.disconnect);
|
||||
const [busyServer, setBusyServer] = React.useState<string | null>(null);
|
||||
|
||||
// The panel must not depend on the header dropdown having been mounted or
|
||||
// opened to know its MCP servers. Silent and background-gated, so it cannot
|
||||
// compete with chat bootstrap traffic for sockets.
|
||||
// compete with chat bootstrap traffic for sockets. The section remounts on
|
||||
// every session switch, so it only asks for a status that is missing or
|
||||
// older than a minute; connect/disconnect/auth refresh on their own.
|
||||
React.useEffect(() => {
|
||||
void runBackgroundNetworkTask(() => refreshMcp({ directory, silent: true }));
|
||||
}, [directory, refreshMcp]);
|
||||
void runBackgroundNetworkTask(() => ensureMcpFresh({ directory, silent: true, maxAgeMs: MCP_STATUS_MAX_AGE_MS }));
|
||||
}, [directory, ensureMcpFresh]);
|
||||
|
||||
const mcpServers = React.useMemo(
|
||||
() => Object.entries(mcpStatus ?? {}).sort(([left], [right]) => left.localeCompare(right)),
|
||||
|
||||
@@ -159,8 +159,11 @@ const SessionTabItem: React.FC<{
|
||||
}}
|
||||
data-controls-open={overlayVisible ? 'true' : 'false'}
|
||||
className={cn(
|
||||
// No color transition: activation must snap. A crossfade
|
||||
// here reads as the switch itself being slow, since the
|
||||
// old and new tab trade colors over several frames right
|
||||
// after the click.
|
||||
'session-tab group/session-tab relative flex h-7 w-full min-w-0 select-none items-center rounded-md px-2',
|
||||
'transition-colors duration-75',
|
||||
isActive
|
||||
? 'bg-interactive-selection'
|
||||
: cn(
|
||||
@@ -180,8 +183,15 @@ const SessionTabItem: React.FC<{
|
||||
!suppressControls && 'session-tab-title',
|
||||
)}
|
||||
>
|
||||
{/* Same box as the active content the header renders
|
||||
(a centered column with a block title), so the
|
||||
title sits at the same height before and after
|
||||
activation and does not jump when the tab swaps
|
||||
its content. */}
|
||||
{isActive ? children : (
|
||||
<span className="text-[13px] font-medium leading-4">{title}</span>
|
||||
<div className="flex min-w-0 flex-col justify-center">
|
||||
<span className="block max-w-full overflow-hidden whitespace-nowrap text-[13px] font-medium leading-4">{title}</span>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
{showDot ? (
|
||||
|
||||
@@ -232,6 +232,7 @@ const VisibleSessionProjects: React.FC<SessionProjectCollectionProps> = ({ topol
|
||||
availableWorktreesByProject: topology.availableWorktreesByProject,
|
||||
projectRepoStatus: topology.projectRepoStatus,
|
||||
projectRootBranches: topology.projectRootBranches,
|
||||
gitBranches: topology.gitBranches,
|
||||
lastRepoStatus: topology.lastRepoStatus,
|
||||
buildGroupedSessions,
|
||||
hasSessionSearchQuery: view.hasSessionSearchQuery,
|
||||
|
||||
@@ -28,6 +28,12 @@ const isArchivedSession = (session: Session): boolean => Boolean(session.time?.a
|
||||
|
||||
export const useSessionGrouping = (args: Args) => {
|
||||
const { t } = useI18n();
|
||||
// Read at call time rather than captured: the branch map is rebuilt whenever
|
||||
// any directory's git status changes, and a builder that changed identity
|
||||
// with it would invalidate every project section in the sidebar. The section
|
||||
// cache compares the branches each project actually uses instead.
|
||||
const gitBranchesRef = React.useRef(args.gitBranches);
|
||||
gitBranchesRef.current = args.gitBranches;
|
||||
const buildGroupSearchText = React.useCallback((group: SessionGroup): string => {
|
||||
return [group.label, group.branch ?? '', group.description ?? '', group.directory ?? ''].join(' ').toLowerCase();
|
||||
}, []);
|
||||
@@ -233,7 +239,7 @@ export const useSessionGrouping = (args: Args) => {
|
||||
const worktreeGroups = args.isVSCode ? [] : sortedWorktrees;
|
||||
worktreeGroups.forEach((meta) => {
|
||||
const directory = normalizePath(meta.path) ?? meta.path;
|
||||
const currentBranch = args.gitBranches.get(directory)?.trim() || null;
|
||||
const currentBranch = gitBranchesRef.current.get(directory)?.trim() || null;
|
||||
const metadataBranch = meta.branch?.trim() || null;
|
||||
const shouldSyncLabelWithBranch = Boolean(
|
||||
currentBranch && metadataBranch && meta.label && normalizeForBranchComparison(meta.label) === normalizeForBranchComparison(metadataBranch),
|
||||
@@ -274,7 +280,7 @@ export const useSessionGrouping = (args: Args) => {
|
||||
|
||||
return groups;
|
||||
},
|
||||
[args.homeDirectory, args.worktreeMetadata, args.sessionOrderRanks, args.gitBranches, args.isVSCode, t],
|
||||
[args.homeDirectory, args.worktreeMetadata, args.sessionOrderRanks, args.isVSCode, t],
|
||||
);
|
||||
|
||||
return {
|
||||
|
||||
@@ -55,6 +55,7 @@ const renderSections = (group: SessionGroup, query: string): Sections => {
|
||||
availableWorktreesByProject: new Map(),
|
||||
projectRepoStatus: new Map(),
|
||||
projectRootBranches: new Map(),
|
||||
gitBranches: new Map(),
|
||||
lastRepoStatus: false,
|
||||
buildGroupedSessions: grouping.buildGroupedSessions,
|
||||
hasSessionSearchQuery: query.length > 0,
|
||||
|
||||
@@ -29,11 +29,23 @@ type ProjectSectionCacheEntry = {
|
||||
archivedSessions: Session[];
|
||||
availableWorktrees: WorktreeMetadata[];
|
||||
rootBranch: string | null;
|
||||
/** Current branch of every worktree directory the section renders. */
|
||||
worktreeBranchesKey: string;
|
||||
isRepo: boolean;
|
||||
buildGroupedSessions: Args['buildGroupedSessions'];
|
||||
section: ProjectSection;
|
||||
};
|
||||
|
||||
const worktreeBranchesKeyFor = (
|
||||
worktrees: WorktreeMetadata[],
|
||||
gitBranches: ReadonlyMap<string, string | null>,
|
||||
): string => worktrees
|
||||
.map((worktree) => {
|
||||
const directory = normalizePath(worktree.path) ?? worktree.path;
|
||||
return `${directory}=${gitBranches.get(directory) ?? ''}`;
|
||||
})
|
||||
.join('\n');
|
||||
|
||||
const EMPTY_WORKTREES: WorktreeMetadata[] = [];
|
||||
|
||||
type Args = {
|
||||
@@ -43,6 +55,7 @@ type Args = {
|
||||
availableWorktreesByProject: Map<string, WorktreeMetadata[]>;
|
||||
projectRepoStatus: Map<string, boolean | null>;
|
||||
projectRootBranches: Map<string, string | null>;
|
||||
gitBranches: ReadonlyMap<string, string | null>;
|
||||
lastRepoStatus: boolean;
|
||||
buildGroupedSessions: (
|
||||
sessions: Session[],
|
||||
@@ -73,6 +86,7 @@ export const useSessionSidebarSections = (args: Args) => {
|
||||
availableWorktreesByProject,
|
||||
projectRepoStatus,
|
||||
projectRootBranches,
|
||||
gitBranches,
|
||||
lastRepoStatus,
|
||||
buildGroupedSessions,
|
||||
hasSessionSearchQuery,
|
||||
@@ -101,6 +115,7 @@ export const useSessionSidebarSections = (args: Args) => {
|
||||
? Boolean(projectRepoStatus.get(project.id))
|
||||
: lastRepoStatus;
|
||||
const rootBranch = projectRootBranches.get(project.id) ?? null;
|
||||
const worktreeBranchesKey = worktreeBranchesKeyFor(worktreesForProject, gitBranches);
|
||||
const cached = previousCache.get(project.id);
|
||||
if (
|
||||
cached
|
||||
@@ -109,6 +124,7 @@ export const useSessionSidebarSections = (args: Args) => {
|
||||
&& sameSessions(cached.archivedSessions, archivedSessions)
|
||||
&& cached.availableWorktrees === worktreesForProject
|
||||
&& cached.rootBranch === rootBranch
|
||||
&& cached.worktreeBranchesKey === worktreeBranchesKey
|
||||
&& cached.isRepo === isRepo
|
||||
&& cached.buildGroupedSessions === buildGroupedSessions
|
||||
) {
|
||||
@@ -118,6 +134,19 @@ export const useSessionSidebarSections = (args: Args) => {
|
||||
}
|
||||
|
||||
rebuiltSections += 1;
|
||||
if (cached) {
|
||||
// Diagnostic: name what invalidated the cached section so a sidebar
|
||||
// that rebuilds on every session switch can be traced to its input.
|
||||
const reason = cached.project !== project ? 'project'
|
||||
: !sameSessions(cached.activeSessions, activeSessions) ? 'sessions'
|
||||
: !sameSessions(cached.archivedSessions, archivedSessions) ? 'archived'
|
||||
: cached.availableWorktrees !== worktreesForProject ? 'worktrees'
|
||||
: cached.rootBranch !== rootBranch ? 'branch'
|
||||
: cached.worktreeBranchesKey !== worktreeBranchesKey ? 'worktreeBranches'
|
||||
: cached.isRepo !== isRepo ? 'repo'
|
||||
: 'builder';
|
||||
streamPerfCount(`ui.sidebar.project_section.rebuilt_reason.${reason}`);
|
||||
}
|
||||
const projectSessions = dedupeSessionsById([...activeSessions, ...archivedSessions]);
|
||||
const groups = buildGroupedSessions(
|
||||
projectSessions,
|
||||
@@ -133,6 +162,7 @@ export const useSessionSidebarSections = (args: Args) => {
|
||||
archivedSessions,
|
||||
availableWorktrees: worktreesForProject,
|
||||
rootBranch,
|
||||
worktreeBranchesKey,
|
||||
isRepo,
|
||||
buildGroupedSessions,
|
||||
section,
|
||||
@@ -152,6 +182,7 @@ export const useSessionSidebarSections = (args: Args) => {
|
||||
lastRepoStatus,
|
||||
buildGroupedSessions,
|
||||
projectRootBranches,
|
||||
gitBranches,
|
||||
]);
|
||||
|
||||
const visibleProjectSections = React.useMemo(() => {
|
||||
|
||||
@@ -23,7 +23,8 @@ import { Icon } from "@/components/icon/Icon";
|
||||
import { buildExportFilename, downloadAsMarkdown, formatSessionAsMarkdown, getExportRevealLabelKey, revealExportedMarkdown, saveAsMarkdownDesktop } from '@/lib/exportSession';
|
||||
import type { ChildSessionExport } from '@/lib/exportSession';
|
||||
import { useGlobalSessionStatus, useSessionPermissions, useSessionQuestionCount } from '@/sync/sync-context';
|
||||
import { useSessionMessageRecordsForExport } from '@/sync/use-sync';
|
||||
import { usePrefetchSessionMessages, useSessionMessageRecordsForExport } from '@/sync/use-sync';
|
||||
import { getSyncSessionMaterializationStatus } from '@/sync/sync-refs';
|
||||
import { useViewportStore, viewportSessionKey } from '@/sync/viewport-store';
|
||||
import { DraggableSessionRow } from '../folders/sessionFolderDnd';
|
||||
import { canShowSessionWorktreeMenu, getSessionWorktreeMenuDisabled, nodeContainsSessionId, nodeHasPinnedMembershipChange, selectQuestionBadgeSessionScopes, selectRowBadgeVisibilityClass } from './sessionNodeItemUtils';
|
||||
@@ -406,6 +407,10 @@ function SessionNodeItemComponent(props: SessionNodeItemProps): React.ReactNode
|
||||
// selection must survive mixing sessions from different worktrees.
|
||||
const selectionScopeKey = projectId ?? sessionDirectory ?? null;
|
||||
const loadExportRecords = useSessionMessageRecordsForExport();
|
||||
const prefetchSessionMessages = usePrefetchSessionMessages();
|
||||
// Same gate as the sidebar's neighbor prefetch: the VS Code webview keeps
|
||||
// its message traffic to what is actually opened.
|
||||
const prefetchOnPressDisabled = isVSCode;
|
||||
|
||||
const selectionModeEnabled = useSessionMultiSelectStore((state) => state.enabled);
|
||||
const isRowSelected = useSessionMultiSelectStore(
|
||||
@@ -908,6 +913,20 @@ function SessionNodeItemComponent(props: SessionNodeItemProps): React.ReactNode
|
||||
if (mobileVariant && event.pointerType === 'touch') {
|
||||
setIsTouchPressed(true);
|
||||
}
|
||||
// The press is the earliest signal that this row is about to be opened.
|
||||
// Starting the message load here puts the request on the wire before the
|
||||
// click handler and the render it triggers, so a cold open overlaps the
|
||||
// network round trip with that work instead of waiting for it.
|
||||
if (
|
||||
event.button === 0
|
||||
&& !isActive
|
||||
&& !selectionModeEnabled
|
||||
&& !prefetchOnPressDisabled
|
||||
&& sessionDirectory
|
||||
&& !getSyncSessionMaterializationStatus(session.id, sessionDirectory).renderable
|
||||
) {
|
||||
void prefetchSessionMessages({ directory: sessionDirectory, sessionID: session.id }).catch(() => undefined);
|
||||
}
|
||||
};
|
||||
const handleRowPointerEnd = (event: React.PointerEvent<HTMLButtonElement>) => {
|
||||
if (mobileVariant && event.pointerType === 'touch') {
|
||||
@@ -1334,6 +1353,7 @@ function SessionNodeItemComponent(props: SessionNodeItemProps): React.ReactNode
|
||||
data-session-row={session.id}
|
||||
data-session-scope={selectionScopeKey ?? ''}
|
||||
data-session-archived={archivedBucket ? '1' : '0'}
|
||||
aria-current={isActive ? 'page' : undefined}
|
||||
onClick={handleRowBackgroundClick}
|
||||
// Row geometry mirrors the zone-header band: full container
|
||||
// width, px-1.5 inner edge, a 14px icon-wide gutter (status
|
||||
@@ -1707,24 +1727,27 @@ const areSessionRenderSemanticsEqual = (prev: Session, next: Session): boolean =
|
||||
&& prev.time?.archived === next.time?.archived
|
||||
);
|
||||
|
||||
const areSessionNodeItemPropsEqual = (prev: SessionNodeItemProps, next: SessionNodeItemProps): boolean => {
|
||||
if (prev.node.session.id !== next.node.session.id) return false;
|
||||
if (!areSessionRenderSemanticsEqual(prev.node.session, next.node.session)) return false;
|
||||
if (!areNodeWorktreeRenderSemanticsEqual(prev.node, next.node)) return false;
|
||||
if (prev.depth !== next.depth) return false;
|
||||
if (prev.groupDirectory !== next.groupDirectory) return false;
|
||||
if (prev.projectId !== next.projectId) return false;
|
||||
if (prev.archivedBucket !== next.archivedBucket) return false;
|
||||
if ((prev.renderContext ?? 'project') !== (next.renderContext ?? 'project')) return false;
|
||||
if (prev.mobileVariant !== next.mobileVariant) return false;
|
||||
if (prev.alwaysShowActions !== next.alwaysShowActions) return false;
|
||||
if (prev.hasSessionSearchQuery !== next.hasSessionSearchQuery) return false;
|
||||
if (prev.normalizedSessionSearchQuery !== next.normalizedSessionSearchQuery) return false;
|
||||
if (prev.notifyOnSubtasks !== next.notifyOnSubtasks) return false;
|
||||
if (prev.nodeStructureKey !== next.nodeStructureKey) return false;
|
||||
if (prev.relativeTimeTick !== next.relativeTimeTick) return false;
|
||||
if (getNodeSessionDirectory(prev.node) !== getNodeSessionDirectory(next.node)) return false;
|
||||
if (!isSecondaryMetaEqual(prev.secondaryMeta, next.secondaryMeta)) return false;
|
||||
// Returns the name of the first prop whose change requires a render, or null
|
||||
// when the row can skip it. The name feeds the stream perf counters so sidebar
|
||||
// churn is explained, not only counted.
|
||||
const sessionNodeItemPropsChange = (prev: SessionNodeItemProps, next: SessionNodeItemProps): string | null => {
|
||||
if (prev.node.session.id !== next.node.session.id) return 'node';
|
||||
if (!areSessionRenderSemanticsEqual(prev.node.session, next.node.session)) return 'node';
|
||||
if (!areNodeWorktreeRenderSemanticsEqual(prev.node, next.node)) return 'node';
|
||||
if (prev.depth !== next.depth) return 'depth';
|
||||
if (prev.groupDirectory !== next.groupDirectory) return 'groupDirectory';
|
||||
if (prev.projectId !== next.projectId) return 'projectId';
|
||||
if (prev.archivedBucket !== next.archivedBucket) return 'archivedBucket';
|
||||
if ((prev.renderContext ?? 'project') !== (next.renderContext ?? 'project')) return 'renderContext';
|
||||
if (prev.mobileVariant !== next.mobileVariant) return 'mobileVariant';
|
||||
if (prev.alwaysShowActions !== next.alwaysShowActions) return 'alwaysShowActions';
|
||||
if (prev.hasSessionSearchQuery !== next.hasSessionSearchQuery) return 'hasSessionSearchQuery';
|
||||
if (prev.normalizedSessionSearchQuery !== next.normalizedSessionSearchQuery) return 'normalizedSessionSearchQuery';
|
||||
if (prev.notifyOnSubtasks !== next.notifyOnSubtasks) return 'notifyOnSubtasks';
|
||||
if (prev.nodeStructureKey !== next.nodeStructureKey) return 'nodeStructureKey';
|
||||
if (prev.relativeTimeTick !== next.relativeTimeTick) return 'relativeTimeTick';
|
||||
if (getNodeSessionDirectory(prev.node) !== getNodeSessionDirectory(next.node)) return 'nodeDirectory';
|
||||
if (!isSecondaryMetaEqual(prev.secondaryMeta, next.secondaryMeta)) return 'secondaryMeta';
|
||||
|
||||
if (prev.pinnedSessionIds !== next.pinnedSessionIds
|
||||
&& nodeHasPinnedMembershipChange(
|
||||
@@ -1735,11 +1758,11 @@ const areSessionNodeItemPropsEqual = (prev: SessionNodeItemProps, next: SessionN
|
||||
prev.groupDirectory,
|
||||
next.groupDirectory,
|
||||
)) {
|
||||
return false;
|
||||
return 'pinnedSessionIds';
|
||||
}
|
||||
|
||||
if (prev.expandedParents !== next.expandedParents && hasExpansionMembershipChange(prev, next)) {
|
||||
return false;
|
||||
return 'expandedParents';
|
||||
}
|
||||
|
||||
if (prev.editingId !== next.editingId
|
||||
@@ -1747,7 +1770,7 @@ const areSessionNodeItemPropsEqual = (prev: SessionNodeItemProps, next: SessionN
|
||||
subtreeContainsSession(prev, prev.editingId, prev.subtreeContainsEditing)
|
||||
|| subtreeContainsSession(next, next.editingId, next.subtreeContainsEditing)
|
||||
)) {
|
||||
return false;
|
||||
return 'editingId';
|
||||
}
|
||||
|
||||
if (prev.editTitle !== next.editTitle
|
||||
@@ -1755,7 +1778,7 @@ const areSessionNodeItemPropsEqual = (prev: SessionNodeItemProps, next: SessionN
|
||||
subtreeContainsSession(prev, prev.editingId, prev.subtreeContainsEditing)
|
||||
|| subtreeContainsSession(next, next.editingId, next.subtreeContainsEditing)
|
||||
)) {
|
||||
return false;
|
||||
return 'editTitle';
|
||||
}
|
||||
|
||||
if (prev.copiedSessionId !== next.copiedSessionId
|
||||
@@ -1763,18 +1786,18 @@ const areSessionNodeItemPropsEqual = (prev: SessionNodeItemProps, next: SessionN
|
||||
nodeContainsSessionId(prev.node, prev.copiedSessionId)
|
||||
|| nodeContainsSessionId(next.node, next.copiedSessionId)
|
||||
)) {
|
||||
return false;
|
||||
return 'copiedSessionId';
|
||||
}
|
||||
|
||||
if (prev.openSidebarMenuKey !== next.openSidebarMenuKey) {
|
||||
const prevMenuSessionId = getRelevantMenuSessionId(prev);
|
||||
const nextMenuSessionId = getRelevantMenuSessionId(next);
|
||||
if (nodeContainsSessionId(prev.node, prevMenuSessionId) || nodeContainsSessionId(next.node, nextMenuSessionId)) {
|
||||
return false;
|
||||
return 'openSidebarMenuKey';
|
||||
}
|
||||
}
|
||||
|
||||
return prev.setEditingId === next.setEditingId
|
||||
const callbacksEqual = prev.setEditingId === next.setEditingId
|
||||
&& prev.setEditTitle === next.setEditTitle
|
||||
&& prev.handleSaveEdit === next.handleSaveEdit
|
||||
&& prev.handleCancelEdit === next.handleCancelEdit
|
||||
@@ -1791,6 +1814,15 @@ const areSessionNodeItemPropsEqual = (prev: SessionNodeItemProps, next: SessionN
|
||||
&& prev.handleRestoreSession === next.handleRestoreSession
|
||||
&& prev.startSessionWorktreeMenuLoad === next.startSessionWorktreeMenuLoad
|
||||
&& prev.children === next.children;
|
||||
if (!callbacksEqual) return 'callbacks';
|
||||
return null;
|
||||
};
|
||||
|
||||
const areSessionNodeItemPropsEqual = (prev: SessionNodeItemProps, next: SessionNodeItemProps): boolean => {
|
||||
const changed = sessionNodeItemPropsChange(prev, next);
|
||||
if (changed === null) return true;
|
||||
streamPerfCount(`ui.sidebar_session_node.props_changed.${changed}`);
|
||||
return false;
|
||||
};
|
||||
|
||||
export const SessionNodeItem = React.memo(SessionNodeItemComponent, areSessionNodeItemPropsEqual);
|
||||
|
||||
@@ -97,15 +97,23 @@ export function SessionTreeItem({
|
||||
const toggleFolderCollapse = useSessionFoldersStore((state) => state.toggleFolderCollapse);
|
||||
const showDeletionDialog = useUIStore((state) => state.showDeletionDialog);
|
||||
const setShowDeletionDialog = useUIStore((state) => state.setShowDeletionDialog);
|
||||
const descendantIds = React.useMemo(() => {
|
||||
// Keyed by the descendant ids themselves, not by node identity: the sidebar
|
||||
// rebuilds a project's node tree whenever one of its session records
|
||||
// changes, and a fresh array here would give every row in that project a
|
||||
// new delete handler and force it to re-render.
|
||||
const descendantIdsKey = React.useMemo(() => {
|
||||
const ids: string[] = [];
|
||||
const visit = (current: SessionNode) => current.children.forEach((child) => {
|
||||
ids.push(child.session.id);
|
||||
visit(child);
|
||||
});
|
||||
visit(node);
|
||||
return ids;
|
||||
return ids.join('\n');
|
||||
}, [node]);
|
||||
const descendantIds = React.useMemo(
|
||||
() => (descendantIdsKey ? descendantIdsKey.split('\n') : []),
|
||||
[descendantIdsKey],
|
||||
);
|
||||
const createFolderAndStartRename = React.useCallback((scopeKey: string, parentId?: string | null) => {
|
||||
if (!scopeKey) return null;
|
||||
if (parentId && useSessionFoldersStore.getState().collapsedFolderIds.has(parentId)) toggleFolderCollapse(parentId);
|
||||
|
||||
Reference in New Issue
Block a user