BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: handle non-ISO-8859-1 characters in fetch headers and Content-Disposition (#1673)

Browse Source 
* fix: handle non-ISO-8859-1 characters in fetch headers and Content-Disposition

Browser Headers API rejects characters above U+00FF. The x-opencode-directory header carries raw filesystem paths, which breaks when paths contain Chinese/CJK characters. Also fixes Content-Disposition for non-ASCII filenames per RFC 5987.

* refactor: export header sanitization helpers, deduplicate, add tests

Export isLatin1Safe and sanitizeHeadersForBrowser from runtime-fetch.ts so VS Code webview can import them instead of duplicating the logic. Add tests: isLatin1Safe boundary checks, sanitizeHeadersForBrowser encoding/deduplication, runtimeFetch round-trip encode/decode, and Content-Disposition RFC 5987 output for both ASCII and non-ASCII filenames.

* fix: mark encoded directory headers

---------

Co-authored-by: Bohdan Triapitsyn <artmore@protonmail.com>
This commit is contained in:
FanFan4204
2026-06-23 19:49:44 +03:00
committed by GitHub
co-authored by Bohdan Triapitsyn
parent 43f677d56d
commit efd621b087
7 changed files with 289 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/vscode/webview/main.tsx
+9 -2
View File
@@ -4,6 +4,7 @@ import { vscodeStreamPerfCount, vscodeStreamPerfMeasure, vscodeStreamPerfObserve
import { extractBodyBase64, extractBodyText, extractJsonBody, hasInitBody } from './requestBodyTransport';
import type { RuntimeAPIs } from '@openchamber/ui/lib/api/types';
import { opencodeClient } from '@openchamber/ui/lib/opencode/client';
import { sanitizeHeadersForBrowser } from '@openchamber/ui/lib/runtime-fetch';
import {
buildVSCodeThemeFromPalette,
readVSCodeThemePalette,
@@ -279,7 +280,7 @@ const normalizeUrl = (input: string | URL) => {
const headersToRecord = (headers: HeadersInit | undefined): Record<string, string> => {
if (!headers) return {};
const normalized = headers instanceof Headers ? headers : new Headers(headers);
const normalized = new Headers(sanitizeHeadersForBrowser(headers) ?? headers);
const result: Record<string, string> = {};
normalized.forEach((value, key) => {
result[key] = value;
@@ -297,8 +298,14 @@ const getRequestDirectoryHint = (url: URL, input?: RequestInfo | URL, init?: Req
const queryDirectory = url.searchParams.get('directory') || undefined;
if (queryDirectory) return queryDirectory;
const headers = getRequestHeaders(input, init);
const directoryEncoding = Object.entries(headers).find(([key]) => key.toLowerCase() === 'x-opencode-directory-encoding')?.[1];
for (const [key, value] of Object.entries(headers)) {
if (key.toLowerCase() === 'x-opencode-directory') return value;
if (key.toLowerCase() === 'x-opencode-directory') {
// headersToRecord marks encoded directory hints so direct/raw percent
// sequences from other callers are not decoded accidentally.
if (directoryEncoding !== 'uri') return value;
try { return decodeURIComponent(value); } catch { return value; }
}
}
return undefined;
};