From f51f77f7508b7d7a3c42cd120a009375be03759b Mon Sep 17 00:00:00 2001 From: Tom Rochette Date: Thu, 13 Aug 2026 04:32:15 +0000 Subject: [PATCH] Address review: drop {max} from de/ja tooltips, add isolated-path test German and Japanese locales (added on main after the original branch point) still interpolated {max}, which would render literally now that the tooltip passes no max param. Also cover the isolated per-worktree dispatch path (>5 models) in the store test. --- packages/ui/src/lib/i18n/messages/de.ts | 2 +- packages/ui/src/lib/i18n/messages/ja.ts | 2 +- .../ui/src/stores/useMultiRunStore.test.ts | 19 +++++++++++++++++++ 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/packages/ui/src/lib/i18n/messages/de.ts b/packages/ui/src/lib/i18n/messages/de.ts index 9c1e41ab..58ff0870 100644 --- a/packages/ui/src/lib/i18n/messages/de.ts +++ b/packages/ui/src/lib/i18n/messages/de.ts @@ -347,7 +347,7 @@ export const dict = { 'multirun.launcher.attachments.attach': 'Anhängen', 'multirun.launcher.attachments.tooltip': 'Denselben Dateien an alle Durchläufe senden', 'multirun.launcher.models.label': 'Modelle', - 'multirun.launcher.models.info': 'Wählen Sie 2-{max} Modelle. Das gleiche Modell kann mehrfach hinzugefügt werden.', + 'multirun.launcher.models.info': 'Wählen Sie 2 oder mehr Modelle. Das gleiche Modell kann mehrfach hinzugefügt werden.', 'multirun.launcher.toast.fileTooLarge': 'Datei "{fileName}" ist zu groß (max. 10MB)', 'multirun.launcher.toast.attachFailed': 'Fehler beim Anhängen von "{fileName}"', 'multirun.launcher.toast.attachedSingle': '{count} Datei angehängt', diff --git a/packages/ui/src/lib/i18n/messages/ja.ts b/packages/ui/src/lib/i18n/messages/ja.ts index 2b65cc04..cbfea436 100644 --- a/packages/ui/src/lib/i18n/messages/ja.ts +++ b/packages/ui/src/lib/i18n/messages/ja.ts @@ -370,7 +370,7 @@ export const dict: Record = { 'multirun.launcher.attachments.attach': '添付', 'multirun.launcher.attachments.tooltip': '同じファイルをすべての実行に送信', 'multirun.launcher.models.label': 'モデル', - 'multirun.launcher.models.info': '2~{max}モデルを選択。同じモデルを複数回追加できます。', + 'multirun.launcher.models.info': '2つ以上のモデルを選択。同じモデルを複数回追加できます。', 'multirun.launcher.toast.fileTooLarge': 'ファイル「{fileName}」が大きすぎます(最大10MB)', 'multirun.launcher.toast.attachFailed': '「{fileName}」の添付に失敗しました', 'multirun.launcher.toast.attachedSingle': '{count}ファイルを添付しました', diff --git a/packages/ui/src/stores/useMultiRunStore.test.ts b/packages/ui/src/stores/useMultiRunStore.test.ts index dddb10c9..f536b1a1 100644 --- a/packages/ui/src/stores/useMultiRunStore.test.ts +++ b/packages/ui/src/stores/useMultiRunStore.test.ts @@ -242,4 +242,23 @@ describe('useMultiRunStore', () => { expect(useMultiRunStore.getState().error).toBeNull(); expect(result?.sessionIds).toHaveLength(6); }); + + test('accepts more than 5 models on the isolated (per-worktree) dispatch path', async () => { + isGitRepository = true; + + const models = Array.from({ length: 6 }, (_, i) => ({ + providerID: 'anthropic', + modelID: `claude-sonnet-4-5-${i}`, + })); + + const result = await useMultiRunStore.getState().createMultiRun({ + name: 'Many models', + isolateRuns: true, + groups: [{ prompt: 'Fix it', models }], + }); + + expect(useMultiRunStore.getState().error).toBeNull(); + expect(result?.sessionIds).toHaveLength(6); + expect(worktreeCreateCalls.length).toBe(6); + }); });