BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(terminal): track SSE opens per attempt (#1171)

Browse Source 
Co-authored-by: Isaac Sanchez <isanchez-hawkins@arize.com>
This commit is contained in:
Isaac Sanchez-Hawkins
2026-05-08 23:34:03 +03:00
committed by GitHub
co-authored by Isaac Sanchez
parent c550d02dc8
commit f524880c94
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/lib/terminalApi.ts
+4 -4
View File
@@ -786,7 +786,6 @@ const connectTerminalStreamViaSse = (
let retryTimeout: ReturnType<typeof setTimeout> | null = null; let retryTimeout: ReturnType<typeof setTimeout> | null = null;
let connectionTimeoutId: ReturnType<typeof setTimeout> | null = null; let connectionTimeoutId: ReturnType<typeof setTimeout> | null = null;
let isClosed = false; let isClosed = false;
let hasDispatchedOpen = false;
let terminalExited = false; let terminalExited = false;
const clearTimeouts = () => { const clearTimeouts = () => {
@@ -850,20 +849,21 @@ const connectTerminalStreamViaSse = (
} }
eventSource = new EventSource(`/api/terminal/${sessionId}/stream`); eventSource = new EventSource(`/api/terminal/${sessionId}/stream`);
let opened = false;
connectionTimeoutId = setTimeout(() => { connectionTimeoutId = setTimeout(() => {
if (!hasDispatchedOpen && eventSource?.readyState !== EventSource.OPEN) { if (!opened && eventSource?.readyState !== EventSource.OPEN) {
eventSource?.close(); eventSource?.close();
handleError(new Error('Connection timeout'), false); handleError(new Error('Connection timeout'), false);
} }
}, connectionTimeout); }, connectionTimeout);
eventSource.onopen = () => { eventSource.onopen = () => {
if (hasDispatchedOpen) { if (opened) {
return; return;
} }
hasDispatchedOpen = true; opened = true;
retryCount = 0; retryCount = 0;
clearTimeouts(); clearTimeouts();
onEvent({ type: 'connected' }); onEvent({ type: 'connected' });