Improve OpenChamber responsiveness under large session workloads while fixing cache, synchronization, and persistence correctness across runtimes, projects, directories, and worktrees. - prioritize selected and visible sessions during bootstrap and defer non-critical enrichment work - reduce redundant message loading, event processing, store publication, and hidden sidebar work - prevent stale session and message requests from overwriting newer authoritative state - preserve existing data when authoritative fetches fail instead of treating failures as successful empty responses - scope session materialization, messages, drafts, queues, todos, pins, permissions, folders, tabs, Git state, and pull request data by runtime and directory identity - harden runtime switching, reconnect, cleanup, mutation reconciliation, and persisted-state ordering - preserve live subagent Task linkage when metadata arrives after an older message request or while streaming parts are suspended - coalesce overlapping tail refreshes without losing newer refresh demand - improve cold-session loading by moving deferrable work out of the critical bootstrap path - isolate URL authentication, mobile credentials, native secrets, and other runtime-owned state across endpoint changes - bound long-lived caches and remove avoidable allocations from event and rendering hot paths - limit virtualization to archive collections where it improves rendering without disrupting active sidebar layout - stabilize session folders, pin ordering, expanded state, and persisted sidebar behavior - open skill files through the same secure editor and outside-workspace grant flow used by file navigation, including worktree sessions - expand regression coverage for stale completions, runtime collisions, reconnect behavior, persistence races, authoritative empty results, and subagent refresh ordering - document the updated synchronization, cache ownership, performance, and runtime-isolation invariants
132 lines
4.7 KiB
JavaScript
132 lines
4.7 KiB
JavaScript
const MAX_BODY_BYTES = 4 * 1024 * 1024;
|
|
|
|
const isObjectRecord = (value) => Boolean(value) && typeof value === 'object' && !Array.isArray(value);
|
|
|
|
const hasValidFolderShape = (folder) => (
|
|
isObjectRecord(folder)
|
|
&& typeof folder.id === 'string'
|
|
&& typeof folder.name === 'string'
|
|
&& Array.isArray(folder.sessionIds)
|
|
&& folder.sessionIds.every((sessionId) => typeof sessionId === 'string')
|
|
&& typeof folder.createdAt === 'number'
|
|
&& Number.isFinite(folder.createdAt)
|
|
&& (folder.parentId === undefined || folder.parentId === null || typeof folder.parentId === 'string')
|
|
);
|
|
|
|
const hasValidFoldersMapShape = (foldersMap) => (
|
|
isObjectRecord(foldersMap)
|
|
&& Object.values(foldersMap).every((folders) => (
|
|
Array.isArray(folders) && folders.every(hasValidFolderShape)
|
|
))
|
|
);
|
|
|
|
const hasValidFolderSnapshotShape = (snapshot) => (
|
|
isObjectRecord(snapshot)
|
|
&& snapshot.version === 1
|
|
&& hasValidFoldersMapShape(snapshot.foldersMap)
|
|
&& Array.isArray(snapshot.collapsedFolderIds)
|
|
&& snapshot.collapsedFolderIds.every((folderId) => typeof folderId === 'string')
|
|
);
|
|
|
|
export const registerSessionFoldersRoutes = (app, dependencies) => {
|
|
const {
|
|
fsPromises,
|
|
path,
|
|
openchamberDataDir,
|
|
} = dependencies;
|
|
|
|
const filePath = path.join(openchamberDataDir, 'sessions-directories.json');
|
|
let saveQueue = Promise.resolve();
|
|
|
|
const ensureDir = async () => {
|
|
await fsPromises.mkdir(path.dirname(filePath), { recursive: true });
|
|
};
|
|
|
|
app.get('/api/session-folders', async (_req, res) => {
|
|
try {
|
|
const raw = await fsPromises.readFile(filePath, 'utf8').catch((error) => {
|
|
if (error && error.code === 'ENOENT') return null;
|
|
throw error;
|
|
});
|
|
if (!raw) {
|
|
return res.json({ version: 1, exists: false });
|
|
}
|
|
try {
|
|
const parsed = JSON.parse(raw);
|
|
if (
|
|
!hasValidFolderSnapshotShape(parsed)
|
|
|| typeof parsed.updatedAt !== 'number'
|
|
|| !Number.isFinite(parsed.updatedAt)
|
|
|| parsed.updatedAt <= 0
|
|
) {
|
|
return res.status(500).json({ error: 'Stored session folders have an invalid shape' });
|
|
}
|
|
return res.json({ ...parsed, exists: true });
|
|
} catch {
|
|
return res.status(500).json({ error: 'Stored session folders are malformed' });
|
|
}
|
|
} catch (error) {
|
|
const message = error instanceof Error ? error.message : 'Failed to read session folders';
|
|
return res.status(500).json({ error: message });
|
|
}
|
|
});
|
|
|
|
app.post('/api/session-folders', async (req, res) => {
|
|
const body = req.body;
|
|
if (!isObjectRecord(body)) {
|
|
return res.status(400).json({ error: 'Body must be an object' });
|
|
}
|
|
if (!hasValidFolderSnapshotShape(body)) {
|
|
return res.status(400).json({ error: 'Invalid session folders payload' });
|
|
}
|
|
const serialized = JSON.stringify(body, null, 2);
|
|
if (Buffer.byteLength(serialized, 'utf8') > MAX_BODY_BYTES) {
|
|
return res.status(413).json({ error: 'Payload too large' });
|
|
}
|
|
if (typeof body.updatedAt !== 'number' || !Number.isFinite(body.updatedAt) || body.updatedAt <= 0) {
|
|
return res.status(400).json({ error: 'updatedAt must be a positive finite number' });
|
|
}
|
|
|
|
const save = async () => {
|
|
let tmp;
|
|
let saved = false;
|
|
try {
|
|
const currentRaw = await fsPromises.readFile(filePath, 'utf8').catch((error) => {
|
|
if (error && error.code === 'ENOENT') return null;
|
|
throw error;
|
|
});
|
|
if (currentRaw) {
|
|
try {
|
|
const current = JSON.parse(currentRaw);
|
|
const currentUpdatedAt = hasValidFolderSnapshotShape(current)
|
|
&& typeof current.updatedAt === 'number'
|
|
&& Number.isFinite(current.updatedAt)
|
|
? current.updatedAt
|
|
: 0;
|
|
if (currentUpdatedAt >= body.updatedAt) {
|
|
return res.json({ success: true, ignored: true });
|
|
}
|
|
} catch { /* A valid new snapshot repairs malformed prior state. */ }
|
|
}
|
|
|
|
await ensureDir();
|
|
tmp = `${filePath}.tmp-${process.pid}-${Date.now()}-${Math.random().toString(16).slice(2)}`;
|
|
await fsPromises.writeFile(tmp, serialized, 'utf8');
|
|
await fsPromises.rename(tmp, filePath);
|
|
saved = true;
|
|
return res.json({ success: true });
|
|
} catch (error) {
|
|
if (tmp && !saved) {
|
|
await fsPromises.unlink(tmp).catch(() => {});
|
|
}
|
|
const message = error instanceof Error ? error.message : 'Failed to write session folders';
|
|
return res.status(500).json({ error: message });
|
|
}
|
|
};
|
|
|
|
const pendingSave = saveQueue.then(save, save);
|
|
saveQueue = pendingSave.then(() => undefined, () => undefined);
|
|
return pendingSave;
|
|
});
|
|
};
|