BuzzbeeSCD/openchamber
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
01a52eccabb123e46104f6d3631ee6ae66cd7d78
openchamber/plans/opencode-v1.17.12-sdk/todo.md
T
Leonidandbashrusakh 01a52eccab SDK v1.17.12: session.permission — programmatic create/fetch, more reliable auto-accept (#1982) 
* docs: add SDK v1.17.12 migration plan — phase 4 (session.permission)

* feat(permissions): verify pending permission before auto-accept via SDK v1.17.12

Adds createPermission() and fetchPermission() wrappers on OpencodeService
for the new v2.session.permission endpoints (OpenCode SDK 1.17.12).

fetchPermission() is used by the auto-accept sweep in
resyncBlockingRequestsForDirectory to verify a permission is still
pending before replying. The auto-accept flow now skips permissions
that are already resolved, returning a null from fetchPermission()
rather than blindly calling respondToPermission on a stale entry.

createPermission() is exposed for future programmatic permission
creation; the V1 list/reply path used by the UI is unchanged.

The plan doc at plans/opencode-v1.17.12-sdk/ was rebased onto
origin/main in the prior commit to keep the PR diff focused on
this change.

Closes #1972

* fix(permissions): drop confirmed-resolved permissions from auto-accept resync

fetchPermission() now returns a tagged FetchPermissionResult so the
auto-accept loop can distinguish a server-confirmed 404 (the
permission is no longer pending) from a fetch failure (network error
or pre-v1.17.12 server). Previously both cases collapsed to null, so
a permission the server had already answered would still appear in
the resync output and trigger a spurious 'Permission needed' toast.

The auto-accept loop in resyncBlockingRequestsForDirectory now tracks
both accepted and resolved permissions, then drops both from the
'grouped' map before it falls through to the toast path. On a
pre-v1.17.12 server (no V2 endpoint) the call still returns
'unknown' and the permission stays in the resync output so the user
can answer manually — fail-closed, no false-resolved signals.

Adds a focused unit test for fetchPermission (4 cases: 200 ok, 404
resolved, 500 unknown, network throw) mocking the V2 SDK client
shape.

---------

Co-authored-by: bashrusakh <bashrusakh@users.noreply.github.com>
2026-07-11 16:11:13 +03:00

3.0 KiB
Raw Blame History

Todo — OpenCode v1.17.12 SDK Migration

Phase 1: session.interrupt() — server-side abort propagation

  • Bump @opencode-ai/sdk to ^1.17.12 in all package.json files
  • Add session.interrupt() mock to session-actions.test.ts
  • Replace session.abort() → session.interrupt() in abortCurrentOperation() (line 717)
  • Replace session.abort() → session.interrupt() in revertToMessage() (line 910)
  • Replace session.abort() → session.interrupt() in unrevertSession() (line 1042)
  • Add interruptSession() wrapper to client.ts (optional)
  • Run bun run type-check in packages/ui
  • Run bun test packages/ui/src/sync/session-actions.test.ts
  • Manual: verify STOP button aborts session and propagates to provider

Phase 2: session.events() — per-session event stream

  • Verify session.events() exists in SDK v1.17.12 types
  • Add subscribeSessionEvents() to client.ts
  • Use per-session stream in ChatContainer (reduce global firehose routing)
  • Keep global pipeline as fallback for non-active sessions
  • Run bun run type-check in packages/ui
  • Manual: verify events arrive for active session only

Phase 3: Migrate all message operations to Session3 API

Step 1: Switch session.messages() calls from Session2 to Session3 API

  • Pass cursor param in fetchMessages() (use-sync.ts line 326)
  • Pass cursor param in materializeSessionFromServer() (sync-context.tsx line 240)
  • Pass cursor param in resyncDirectoryAfterReconnect() (sync-context.tsx line 1207)
  • Pass cursor param in refetchSessionMessages() (session-actions.ts line 1010)
  • Pass cursor param in fetchMessagesForSession() (session-actions.ts line 1147)
  • Pass cursor param in getSessionMessages() (client.ts line 547)
  • Remove directory param from per-call args (set at client creation via scoped client)
  • Replace before param with cursor

Step 2: Add session.message() on the same Session3 API

  • Add getMessage() wrapper to client.ts using Session3.message()
  • Use in revertToMessage() as fallback when message not in store
  • Use in forkFromMessage() as fallback when message not in store

Validation

  • Run bun run type-check in packages/ui
  • Manual: load a session with 100+ messages, scroll up — smooth, no jank
  • Manual: revert an evicted session — works without full history load

Phase 4: session.permission — programmatic endpoints

  • Verify session.permission.create / fetch exist in SDK v1.17.12
  • Add wrappers to client.ts
  • Use in permission auto-accept flow (sync-context.tsx line 1118-1143)
  • Run bun run type-check in packages/ui
  • Manual: verify permission create/fetch flow

Blockers

  • SDK v1.17.12 must be published and installable
  • session.events() and session.permission must be confirmed in SDK types
  • Session3 API compatibility with current Session2 usage must be verified
Reference in New Issue View Git Blame Copy Permalink