Files
openchamber/packages/ui/src/components/sections/plugins/PluginsSidebar.tsx
T
17f1b24709 Standardize Settings layout and save feedback (#2122)
* Group settings navigation menu

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Revert "Group settings navigation menu"

This reverts commit 5983a4e82074b8dab1084af1cadd803ba28ea65d.

* Standardize settings layout feedback

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Fix settings save status timer typing

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Retain settings save status

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Report color mode save state

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Match Appearance settings to two-column layout

Rebuild Appearance into Color mode & Theme, Localization, and Density & type sections with responsive two-column grids, consistent section headers, page description, and green save status.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Migrate settings pages to SettingsPageLayout and SettingsSection

Replace ScrollableOverlay/max-w-3xl shells with the shared settings
layout primitives across entity and static settings pages, normalize
section headers, and add settings.page.behavior.description locales.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Unify remaining settings pages on shared section chrome

Wire Appearance, Projects, and Remote Instances through SettingsSection/SettingsPageLayout so every settings surface shares the same header, divider, and page shell treatment.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Align settings UI with OpenChamber design system kit

Apply kit geometry and control specs: 840px content width, 32/48 padding, fixed 260/280 sidebars, radius/spacing tokens, settings select height, stepper dimensions, and shared field/link typography.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Migrate OpenChamberVisualSettings to shared settings primitives

Replace ad-hoc radio/checkbox/chip/field layouts with SettingsSection
shared chrome for Appearance, Density, Navigation, Chat/behavior, and
Privacy while preserving handlers and data-settings-item anchors.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Migrate settings pages to shared field/checkbox/radio primitives

Unify Defaults, Notifications, Behavior, Git, Session Retention, Passkeys,
OpenCode CLI, Commands, About, Keyboard Shortcuts, and Desktop Network on
SettingsFieldRow / SettingsCheckboxRow / SettingsRadioGroup / SettingsChipGroup
for consistent grid, spacing, and DRY layout. Also remove the GitPage double
SettingsSection wrap around GitHubSettings.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Unify remaining settings pages onto shared field primitives

Migrate Agents, Snippets, Skills, Usage, MCP identity rows and selects to
SettingsFieldRow/CheckboxRow/ChipGroup and SETTINGS_SELECT_*; align page
titles; light-touch Voice/Tunnel/Providers/Plugins without rewriting
complex OAuth, permissions, or tunnel flows.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Polish settings section dividers and transport helper text

Slightly stronger section borders for clearer group separation, and keep
message-stream transport description under the chip control.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Fix settings grid alignment, control heights, and Chat section titles

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Tighten settings grid: flat Chat 2x2 and full-width stacked selects

Message options use a flat two-column grid so row headers share a baseline.
Stacked selects fill their column; field-row selects keep a fixed sm:w-56 width.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Align mixed settings controls to shared FieldRow/CheckboxRow grid

Separate FieldRows from CheckboxRows with SettingsInset, move enum
radios into ControlGroups, and convert misplaced StackedFields to
full-width FieldRows so left edges no longer clash.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Translate Behavior response-style preset labels for es and pl

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Group settings nav into categories and improve icons/order

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Fix settings layout: fewer hrs, shared control widths, chat transport section

Remove SettingsInset top borders, align App install/Density controls to full cluster width, give Message Stream Transport its own Chat section, and fold Sessions Small Model into the first section to cut extra dividers.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Align Voice and MCP settings labels with shared heading classes

Swap form field labels to SETTINGS_FIELD_LABEL_CLASS and use
SettingsGroupTitle for MCP control-group headings (manual auth fallback,
request headers).

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Differentiate settings heading levels by context

Page titles are larger and quieter than section titles; group and field
labels use dedicated shared classes so hierarchy is consistent across
settings surfaces without ad-hoc typography mixes.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Use shared settings title classes in SettingsView home

Wire home and unavailable headings through the shared L1/L2 class
constants so they stay aligned with SettingsPageLayout.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Keep settings number steppers from stretching +/- buttons

Density & type NumberInputs no longer flex-grow across the row, and
NumberInput locks minus/plus to fixed width so the plus side cannot
inflate when the control is placed in a full-width cluster.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Place spacing and input-bar offset on their own row

Density & type now lays out as font families, then font sizes, then
Spacing Density / Input Bar Offset on the row below.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Regroup settings nav and improve Voice layout

Drop Advanced/Usage/Git nav categories: Voice and About under
Interface, Usage under OpenCode, Git under Workspace. Voice provider
chips and STT model cards use shared settings primitives with roomier
spacing and a two-column model grid.

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>

* Space out chat feature groups in visual settings

* Polish settings: save-state wiring, container-query layouts, unified dropdown triggers

- Wire shared save indicator into Behavior page saves and git identity CRUD
- Convert settings layout primitives and page rows from viewport to container
  queries so narrow panes stack instead of clipping
- Unify custom dropdown triggers (model/agent/provider pickers) and remaining
  page selects on the settings control size
- Bump global radius scale by 1px; align variant input with select size
- Migrate stray raw controls (MCP OAuth checkbox, worktree remove button,
  git identity dialog rows, skills dialog labels) onto shared primitives
- Make settings nav items span full sidebar width; trim nav to 240px

* Add General settings page, regroup nav, cap control widths, promote chat feature headers

* Mobile settings nav: plain background and touch-sized rows

* Hide secondary settings descriptions behind clickable info hints

* Move quota credentials to Usage, navigation settings to General, rename External Tunnel

* Quiet settings save indicator: silent success, delayed spinner, visible errors

* Rewrite settings-ui-patterns skill around shared primitives and refactored conventions

* Remove settings starter page; open last visited page, defaulting to General

* Settings polish: spacing, control sizes, trigger widths, readable model names, device dates

* Centralize dropdown trigger chrome, settings nav polish, mobile-only input bar offset

* Fix global line-height regression, auto-hide first-section divider, shortcut row spacing

* Global line-height 1.45, align scheduled tasks header button with select

* Hide editor toolbar and About in VS Code, animate chat render preview outside desktop dialog

* Rebuild agent tool permissions on source-of-truth model

Edit the agent's own permission map verbatim (inherit vs explicit actions, pattern rules only for pattern-capable keys), save permission-only, drop the server-side non-wildcard re-merge that resurrected deleted rules, and surface session-granted rules as read-only.

* Agents model parameters polish: row spacing, variant dropdown, unified widths, dash for unset numbers

---------

Co-authored-by: Serhii Dziupin <makeittech@users.noreply.github.com>
Co-authored-by: Bohdan Triapitsyn <artmore@protonmail.com>
2026-07-18 00:11:05 +03:00

406 lines
13 KiB
TypeScript

import React from 'react';
import { useShallow } from 'zustand/react/shallow';
import { Button } from '@/components/ui/button';
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from '@/components/ui/dialog';
import { AddPluginDialog } from './AddPluginDialog';
import { RegistryBadge } from './RegistryBadge';
import { toast } from '@/components/ui';
import { Icon } from '@/components/icon/Icon';
import type { IconName } from '@/components/icon/icons';
import { SettingsSidebarLayout } from '@/components/sections/shared/SettingsSidebarLayout';
import { SettingsSidebarItem } from '@/components/sections/shared/SettingsSidebarItem';
import { useI18n } from '@/lib/i18n';
import {
usePluginsStore,
type PluginEntry,
type PluginFile,
} from '@/stores/usePluginsStore';
import { SETTINGS_PANEL_TITLE_CLASS } from '@/components/sections/shared/SettingsSection';
interface PluginsSidebarProps {
onItemSelect?: () => void;
onAddClick?: () => void;
}
type DeleteTarget =
| { kind: 'entry'; id: string; label: string }
| { kind: 'file'; id: string; label: string }
| null;
const entryIcon = (entry: PluginEntry): IconName =>
entry.parsedKind === 'npm' ? 'code-box' : 'folder';
export const PluginsSidebar: React.FC<PluginsSidebarProps> = ({
onItemSelect,
onAddClick,
}) => {
const { t } = useI18n();
const { entries, files, selectedId, setSelected, deleteEntry, deleteFile, loadPlugins } =
usePluginsStore(
useShallow((s) => ({
entries: s.entries,
files: s.files,
selectedId: s.selectedId,
setSelected: s.setSelected,
deleteEntry: s.deleteEntry,
deleteFile: s.deleteFile,
loadPlugins: s.loadPlugins,
})),
);
const registryInfo = usePluginsStore((s) => s.registryInfo);
const isLoadingRegistry = usePluginsStore((s) => s.isLoadingRegistry);
const loadRegistryInfo = usePluginsStore((s) => s.loadRegistryInfo);
const updateToLatest = usePluginsStore((s) => s.updateToLatest);
const [deleteTarget, setDeleteTarget] = React.useState<DeleteTarget>(null);
const [isDeleting, setIsDeleting] = React.useState(false);
const [isAddOpen, setIsAddOpen] = React.useState(false);
React.useEffect(() => {
void loadPlugins();
}, [loadPlugins]);
React.useEffect(() => {
const handleOpenAdd = () => setIsAddOpen(true);
window.addEventListener('openchamber:settings-open-plugin-add', handleOpenAdd);
return () => window.removeEventListener('openchamber:settings-open-plugin-add', handleOpenAdd);
}, []);
const updateCounts = React.useMemo(() => {
const counts = { userEntries: 0, projectEntries: 0 };
for (const entry of entries) {
const info = registryInfo[entry.spec];
if (info?.kind === 'npm-ok' && info.hasUpdate) {
if (entry.scope === 'user') counts.userEntries++;
else if (entry.scope === 'project') counts.projectEntries++;
}
}
return counts;
}, [entries, registryInfo]);
const userEntries = React.useMemo(
() => entries.filter((e) => e.scope === 'user'),
[entries],
);
const projectEntries = React.useMemo(
() => entries.filter((e) => e.scope === 'project'),
[entries],
);
const userFiles = React.useMemo(
() => files.filter((f) => f.scope === 'user'),
[files],
);
const projectFiles = React.useMemo(
() => files.filter((f) => f.scope === 'project'),
[files],
);
const total = entries.length + files.length;
const isEmpty = total === 0;
const handleAdd = React.useCallback(() => {
if (onAddClick) {
onAddClick();
} else {
setIsAddOpen(true);
}
}, [onAddClick]);
const handleSelect = React.useCallback(
(id: string) => {
setSelected(id);
onItemSelect?.();
},
[onItemSelect, setSelected],
);
const handleUpdateToLatest = React.useCallback(
async (id: string) => {
const entry = entries.find((e) => e.id === id);
if (!entry) return;
const info = registryInfo[entry.spec];
if (!info || info.kind !== 'npm-ok' || !info.hasUpdate || !info.latestVersion) {
return;
}
const latest = info.latestVersion;
const result = await updateToLatest(id);
if (result.ok) {
toast.success(
t('settings.plugins.toast.updatedToLatest', { version: latest }),
);
} else {
toast.error(t('settings.plugins.toast.refreshFailed'));
}
},
[entries, registryInfo, t, updateToLatest],
);
const handleRefresh = React.useCallback(async () => {
toast.info(t('settings.plugins.toast.refreshing'));
try {
await loadRegistryInfo({ force: true });
} catch {
toast.error(t('settings.plugins.toast.refreshFailed'));
}
}, [loadRegistryInfo, t]);
const handleDelete = React.useCallback(async () => {
if (!deleteTarget) return;
setIsDeleting(true);
const result =
deleteTarget.kind === 'entry'
? await deleteEntry(deleteTarget.id)
: await deleteFile(deleteTarget.id);
if (result.ok) {
toast.success(
result.message ||
t('settings.plugins.sidebar.toast.deleted', { name: deleteTarget.label }),
);
} else {
toast.error(t('settings.plugins.sidebar.toast.deleteFailed'));
}
setDeleteTarget(null);
setIsDeleting(false);
}, [deleteEntry, deleteFile, deleteTarget, t]);
const renderEntry = (entry: PluginEntry) => {
const info = registryInfo[entry.spec];
const canUpdate =
info?.kind === 'npm-ok' && info.hasUpdate && !!info.latestVersion;
const actions: Array<{
label: string;
icon?: IconName;
destructive?: boolean;
onClick: () => void;
}> = [];
if (canUpdate) {
actions.push({
label: t('settings.plugins.sidebar.actions.updateToLatest'),
icon: 'arrow-up-s',
onClick: () => void handleUpdateToLatest(entry.id),
});
}
actions.push({
label: t('settings.common.actions.delete'),
icon: 'delete-bin',
destructive: true,
onClick: () =>
setDeleteTarget({ kind: 'entry', id: entry.id, label: entry.spec }),
});
return (
<SettingsSidebarItem
key={entry.id}
title={
<span className="flex min-w-0 items-center gap-1.5">
<span className="min-w-0 flex-1 truncate">{entry.spec}</span>
<RegistryBadge spec={entry.spec} />
</span>
}
metadata={
entry.parsedKind === 'npm'
? t('settings.plugins.sidebar.kind.npm')
: t('settings.plugins.sidebar.kind.path')
}
selected={selectedId === entry.id}
onSelect={() => handleSelect(entry.id)}
icon={
<Icon
name={entryIcon(entry)}
className="h-4 w-4 flex-shrink-0 text-muted-foreground/70"
/>
}
actions={actions}
/>
);
};
const renderFile = (file: PluginFile) => (
<SettingsSidebarItem
key={file.id}
title={file.fileName}
metadata={t('settings.plugins.sidebar.kind.file')}
selected={selectedId === file.id}
onSelect={() => handleSelect(file.id)}
icon={
<Icon
name="file-text"
className="h-4 w-4 flex-shrink-0 text-muted-foreground/70"
/>
}
actions={[
{
label: t('settings.common.actions.delete'),
icon: 'delete-bin',
destructive: true,
onClick: () =>
setDeleteTarget({ kind: 'file', id: file.id, label: file.fileName }),
},
]}
/>
);
const renderGroup = (
label: string,
children: React.ReactNode,
updateCount = 0,
) => (
<>
<div className="px-2 pb-1.5 pt-2 text-xs font-semibold uppercase tracking-wide text-muted-foreground">
{label}
{updateCount > 0 && (
<span className="ml-2 normal-case font-normal text-[var(--status-success)]">
{t(
updateCount === 1
? 'settings.plugins.sidebar.group.updatesAvailable_one'
: 'settings.plugins.sidebar.group.updatesAvailable_other',
{ count: updateCount },
)}
</span>
)}
</div>
{children}
</>
);
return (
<>
<SettingsSidebarLayout
variant="background"
header={
<div className="border-b px-3 pt-4 pb-3">
<div className="mb-3 flex items-center justify-between gap-3">
<h2 className={SETTINGS_PANEL_TITLE_CLASS}>
{t('settings.plugins.sidebar.title')}
</h2>
</div>
<div className="flex items-center justify-between gap-2">
<span className="typography-meta text-muted-foreground">
{t('settings.plugins.sidebar.total', { count: total })}
</span>
<div className="flex items-center gap-1">
<Button
type="button"
data-settings-item="plugins.create"
variant="ghost"
size="icon"
className="h-7 w-7 -my-1 text-muted-foreground"
onClick={() => void handleRefresh()}
disabled={isLoadingRegistry}
aria-label={t('settings.plugins.sidebar.actions.refresh')}
title={t('settings.plugins.sidebar.actions.refresh')}
>
<Icon
name="refresh"
className={
isLoadingRegistry ? 'size-4 animate-spin' : 'size-4'
}
/>
</Button>
<Button
type="button"
variant="ghost"
size="icon"
className="h-7 w-7 -my-1 text-muted-foreground"
onClick={handleAdd}
aria-label={t('settings.plugins.sidebar.actions.addTitle')}
title={t('settings.plugins.sidebar.actions.addTitle')}
>
<Icon name="add" className="size-4" />
</Button>
</div>
</div>
</div>
}
>
{isEmpty ? (
<div className="py-12 px-4 text-center text-muted-foreground">
<Icon name="plug" className="mx-auto mb-3 h-10 w-10 opacity-50" />
<p className="typography-ui-label font-medium">
{t('settings.plugins.sidebar.empty.title')}
</p>
<p className="typography-meta mt-1 opacity-75">
{t('settings.plugins.sidebar.empty.description')}
</p>
</div>
) : (
<>
{userEntries.length > 0 &&
renderGroup(
t('settings.plugins.sidebar.group.userEntries'),
userEntries.map(renderEntry),
updateCounts.userEntries,
)}
{userFiles.length > 0 &&
renderGroup(
t('settings.plugins.sidebar.group.userFiles'),
userFiles.map(renderFile),
)}
{projectEntries.length > 0 &&
renderGroup(
t('settings.plugins.sidebar.group.projectEntries'),
projectEntries.map(renderEntry),
updateCounts.projectEntries,
)}
{projectFiles.length > 0 &&
renderGroup(
t('settings.plugins.sidebar.group.projectFiles'),
projectFiles.map(renderFile),
)}
</>
)}
</SettingsSidebarLayout>
<AddPluginDialog open={isAddOpen} onOpenChange={setIsAddOpen} />
<Dialog
open={deleteTarget !== null}
onOpenChange={(open) => {
if (!open && !isDeleting) setDeleteTarget(null);
}}
>
<DialogContent className="max-w-md">
<DialogHeader>
<DialogTitle>
{t('settings.plugins.sidebar.deleteDialog.title')}
</DialogTitle>
<DialogDescription>
{t('settings.plugins.sidebar.deleteDialog.description', {
name: deleteTarget?.label ?? '',
})}
</DialogDescription>
</DialogHeader>
<DialogFooter>
<Button
size="sm"
variant="ghost"
onClick={() => setDeleteTarget(null)}
disabled={isDeleting}
>
{t('settings.common.actions.cancel')}
</Button>
<Button
size="sm"
variant="destructive"
onClick={handleDelete}
disabled={isDeleting}
>
{isDeleting
? t('settings.plugins.sidebar.actions.deleting')
: t('settings.common.actions.delete')}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
</>
);
};