Felipe GenéandBohdan Triapitsyn
a12b9be443
* feat(chat): render code comments as cards instead of fenced text * fix(vscode): route Add Comment to the active session editor panel * fix(chat): persist queued inline comments and tighten file-chip path matching * feat(vscode): comment on code from the editor * fix(chat): keep attached context in the message and broadcast comment removal * fix(vscode): hold every pending comment and gate both entry points on the workspace * fix(vscode): let only the owning surface decide its comment threads * fix(vscode): drop a comment removed while its delivery was still in flight * test(vscode): cover the in-flight comment removal guard * test(vscode): cover comment removal reaching every chat surface * fix(vscode): give up on a comment the chat never confirmed holding * fix(vscode): retract a comment everywhere before reporting it discarded * fix(chat): preserve queued comment cards * fix: preserve inline comment context across send paths * fix(chat): preserve command routing with context * fix(chat): keep unavailable actions on normal send path --------- Co-authored-by: Bohdan Triapitsyn <artmore@protonmail.com>
50 lines
1.8 KiB
TypeScript
50 lines
1.8 KiB
TypeScript
/**
|
|
* Comments the user dropped before their draft reached this webview's store.
|
|
*
|
|
* Delivery is asynchronous on both sides: the extension holds a payload for a
|
|
* panel that has not booted, and the handler that files the draft can wait
|
|
* seconds for a directory to resolve. A removal can arrive anywhere in that
|
|
* window, when there is no draft yet to remove. Recording it here lets the
|
|
* delayed delivery recognise a comment that is no longer wanted, instead of
|
|
* filing it as a chip the user already dropped and sending it with the next
|
|
* message.
|
|
*
|
|
* Bounded because it is a tombstone list, not state: ids are unique per comment,
|
|
* so entries are never revisited once their delivery window has passed.
|
|
*/
|
|
|
|
const REMEMBERED_REMOVALS = 50;
|
|
|
|
export function createRemovalTombstones(limit: number = REMEMBERED_REMOVALS) {
|
|
const ids = new Set<string>();
|
|
|
|
return {
|
|
/** Records a removal, evicting the oldest once the bound is reached. */
|
|
remember(draftId: string): void {
|
|
if (!draftId) return;
|
|
ids.add(draftId);
|
|
if (ids.size > limit) {
|
|
const oldest = ids.values().next();
|
|
if (!oldest.done) ids.delete(oldest.value);
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Whether this delivery should be dropped.
|
|
*
|
|
* Consumes the record: the window closes once the delayed delivery has
|
|
* been refused, and a later comment reusing the id would be unrelated.
|
|
*/
|
|
consume(draftId: string | undefined): boolean {
|
|
if (!draftId || !ids.has(draftId)) return false;
|
|
ids.delete(draftId);
|
|
return true;
|
|
},
|
|
|
|
/** Number of removals currently remembered. Exposed for tests. */
|
|
size(): number {
|
|
return ids.size;
|
|
},
|
|
};
|
|
}
|