Tom RochetteandBohdan Triapitsyn
1505274f94
* perf(stores): defer safeStorage writes off the interaction path Session switches funnel every persisted store slice through safeStorage.setItem, and doing those large JSON.stringify writes synchronously blocked the main thread for over a second. Add a write-behind buffer that: - Defers each setItem/removeItem to a later task via setTimeout(0) so the click-to-paint path is not blocked. - Coalesces repeated writes to the same key into a single backing flush. - Serves pending values from memory so read-after-write stays consistent within the deferral window. - Flushes synchronously on pagehide/beforeunload/visibilitychange/freeze so deferred state survives tab close, reload, and the mobile freeze lifecycle. Adds a test covering write deferral, coalescing, and pending read serving. * fix(stores): defer persisted JSON serialization * fix(stores): defer direct safeStorage writes --------- Co-authored-by: Bohdan Triapitsyn <artmore@protonmail.com>
81 lines
2.6 KiB
TypeScript
81 lines
2.6 KiB
TypeScript
import { beforeEach, describe, expect, mock, test } from 'bun:test';
|
|
|
|
const storage = new Map<string, string>();
|
|
let storageSetCount = 0;
|
|
|
|
const safeStorage = {
|
|
getItem: (key: string) => storage.get(key) ?? null,
|
|
setItem: (key: string, value: string) => {
|
|
storageSetCount += 1;
|
|
storage.set(key, value);
|
|
},
|
|
removeItem: (key: string) => {
|
|
storage.delete(key);
|
|
},
|
|
clear: () => {
|
|
storage.clear();
|
|
},
|
|
key: (index: number) => Array.from(storage.keys())[index] ?? null,
|
|
get length() {
|
|
return storage.size;
|
|
},
|
|
} as Storage;
|
|
|
|
mock.module('./utils/safeStorage', () => ({
|
|
getDeferredSafeStorage: () => safeStorage,
|
|
getSafeStorage: () => safeStorage,
|
|
}));
|
|
|
|
mock.module('@/lib/desktop', () => ({
|
|
isVSCodeRuntime: () => false,
|
|
}));
|
|
|
|
mock.module('@/lib/runtime-fetch', () => ({
|
|
runtimeFetch: mock(async () => new Response('{}', { headers: { 'Content-Type': 'application/json' } })),
|
|
}));
|
|
|
|
const { useSessionFoldersStore } = await import('./useSessionFoldersStore');
|
|
|
|
const waitForPersist = () => new Promise((resolve) => setTimeout(resolve, 350));
|
|
|
|
describe('useSessionFoldersStore folder assignments', () => {
|
|
beforeEach(() => {
|
|
storage.clear();
|
|
storageSetCount = 0;
|
|
useSessionFoldersStore.setState({
|
|
foldersMap: {},
|
|
collapsedFolderIds: new Set<string>(),
|
|
});
|
|
});
|
|
|
|
test('repeated addSessionToFolder to the same folder preserves foldersMap reference', async () => {
|
|
const store = useSessionFoldersStore.getState();
|
|
const folder = store.createFolder('/workspace/project', 'Work');
|
|
store.addSessionToFolder('/workspace/project', folder.id, 'ses_1');
|
|
await waitForPersist();
|
|
storageSetCount = 0;
|
|
|
|
const before = useSessionFoldersStore.getState().foldersMap;
|
|
useSessionFoldersStore.getState().addSessionToFolder('/workspace/project', folder.id, 'ses_1');
|
|
await waitForPersist();
|
|
|
|
expect(useSessionFoldersStore.getState().foldersMap).toBe(before);
|
|
expect(storageSetCount).toBe(0);
|
|
});
|
|
|
|
test('repeated addSessionsToFolder to the same folder preserves foldersMap reference', async () => {
|
|
const store = useSessionFoldersStore.getState();
|
|
const folder = store.createFolder('/workspace/project', 'Batch');
|
|
store.addSessionsToFolder('/workspace/project', folder.id, ['ses_1', 'ses_2']);
|
|
await waitForPersist();
|
|
storageSetCount = 0;
|
|
|
|
const before = useSessionFoldersStore.getState().foldersMap;
|
|
useSessionFoldersStore.getState().addSessionsToFolder('/workspace/project', folder.id, ['ses_1', 'ses_2']);
|
|
await waitForPersist();
|
|
|
|
expect(useSessionFoldersStore.getState().foldersMap).toBe(before);
|
|
expect(storageSetCount).toBe(0);
|
|
});
|
|
});
|