Iuliia Ivashko
dc100ed0da
## Summary Fixes #736 — OpenChamber listens on `0.0.0.0` (all interfaces) by default, exposing the server to the network without warning. The log output shows `visit: http://127.0.0.1:...` which is misleading. ## Changes - **Default bind address changed to `127.0.0.1`** — server is only accessible locally unless explicitly configured otherwise - **New `--host` CLI flag** — `openchamber --host 0.0.0.0 -p 8080` to listen on all interfaces - **`OPENCHAMBER_HOST` env var** — documented in help text and docker-compose.yml as an alternative to `--host` - **Docker entrypoint** defaults to `OPENCHAMBER_HOST=0.0.0.0` so container port mapping continues to work - **Startup logs** show the actual bind address instead of hardcoded `localhost` ### Resolution priority ``` --host flag > OPENCHAMBER_HOST env var > 127.0.0.1 (default) ``` ### What doesn't break - **Desktop app** — already forces `OPENCHAMBER_HOST=127.0.0.1` via Tauri - **VS Code extension** — doesn't use the web server - **Docker** — entrypoint sets `OPENCHAMBER_HOST=0.0.0.0`, preserving current behavior - **Tunnels** — cloudflared connects to `127.0.0.1` origin internally, works regardless of bind address ## Testing Automated: - `bun run type-check` / `bun run lint` — pass Manual (CLI, direct `node` execution): - Default bind → `127.0.0.1` (verified via `lsof`/netstat) - `--host 0.0.0.0` → binds all interfaces - `--host=0.0.0.0` (inline) → works - `--host` without value → error exit 2 - `OPENCHAMBER_HOST` env var → respected - `--host` flag overrides env var - IPv6 `::1` → correct bracketed URL, health check 200 - CLI daemon start/stop → works - `visit:` URL → correct - Help text → `--host` in OPTIONS, `OPENCHAMBER_HOST` in ENVIRONMENT - Browser UI → loads and works - Tunnel via UI → works - Desktop app → no regression Docker (tested on Ubuntu with native Docker): - SSH key generated successfully - `OpenChamber server listening on 0.0.0.0:3000` - Health check 200 - `uid=1000(openchamber)` confirmed
40 lines
1.1 KiB
TypeScript
40 lines
1.1 KiB
TypeScript
import type { Express } from "express";
|
|
import type { Server } from "http";
|
|
|
|
export interface WebUiServerController {
|
|
expressApp: Express;
|
|
httpServer: Server;
|
|
getPort: () => number | null;
|
|
getOpenCodePort: () => number | null;
|
|
isReady: () => boolean;
|
|
restartOpenCode: () => Promise<void>;
|
|
stop: (options?: { exitProcess?: boolean }) => Promise<void>;
|
|
}
|
|
|
|
export interface StartWebUiServerOptions {
|
|
port?: number;
|
|
host?: string;
|
|
attachSignals?: boolean;
|
|
exitOnShutdown?: boolean;
|
|
uiPassword?: string | null;
|
|
}
|
|
|
|
export declare function startWebUiServer(
|
|
options?: StartWebUiServerOptions
|
|
): Promise<WebUiServerController>;
|
|
|
|
export declare function gracefulShutdown(options?: { exitProcess?: boolean }): Promise<void>;
|
|
export declare function setupProxy(app: Express): void;
|
|
export declare function restartOpenCode(): Promise<void>;
|
|
export declare function parseArgs(argv?: string[]): {
|
|
port: number;
|
|
host?: string;
|
|
uiPassword: string | null;
|
|
tryCfTunnel: boolean;
|
|
tunnelProvider?: string;
|
|
tunnelMode?: string;
|
|
tunnelConfigPath?: string | null;
|
|
tunnelToken?: string;
|
|
tunnelHostname?: string;
|
|
};
|