Bohdan Triapitsyn
a5aa32446d
The preview panel worked by proxying a dev server through OpenChamber's own origin and rewriting the HTML that came back. Anything the rewriter did not anticipate broke, and pages that refuse to be embedded never loaded at all. This deletes the proxy (-1604 lines and its tests) and merges the preview and browser panels into one surface backed by a real Chromium view. What the panel is now - A `<webview>` in its own session partition: logins and cookies persist, hot reload works because nothing is rewritten, DevTools are one click away. - Annotation: pick one element, drag a region, or draw freehand, write a note, and it reaches chat with a screenshot of the visible page with the marks on it. - Toolbar: hard reload, page zoom, device sizes, a light/dark switch that applies to the page rather than the app, and cookie/cache clearing scoped to the panel alone. - Several pages at once, each tab showing the page's own favicon, and an address bar that suggests pages already visited in this project. - Dev servers are listed from what is actually listening on the machine, checked against what a project announced, so a server is offered no matter how it was started. One that is still starting is waited for instead of failing. Remote dev servers The desktop app binds a local port and pipes raw bytes to the OpenChamber host over the existing authenticated connection, so the page keeps its own origin at the root of its own host. The reachable set is exactly what discovery reports and is re-checked per connection, so an authenticated client cannot dial arbitrary local services on the host. Links and redirects to another loopback port stay on the machine that served the page. A tunnel that cannot be opened is reported; it is never replaced by the plain loopback URL, which would answer from the user's own machine under a remote address. Agent control Browser actions are a separate `openchamber_web` tool: open, snapshot, click, type, scroll, inspect computed styles, resize between mobile/tablet/desktop, and capture a screenshot into `.openchamber/screenshots/` in the project. The existing `openchamber` tool keeps sessions, worktrees and scheduled tasks. Each has its own setting in the new Settings -> General -> OpenChamber Tools section, and the plugin is not injected at all when both are off. Capability belongs to the connected client, not to configuration: a client declares on its event stream that it can drive a page, which only a Chromium host does. Exactly one client performs each request — it claims the request before acting, and the first claim wins — because deciding by whose result arrives first would be too late for a click that already happened. No client listening is answered immediately with an explanation rather than a timeout. Runtime boundaries Web tabs get a plain iframe that can display a page but not inspect one. The VS Code extension no longer offers the surface at all, since nothing that makes the panel worth having works there. Mobile is unaffected. Native boundary Camera, microphone, location and device-picker requests from panel pages are denied — Electron grants them by default when no handler is set, and the panel loads whatever address the user types. Page capture, appearance emulation and storage clearing verify that their target belongs to the panel's own session instead of trusting a web-contents id from the renderer. Persisted state Stored `preview` tabs migrate to `browser` (v13 -> v14). Context panel tab limits are now per surface, so filling one surface no longer evicts another's tabs. Address history is stored per project and per runtime. Documentation `preview.mdx` and `desktop-browser.mdx` rewritten across all locales, the agent tool settings path corrected, new `DOCUMENTATION.md` for the browser-control broker and the dev tunnel, and the `ui-api-decoupling` skill updated where it still described the deleted proxy.
71 lines
2.6 KiB
TypeScript
71 lines
2.6 KiB
TypeScript
import { describe, expect, test } from 'bun:test';
|
|
|
|
import {
|
|
buildClickScript,
|
|
buildInspectScript,
|
|
buildScrollScript,
|
|
buildSnapshotScript,
|
|
buildTypeScript,
|
|
} from './pageActions';
|
|
|
|
/**
|
|
* These scripts are source text evaluated inside another page: nothing
|
|
* type-checks them, and a value interpolated without escaping either breaks the
|
|
* script or runs as code.
|
|
*/
|
|
const parses = (source: string): boolean => {
|
|
try {
|
|
new Function(source);
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
};
|
|
|
|
describe('page action scripts', () => {
|
|
test('every script parses', () => {
|
|
expect(parses(buildSnapshotScript())).toBe(true);
|
|
expect(parses(buildSnapshotScript({ selector: '#main' }))).toBe(true);
|
|
expect(parses(buildClickScript({ selector: '#save' }))).toBe(true);
|
|
expect(parses(buildClickScript({ text: 'Save' }))).toBe(true);
|
|
expect(parses(buildTypeScript({ selector: '#q', value: 'hello', submit: true }))).toBe(true);
|
|
expect(parses(buildInspectScript({ selector: '#save' }))).toBe(true);
|
|
expect(parses(buildScrollScript({ direction: 'bottom' }))).toBe(true);
|
|
expect(parses(buildScrollScript({ selector: 'footer' }))).toBe(true);
|
|
});
|
|
|
|
test('a hostile selector is embedded as data, not as code', () => {
|
|
const hostile = `'); window.__owned = true; ('`;
|
|
const script = buildClickScript({ selector: hostile });
|
|
expect(parses(script)).toBe(true);
|
|
// Present only inside a quoted literal: that is what makes it inert.
|
|
expect(script).toContain(JSON.stringify(hostile));
|
|
});
|
|
|
|
test('a typed value is embedded as data too', () => {
|
|
const value = '"); alert(1); ("';
|
|
const script = buildTypeScript({ selector: '#q', value, submit: false });
|
|
expect(parses(script)).toBe(true);
|
|
expect(script).toContain(JSON.stringify(value));
|
|
});
|
|
|
|
test('whitespace regexes survive interpolation', () => {
|
|
// A doubled backslash here would produce a literal backslash-s and match
|
|
// nothing, silently collapsing no whitespace at all.
|
|
expect(buildSnapshotScript()).toContain('replace(/\\s+/g');
|
|
});
|
|
|
|
test('scrolling asks for instant behaviour, not the page preference', () => {
|
|
// A page with scroll-behavior: smooth would otherwise still be animating
|
|
// when the position is read.
|
|
expect(buildScrollScript({ direction: 'bottom' })).toContain("behavior: 'instant'");
|
|
expect(buildScrollScript({ selector: 'footer' })).toContain("behavior: 'instant'");
|
|
});
|
|
|
|
test('a scoped snapshot reads only the subtree it was given', () => {
|
|
const script = buildSnapshotScript({ selector: '#changelog' });
|
|
expect(script).toContain('"#changelog"');
|
|
expect(script).toContain('root.querySelectorAll');
|
|
});
|
|
});
|