Files
openchamber/packages/web/server/lib/terminal/runtime.test.js
T
644050824e fix(terminal): reject file cwd values (#1204)
* fix(terminal): reject file cwd values

* test(terminal): remove stale cwd access mock

---------

Co-authored-by: Isaac Sanchez <isanchez-hawkins@arize.com>
Co-authored-by: Bohdan Triapitsyn <artmore@protonmail.com>
2026-05-12 11:30:10 +03:00

97 lines
2.4 KiB
JavaScript

import { EventEmitter } from 'node:events';
import fs from 'node:fs';
import path from 'node:path';
import { describe, expect, it } from 'vitest';
import { createTerminalRuntime } from './runtime.js';
function createResponse() {
return {
statusCode: 200,
body: null,
status(code) {
this.statusCode = code;
return this;
},
json(payload) {
this.body = payload;
return this;
},
};
}
function createRuntime(server, overrides = {}) {
const app = overrides.app ?? {
post() {},
get() {},
delete() {},
};
return createTerminalRuntime({
app,
server,
express: { text: () => (_req, _res, next) => next?.() },
fs,
path,
uiAuthController: null,
buildAugmentedPath: () => process.env.PATH || '',
searchPathFor: () => null,
isExecutable: () => false,
isRequestOriginAllowed: async () => true,
rejectWebSocketUpgrade() {},
TERMINAL_INPUT_WS_HEARTBEAT_INTERVAL_MS: 30_000,
TERMINAL_INPUT_WS_REBIND_WINDOW_MS: 1_000,
TERMINAL_INPUT_WS_MAX_REBINDS_PER_WINDOW: 3,
...overrides,
});
}
describe('terminal runtime', () => {
it('rejects regular files as terminal working directories', async () => {
const postRoutes = new Map();
const app = {
post(route, ...handlers) {
postRoutes.set(route, handlers.at(-1));
},
get() {},
delete() {},
};
const server = new EventEmitter();
const runtime = createRuntime(server, {
app,
fs: {
promises: {
stat: async () => ({ isDirectory: () => false }),
},
},
uiAuthController: { enabled: false },
buildAugmentedPath: () => '',
TERMINAL_INPUT_WS_HEARTBEAT_INTERVAL_MS: 1000,
TERMINAL_INPUT_WS_REBIND_WINDOW_MS: 1000,
});
try {
const createRoute = postRoutes.get('/api/terminal/create');
const res = createResponse();
await createRoute({ body: { cwd: '/tmp/not-a-directory' } }, res);
expect(res.statusCode).toBe(400);
expect(res.body).toEqual({ error: 'Invalid working directory' });
} finally {
await runtime.shutdown();
}
});
it('removes its websocket upgrade listener on shutdown', async () => {
const server = new EventEmitter();
const runtime = createRuntime(server);
expect(server.listenerCount('upgrade')).toBe(1);
await runtime.shutdown();
expect(server.listenerCount('upgrade')).toBe(0);
});
});