Files
openchamber/packages/ui/src/stores/useAutoReviewStore.ts
T
Tom RochetteandBohdan Triapitsyn 1505274f94 perf(stores): defer safeStorage writes off the interaction path (#1941)
* perf(stores): defer safeStorage writes off the interaction path

Session switches funnel every persisted store slice through safeStorage.setItem,
and doing those large JSON.stringify writes synchronously blocked the main
thread for over a second. Add a write-behind buffer that:

- Defers each setItem/removeItem to a later task via setTimeout(0) so the
  click-to-paint path is not blocked.
- Coalesces repeated writes to the same key into a single backing flush.
- Serves pending values from memory so read-after-write stays consistent
  within the deferral window.
- Flushes synchronously on pagehide/beforeunload/visibilitychange/freeze so
  deferred state survives tab close, reload, and the mobile freeze lifecycle.

Adds a test covering write deferral, coalescing, and pending read serving.

* fix(stores): defer persisted JSON serialization

* fix(stores): defer direct safeStorage writes

---------

Co-authored-by: Bohdan Triapitsyn <artmore@protonmail.com>
2026-06-30 11:47:52 +03:00

96 lines
3.3 KiB
TypeScript

import { create } from 'zustand';
import { persist } from 'zustand/middleware';
import { createDeferredSafeJSONStorage } from '@/stores/utils/safeStorage';
type AutoReviewPhase = 'waiting_for_reviewer' | 'waiting_for_implementer';
type AutoReviewStatus = 'running' | 'completed' | 'stopped' | 'error';
export type AutoReviewRun = {
originalSessionID: string;
reviewSessionID: string;
directory: string;
runtimeKey: string;
status: AutoReviewStatus;
phase: AutoReviewPhase;
iteration: number;
maxIterations: number;
lastForwardedMessageID?: string;
expectedAssistantParentID?: string;
waitAfterCreatedAt?: number;
error?: string;
};
type AutoReviewState = {
runsByOriginalSessionID: Record<string, AutoReviewRun>;
upsertRun: (run: AutoReviewRun) => void;
updateRun: (originalSessionID: string, updater: (run: AutoReviewRun) => AutoReviewRun) => void;
stopRun: (originalSessionID: string) => void;
completeRun: (originalSessionID: string) => void;
stopRunningRunsForRuntime: (runtimeKey: string) => void;
isRunningForSession: (sessionID: string) => boolean;
};
export const useAutoReviewStore = create<AutoReviewState>()(
persist(
(set, get) => ({
runsByOriginalSessionID: {},
upsertRun: (run) => set((state) => ({
runsByOriginalSessionID: {
...state.runsByOriginalSessionID,
[run.originalSessionID]: run,
},
})),
updateRun: (originalSessionID, updater) => set((state) => {
const current = state.runsByOriginalSessionID[originalSessionID];
if (!current) return state;
return {
runsByOriginalSessionID: {
...state.runsByOriginalSessionID,
[originalSessionID]: updater(current),
},
};
}),
stopRun: (originalSessionID) => set((state) => {
const current = state.runsByOriginalSessionID[originalSessionID];
if (!current) return state;
return {
runsByOriginalSessionID: {
...state.runsByOriginalSessionID,
[originalSessionID]: { ...current, status: 'stopped' },
},
};
}),
completeRun: (originalSessionID) => set((state) => {
const current = state.runsByOriginalSessionID[originalSessionID];
if (!current) return state;
return {
runsByOriginalSessionID: {
...state.runsByOriginalSessionID,
[originalSessionID]: { ...current, status: 'completed' },
},
};
}),
stopRunningRunsForRuntime: (runtimeKey) => set((state) => {
let changed = false;
const next = { ...state.runsByOriginalSessionID };
for (const [sessionID, run] of Object.entries(next)) {
if (run.runtimeKey === runtimeKey && run.status === 'running') {
next[sessionID] = { ...run, status: 'stopped' };
changed = true;
}
}
return changed ? { runsByOriginalSessionID: next } : state;
}),
isRunningForSession: (sessionID) => {
const run = get().runsByOriginalSessionID[sessionID];
return run?.status === 'running';
},
}),
{
name: 'auto-review-store',
storage: createDeferredSafeJSONStorage(),
partialize: (state) => ({ runsByOriginalSessionID: state.runsByOriginalSessionID }),
},
),
);