Files
openchamber/packages/web/server/lib/gitea/client.js
T
bot-hermes 9032c9245a fix: forge CLI pivot bugs against real tea/glab binaries
Fix critical bugs in the CLI transport layer that were masked by
idealized unit test mocks. All fixes verified against live binaries.

Server (gitea/client.js):
- C1: Remove --paginate flag (tea rejects it with exit 1)
- C2: Pass auth via -H 'Authorization: token' header instead of
  GITEA_SERVER_TOKEN env (tea ignores that env var)
- C3: Parse --include output from stderr (tea writes headers to
  stderr, not stdout)
- H2: Parse Link header for hasMore/pagination

Server (gitlab/client.js):
- C4: Remove /api/v4 prefix (glab adds it automatically; double
  prefix caused every call to 404)
- H2: Parse Link header for hasMore/pagination

Tests (both client.test.js):
- H1: Rewrite mocks to match real CLI behavior: headers on stderr
  for tea, no --paginate, auth via -H header, Link header parsing
- Add C3, C1, C4 specific regression tests

UI (GiteaSettings, GitLabSettings):
- U4: Replace return null loading state with animated skeleton
  (prevents blank flash)
- U2: Surface actual error message in connect failure toast
- U5: Add CLI transport hint below connect form
- U6 (GitLab): Add transport hint for unconnected state

UI (GiteaIssuePickerDialog, GitLabIssuePickerDialog):
- U3: Add retry button when error state is displayed

Live smoke tests passed:
- tea api -H 'Authorization: token WRONG' /user → 401
- tea api /repos/Vibing/openchamber/issues?state=open&limit=2 → 200
- glab api user with GITLAB_TOKEN=dummy → 401 (not 404)
2026-09-05 20:26:35 +00:00

266 lines
11 KiB
JavaScript

import { spawn } from 'child_process';
import { getGiteaAuth } from './auth.js';
import { getProviderApiBaseUrl } from '../git-providers/config.js';
import { getEffectiveProviderApiBaseUrl } from '../git-providers/project-config.js';
const REQUEST_TIMEOUT_MS = 8000;
// NOTE: ETag conditional-GET cache and rate-limit cooldown have been dropped
// with the pivot to CLI transports. Each call spawns a fresh `tea` process,
// so there is no persistent connection to attach conditional headers to, and
// rate-limit state cannot be shared across invocations. The tradeoff is higher
// latency per call (process spawn overhead) and no 304 short-circuit, but
// simpler state management and no module-level mutable cache. Callers that
// relied on `isGiteaRateLimited()` will always see false (no cooldown active).
/**
* Spawn a CLI binary and return { stdout, stderr, exitCode }.
* Rejects if the process does not finish within REQUEST_TIMEOUT_MS.
*/
function spawnCli(bin, args, env, timeoutMs = REQUEST_TIMEOUT_MS) {
return new Promise((resolve, reject) => {
const child = spawn(bin, args, {
env: { ...process.env, ...env },
stdio: ['ignore', 'pipe', 'pipe'],
});
let stdout = '';
let stderr = '';
child.stdout.on('data', (chunk) => { stdout += chunk; });
child.stderr.on('data', (chunk) => { stderr += chunk; });
const timer = setTimeout(() => {
child.kill('SIGKILL');
reject(new Error(`CLI ${bin} timed out after ${timeoutMs}ms`));
}, timeoutMs);
child.on('close', (code) => {
clearTimeout(timer);
resolve({ stdout, stderr, exitCode: code ?? 1 });
});
child.on('error', (err) => {
clearTimeout(timer);
reject(err);
});
});
}
/**
* Parse the `Link` header value to extract rel="next" and rel="prev" URLs.
* Returns { next, prev } with the raw URL strings (or null).
*/
function parseLinkHeader(linkHeader) {
if (!linkHeader) return { next: null, prev: null };
const result = { next: null, prev: null };
const parts = linkHeader.split(',');
for (const part of parts) {
const match = part.match(/<([^>]+)>;\s*rel="(\w+)"/);
if (match) {
const [, url, rel] = match;
if (rel === 'next') result.next = url;
if (rel === 'prev') result.prev = url;
}
}
return result;
}
/**
* Run a `tea api` call and parse the response envelope.
*
* tea's `--include` flag writes HTTP status and response headers to **stderr**
* and the response body to **stdout**. The client reads both streams:
*
* stderr: HTTP/2.0 200 OK\nHeader: value\n...\n\n
* stdout: {"json": "body"}
*
* Auth is passed via `-H "Authorization: token <token>"` — the
* `GITEA_SERVER_TOKEN` env var is ignored by tea (it uses its own config).
*
* Pagination: `--paginate` does NOT exist in tea. We parse the `Link` header
* from stderr to derive `page` and `hasMore`.
*/
async function teaApiCall(endpoint, { method = 'GET', body, raw, teaBin, token }) {
const args = ['api', '--include'];
if (method !== 'GET') args.push('-X', method);
if (raw) args.push('--header', 'Accept: text/plain');
if (body !== undefined) args.push('--header', 'Content-Type: application/json', '-d', JSON.stringify(body));
// Pass auth via header (C2 fix) — tea ignores GITEA_SERVER_TOKEN env.
if (token) args.push('-H', `Authorization: token ${token}`);
args.push(endpoint);
let result;
try {
result = await spawnCli(teaBin, args, {});
} catch (err) {
return { status: 500, headers: {}, data: null, page: null, error: err.message };
}
const { stdout, stderr } = result;
// Parse --include output from stderr: status line, headers, blank line.
// stdout contains only the response body.
let status = 200;
const headers = {};
const stderrLines = stderr.split('\n');
const statusMatch = stderrLines[0]?.match(/HTTP\/\S+\s+(\d+)/);
if (statusMatch) {
status = Number(statusMatch[1]);
for (let i = 1; i < stderrLines.length; i++) {
if (stderrLines[i].trim() === '') break;
const colonIdx = stderrLines[i].indexOf(':');
if (colonIdx > 0) {
headers[stderrLines[i].slice(0, colonIdx).trim().toLowerCase()] = stderrLines[i].slice(colonIdx + 1).trim();
}
}
} else if (stderr.trim() && !stdout.trim()) {
// No --include output on stderr and no body — surface the stderr message.
return { status: 500, headers: {}, data: null, page: null, error: stderr.trim() };
}
const bodyText = stdout.trim();
if (!bodyText) {
return { status, headers, data: null, page: null };
}
if (raw) {
return { status, headers, data: bodyText, page: null };
}
let data;
try {
data = JSON.parse(bodyText);
} catch {
data = bodyText;
}
// Derive pagination from the Link header (H2 fix).
const { next } = parseLinkHeader(headers.link);
const listIsArray = Array.isArray(data);
const hasMore = listIsArray ? next !== null : false;
// page is the caller's current page (extracted from the request context by the
// caller); for the client layer we return the page number derived from the
// Link header's "next" URL if present, otherwise 1.
let page = 1;
if (next) {
const pageMatch = next.match(/[?&]page=(\d+)/);
if (pageMatch) {
// next page exists — the *current* page is next - 1 (rough heuristic;
// callers that know the page can override).
page = Math.max(1, Number(pageMatch[1]) - 1);
}
}
return { status, headers, data, page: listIsArray ? page : null, hasMore: listIsArray ? hasMore : undefined };
}
// ---- Rate-limit helpers (no-ops with CLI transport) ----
export function noteGiteaRateLimit() { /* no-op: CLI processes are stateless */ }
export function isGiteaRateLimited() { return false; }
// ---- Response helpers ----
// Build the relative API path for tea CLI. tea resolves the base URL from its
// own login config, so we pass only the /api/v1/... portion.
const apiPath = (path) => {
const p = typeof path === 'string' && path ? (path.startsWith('/') ? path : `/${path}`) : '';
return `/api/v1${p}`;
};
/**
* Create a CLI-backed Gitea/Forgejo REST v1 client. Spawns `tea api` for each
* request. `request` never throws for HTTP error statuses — it returns
* `{ status, headers, data, page, hasMore }` so callers can branch on status
* codes.
*/
export function createGiteaClient({ token, baseUrl }) {
const effectiveBaseUrl = typeof baseUrl === 'string' ? baseUrl.trim().replace(/\/+$/, '') : '';
const teaBin = process.env.TEA_BIN || '/home/user/.local/bin/tea';
const request = async (path, options = {}) => {
const method = (typeof options.method === 'string' ? options.method : 'GET').toUpperCase();
const query = options.query && typeof options.query === 'object' ? options.query : {};
const body = options.body;
const raw = options.raw === true;
// Build the relative endpoint path with query params baked in.
let endpoint = apiPath(path);
const qs = new URLSearchParams();
let hasQuery = false;
for (const [key, value] of Object.entries(query)) {
if (value === undefined || value === null || value === '') continue;
qs.set(key, String(value));
hasQuery = true;
}
if (hasQuery) {
endpoint += `${endpoint.includes('?') ? '&' : '?'}${qs.toString()}`;
}
return teaApiCall(endpoint, { method, body, raw, teaBin, token });
};
return {
request,
baseUrl: effectiveBaseUrl,
user: () => request('/user'),
repo: (owner, repo) => request(`/repos/${owner}/${repo}`),
issues: (owner, repo, params = {}) =>
request(`/repos/${owner}/${repo}/issues`, { query: params }),
issue: (owner, repo, number) =>
request(`/repos/${owner}/${repo}/issues/${number}`),
issueComments: (owner, repo, number, params = {}) =>
request(`/repos/${owner}/${repo}/issues/${number}/comments`, { query: params }),
createIssueComment: (owner, repo, number, body) =>
request(`/repos/${owner}/${repo}/issues/${number}/comments`, { method: 'POST', body: { body } }),
createIssue: (owner, repo, params) =>
request(`/repos/${owner}/${repo}/issues`, { method: 'POST', body: params }),
updateIssue: (owner, repo, number, params) =>
request(`/repos/${owner}/${repo}/issues/${number}`, { method: 'PATCH', body: params }),
milestones: (owner, repo, params = {}) =>
request(`/repos/${owner}/${repo}/milestones`, { query: params }),
repoLabels: (owner, repo, params = {}) =>
request(`/repos/${owner}/${repo}/labels`, { query: params }),
pullRequests: (owner, repo, params = {}) =>
request(`/repos/${owner}/${repo}/pulls`, { query: params }),
pullRequest: (owner, repo, number) =>
request(`/repos/${owner}/${repo}/pulls/${number}`),
pullRequestDiff: (owner, repo, number) =>
request(`/repos/${owner}/${repo}/pulls/${number}.diff`, { raw: true }),
pullRequestFiles: (owner, repo, number, params = {}) =>
request(`/repos/${owner}/${repo}/pulls/${number}/files`, { query: params }),
pullRequestCommits: (owner, repo, number, params = {}) =>
request(`/repos/${owner}/${repo}/pulls/${number}/commits`, { query: params }),
pullRequestReviews: (owner, repo, number, params = {}) =>
request(`/repos/${owner}/${repo}/pulls/${number}/reviews`, { query: params }),
createPullReview: (owner, repo, number, params) =>
request(`/repos/${owner}/${repo}/pulls/${number}/reviews`, { method: 'POST', body: params }),
commitStatuses: (owner, repo, sha, params = {}) =>
request(`/repos/${owner}/${repo}/commits/${sha}/statuses`, { query: params }),
createPullRequest: (owner, repo, body) =>
request(`/repos/${owner}/${repo}/pulls`, { method: 'POST', body }),
updatePullRequest: (owner, repo, number, body) =>
request(`/repos/${owner}/${repo}/pulls/${number}`, { method: 'PATCH', body }),
mergePullRequest: (owner, repo, number, body) =>
request(`/repos/${owner}/${repo}/pulls/${number}/merge`, { method: 'POST', body }),
branches: (owner, repo, params = {}) =>
request(`/repos/${owner}/${repo}/branches`, { query: params }),
assignees: (owner, repo, params = {}) =>
request(`/repos/${owner}/${repo}/assignees`, { query: params }),
tags: (owner, repo, params = {}) =>
request(`/repos/${owner}/${repo}/tags`, { query: params }),
};
}
/** Picks the current account (from auth.js) token + base URL, or null. A per-project override replaces the account's base URL for that project. */
export function getGiteaClientOrNull(directory) {
const auth = getGiteaAuth();
if (!auth?.accessToken || !auth?.baseUrl) {
return null;
}
let baseUrl = auth.baseUrl;
if (directory) {
const effectiveBaseUrl = getEffectiveProviderApiBaseUrl('gitea', directory);
if (effectiveBaseUrl !== null && effectiveBaseUrl !== getProviderApiBaseUrl('gitea')) {
baseUrl = effectiveBaseUrl;
}
}
return createGiteaClient({ token: auth.accessToken, baseUrl });
}