Files
openchamber/packages/web/server/lib/opencode/npm-registry.test.js
T
Quat3rnionandBohdan Triapitsyn 2b47d899c6 feat: plugin settings (#1375)
* feat(settings): add opencode plugins page

Manage opencode `plugin` array entries (npm, scoped npm, versioned,
local paths) and auto-loaded plugin files in `~/.config/opencode/plugins/`
and `<project>/.opencode/plugins/`. Mirrors MCP CRUD pattern.

- Server: `plugins.js` data layer + `plugin-routes.js` REST routes
- UI: PluginsSidebar / PluginsPage / AddPluginDialog
- Store: usePluginsStore (cache TTL, in-flight dedup, narrow selectors)
- i18n: 41 keys across 7 locales

Whitelist /api/config/plugins in JSON body-parser so POST/PATCH bodies
parse; opencode plugin specs runtime-resolve OPENCODE_CONFIG dir so
parallel test files do not cross-pollute module-frozen consts.

* feat(settings/plugins): hook npm registry for update + invalid-version detection

Plugins page now consults registry.npmjs.org with a 1h server cache. Sidebar
rows show an update badge with the latest version, group headers show how
many updates are available, the kebab adds an "Update to latest" action
that reuses the existing PATCH+restart flow, and the editor surfaces a
banner for update-available / missing-version / missing-package / malformed
/ missing-path / unreadable-path / offline-registry states. A refresh
button in the sidebar header forces a cache bypass.

- Server: `npm-registry.js` (cache + in-flight dedup + 5s timeout, 404
  cached, network failures NOT cached) + `plugin-spec.js` (parser + exact
  semver detection) + `GET /api/config/plugins/registry?specs=...&refresh=`
- Routes accept up to 100 specs/request, dedup by npm package name before
  fetching, classify each result by kind, never propagate network failure
  as 500.
- Client: `registryInfo` slice + `loadRegistryInfo` (fire-and-forget after
  loadPlugins, refreshes on mutations) + `updateToLatest(id)`.
- UI: `RegistryBadge` per-row + `RegistryBanner` per-entry editor, both
  use theme tokens (text-only color, no new bg/border tokens) and the
  shared Icon sprite. Per-spec subscriptions only.
- i18n: 24 new keys (incl. split singular/plural for "N update(s)
  available" because the runtime does not parse ICU plural format).

* fix(settings/plugins): keep registry badge visible for long specs

Sidebar entry row used `inline-flex` with `truncate` only on the spec
text. With long npm specs the badge could be pushed past the row edge
and clipped by the parent overflow. Switch to `flex` with spec
`flex-1 min-w-0 truncate` and add `shrink-0` to the badge wrapper so
the update indicator stays anchored to the right of the row.

* fix(settings/plugins): use code-box icon to distinguish from MCP

Plugins nav entry used 'plug' which is visually too close to MCP's
'plug-2' icon. Swap to 'code-box' for clearer differentiation in the
Settings nav list.

* Update packages/ui/src/components/sections/plugins/PluginsPage.tsx

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Quat3rnion <81202811+Quat3rnion@users.noreply.github.com>

* Update packages/ui/src/stores/usePluginsStore.ts

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Quat3rnion <81202811+Quat3rnion@users.noreply.github.com>

* fix(settings/plugins): validate registry directory + surface save errors

- registry endpoint: return 400 on invalid directory query (was silently falling back to homedir, breaking relative path specs)
- save failure toast: prefer result.message over generic 'Reload failed'

* fix(settings/plugins): address review follow-ups

---------

Signed-off-by: Quat3rnion <81202811+Quat3rnion@users.noreply.github.com>
Co-authored-by: Bohdan Triapitsyn <artmore@protonmail.com>
2026-05-25 19:20:04 +03:00

180 lines
5.3 KiB
JavaScript

import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test';
import * as npm from './npm-registry.js';
const originalFetch = globalThis.fetch;
const originalDateNow = Date.now;
let fetchMock;
function jsonResponse(body, status = 200) {
return Promise.resolve(new Response(JSON.stringify(body), {
status,
headers: { 'content-type': 'application/json' },
}));
}
describe('npm registry client', () => {
beforeEach(() => {
npm.clearCache();
Date.now = originalDateNow;
fetchMock = mock(() => jsonResponse({}));
globalThis.fetch = fetchMock;
});
afterEach(() => {
npm.clearCache();
globalThis.fetch = originalFetch;
Date.now = originalDateNow;
});
test('200 success returns latest versions and dist tags', async () => {
fetchMock.mockImplementation(() => jsonResponse({
'dist-tags': { latest: '1.2.0' },
versions: { '1.0.0': {}, '1.2.0': {} },
}));
const result = await npm.lookupNpmPackage('foo');
expect(result).toEqual({
ok: true,
latest: '1.2.0',
versions: ['1.0.0', '1.2.0'],
distTags: { latest: '1.2.0' },
});
});
test('200 success handles missing dist-tags and versions', async () => {
fetchMock.mockImplementation(() => jsonResponse({}));
const result = await npm.lookupNpmPackage('foo');
expect(result).toEqual({ ok: true, latest: null, versions: [], distTags: {} });
});
test('404 returns package not found', async () => {
fetchMock.mockImplementation(() => jsonResponse({}, 404));
const result = await npm.lookupNpmPackage('missing');
expect(result).toEqual({ ok: false, status: 404, error: 'Package not found' });
});
test('500 returns registry error', async () => {
fetchMock.mockImplementation(() => jsonResponse({}, 500));
const result = await npm.lookupNpmPackage('foo');
expect(result).toEqual({ ok: false, status: 500, error: 'Registry returned 500' });
});
test('network error returns network status', async () => {
fetchMock.mockImplementation(() => Promise.reject(new Error('socket closed')));
const result = await npm.lookupNpmPackage('foo');
expect(result.ok).toBe(false);
expect(result.status).toBe('network');
expect(result.error).toBe('socket closed');
});
test('timeout plumbs AbortSignal to fetch', async () => {
fetchMock.mockImplementation((_url, init) => {
expect(init.signal).toBeInstanceOf(AbortSignal);
return Promise.reject(new DOMException('The operation was aborted.', 'AbortError'));
});
const result = await npm.lookupNpmPackage('foo');
expect(result.ok).toBe(false);
expect(result.status).toBe('network');
expect(result.error).toContain('aborted');
});
test('cache hit reuses definitive success', async () => {
fetchMock.mockImplementation(() => jsonResponse({ 'dist-tags': { latest: '1.0.0' }, versions: { '1.0.0': {} } }));
const first = await npm.getNpmInfo('foo');
const second = await npm.getNpmInfo('foo');
expect(first).toEqual(second);
expect(fetchMock).toHaveBeenCalledTimes(1);
});
test('cache miss after ttl fetches again', async () => {
let now = 1_000;
Date.now = mock(() => now);
fetchMock.mockImplementation(() => jsonResponse({ versions: {} }));
await npm.getNpmInfo('foo');
now += 3_600_001;
await npm.getNpmInfo('foo');
expect(fetchMock).toHaveBeenCalledTimes(2);
});
test('forceRefresh bypasses cache', async () => {
fetchMock.mockImplementation(() => jsonResponse({ versions: {} }));
await npm.getNpmInfo('foo');
await npm.getNpmInfo('foo', { forceRefresh: true });
expect(fetchMock).toHaveBeenCalledTimes(2);
});
test('in-flight requests dedup by package name', async () => {
let release;
const wait = new Promise((resolve) => {
release = resolve;
});
fetchMock.mockImplementation(async () => {
await wait;
return new Response(JSON.stringify({ versions: { '1.0.0': {} } }), { status: 200 });
});
const requests = Promise.all([
npm.getNpmInfo('foo'),
npm.getNpmInfo('foo'),
npm.getNpmInfo('foo'),
]);
release();
const results = await requests;
expect(results.every((result) => result.ok)).toBe(true);
expect(fetchMock).toHaveBeenCalledTimes(1);
});
test('network failure is not cached', async () => {
fetchMock
.mockImplementationOnce(() => Promise.reject(new Error('down')))
.mockImplementationOnce(() => jsonResponse({ versions: {} }));
const first = await npm.getNpmInfo('foo');
const second = await npm.getNpmInfo('foo');
expect(first.status).toBe('network');
expect(second.ok).toBe(true);
expect(fetchMock).toHaveBeenCalledTimes(2);
});
test('404 is cached', async () => {
fetchMock.mockImplementation(() => jsonResponse({}, 404));
await npm.getNpmInfo('missing');
await npm.getNpmInfo('missing');
expect(fetchMock).toHaveBeenCalledTimes(1);
});
test('scoped names encode slash in registry url', async () => {
await npm.getNpmInfo('@scope/pkg');
expect(fetchMock.mock.calls[0][0]).toBe('https://registry.npmjs.org/@scope%2Fpkg');
});
test('user-agent header is present', async () => {
await npm.getNpmInfo('foo');
expect(fetchMock.mock.calls[0][1].headers['User-Agent']).toMatch(/^openchamber-server\//);
});
});