The preview panel worked by proxying a dev server through OpenChamber's own origin and rewriting the HTML that came back. Anything the rewriter did not anticipate broke, and pages that refuse to be embedded never loaded at all. This deletes the proxy (-1604 lines and its tests) and merges the preview and browser panels into one surface backed by a real Chromium view. What the panel is now - A `<webview>` in its own session partition: logins and cookies persist, hot reload works because nothing is rewritten, DevTools are one click away. - Annotation: pick one element, drag a region, or draw freehand, write a note, and it reaches chat with a screenshot of the visible page with the marks on it. - Toolbar: hard reload, page zoom, device sizes, a light/dark switch that applies to the page rather than the app, and cookie/cache clearing scoped to the panel alone. - Several pages at once, each tab showing the page's own favicon, and an address bar that suggests pages already visited in this project. - Dev servers are listed from what is actually listening on the machine, checked against what a project announced, so a server is offered no matter how it was started. One that is still starting is waited for instead of failing. Remote dev servers The desktop app binds a local port and pipes raw bytes to the OpenChamber host over the existing authenticated connection, so the page keeps its own origin at the root of its own host. The reachable set is exactly what discovery reports and is re-checked per connection, so an authenticated client cannot dial arbitrary local services on the host. Links and redirects to another loopback port stay on the machine that served the page. A tunnel that cannot be opened is reported; it is never replaced by the plain loopback URL, which would answer from the user's own machine under a remote address. Agent control Browser actions are a separate `openchamber_web` tool: open, snapshot, click, type, scroll, inspect computed styles, resize between mobile/tablet/desktop, and capture a screenshot into `.openchamber/screenshots/` in the project. The existing `openchamber` tool keeps sessions, worktrees and scheduled tasks. Each has its own setting in the new Settings -> General -> OpenChamber Tools section, and the plugin is not injected at all when both are off. Capability belongs to the connected client, not to configuration: a client declares on its event stream that it can drive a page, which only a Chromium host does. Exactly one client performs each request — it claims the request before acting, and the first claim wins — because deciding by whose result arrives first would be too late for a click that already happened. No client listening is answered immediately with an explanation rather than a timeout. Runtime boundaries Web tabs get a plain iframe that can display a page but not inspect one. The VS Code extension no longer offers the surface at all, since nothing that makes the panel worth having works there. Mobile is unaffected. Native boundary Camera, microphone, location and device-picker requests from panel pages are denied — Electron grants them by default when no handler is set, and the panel loads whatever address the user types. Page capture, appearance emulation and storage clearing verify that their target belongs to the panel's own session instead of trusting a web-contents id from the renderer. Persisted state Stored `preview` tabs migrate to `browser` (v13 -> v14). Context panel tab limits are now per surface, so filling one surface no longer evicts another's tabs. Address history is stored per project and per runtime. Documentation `preview.mdx` and `desktop-browser.mdx` rewritten across all locales, the agent tool settings path corrected, new `DOCUMENTATION.md` for the browser-control broker and the dev tunnel, and the `ui-api-decoupling` skill updated where it still described the deleted proxy.
144 lines
5.6 KiB
TypeScript
144 lines
5.6 KiB
TypeScript
import React from 'react';
|
|
|
|
import { Button } from '@/components/ui/button';
|
|
import { Icon } from '@/components/icon/Icon';
|
|
import { OpenChamberLogo } from '@/components/ui/OpenChamberLogo';
|
|
import { useI18n } from '@/lib/i18n';
|
|
import { fetchDevServers, mergeDevServerCandidates, type DevServerDiscovery } from '@/lib/browser/devServers';
|
|
import { clearAnnouncedDevServers, useAnnouncedDevServers } from '@/lib/browser/announcedServers';
|
|
import { browserUrlLabel, isLoopbackUrl } from '@/lib/browser/url';
|
|
import { getRuntimeApiBaseUrl } from '@/lib/runtime-switch';
|
|
|
|
/**
|
|
* What the panel shows before anything is loaded.
|
|
*
|
|
* Rather than an inert placeholder, this lists the servers actually running,
|
|
* which is almost always what the user came here to open. Discovery failure is
|
|
* stated plainly instead of being rendered as "nothing is running" — the two
|
|
* mean very different things to someone whose dev server is definitely up.
|
|
*/
|
|
|
|
/** The base path a server is served under, or '' when it sits at the root. */
|
|
const pathLabel = (url: string): string => {
|
|
try {
|
|
const path = new URL(url).pathname;
|
|
return path === '/' ? '' : path;
|
|
} catch {
|
|
return '';
|
|
}
|
|
};
|
|
|
|
/** Re-checked while the panel is open: a project's servers appear seconds apart. */
|
|
const REFRESH_INTERVAL_MS = 2_000;
|
|
|
|
/**
|
|
* True when the listed servers are on another machine and this client has no
|
|
* way to reach them. The desktop shell tunnels a local port for exactly this
|
|
* case; a browser tab has no equivalent, and its `localhost` is its own.
|
|
*/
|
|
const isUnreachableFromHere = (): boolean => {
|
|
if (typeof window === 'undefined') return false;
|
|
if (window.__OPENCHAMBER_ELECTRON__) return false;
|
|
const baseUrl = getRuntimeApiBaseUrl();
|
|
if (!baseUrl) return false;
|
|
try {
|
|
return !isLoopbackUrl(new URL(baseUrl, window.location.href).toString());
|
|
} catch {
|
|
return false;
|
|
}
|
|
};
|
|
|
|
export const BrowserEmptyState: React.FC<{
|
|
onOpen: (url: string) => void;
|
|
directory?: string;
|
|
}> = ({ onOpen, directory = '' }) => {
|
|
const { t } = useI18n();
|
|
const [discovery, setDiscovery] = React.useState<DevServerDiscovery>({ kind: 'loading' });
|
|
const announced = useAnnouncedDevServers(directory);
|
|
const [remoteOnly] = React.useState(isUnreachableFromHere);
|
|
|
|
React.useEffect(() => {
|
|
let active = true;
|
|
let timer: ReturnType<typeof setTimeout> | null = null;
|
|
const controller = new AbortController();
|
|
|
|
const poll = () => {
|
|
void fetchDevServers(controller.signal).then((result) => {
|
|
if (!active) return;
|
|
setDiscovery(result);
|
|
// One look is a snapshot of whichever servers happened to be up first.
|
|
timer = setTimeout(poll, REFRESH_INTERVAL_MS);
|
|
});
|
|
};
|
|
poll();
|
|
|
|
return () => {
|
|
active = false;
|
|
if (timer) clearTimeout(timer);
|
|
controller.abort();
|
|
};
|
|
}, []);
|
|
|
|
const candidates = React.useMemo(() => mergeDevServerCandidates({
|
|
announced,
|
|
discovered: discovery.kind === 'ready' ? discovery.servers : null,
|
|
}), [announced, discovery]);
|
|
|
|
return (
|
|
// The whole panel must not scroll: a centred column that overflows clips its
|
|
// own top, and no amount of scrolling reaches it. Only the list of servers
|
|
// scrolls, and it shrinks to whatever room is left before it does.
|
|
<div className="absolute inset-0 flex flex-col items-center justify-center gap-5 overflow-hidden bg-background p-6 text-center">
|
|
<OpenChamberLogo width={110} height={110} className="shrink-0 opacity-20" />
|
|
<div className="flex shrink-0 flex-col gap-1">
|
|
<span className="typography-ui-header text-foreground">{t('contextPanel.browser.empty')}</span>
|
|
<span className="typography-micro text-muted-foreground">{t('contextPanel.browser.emptyHint')}</span>
|
|
</div>
|
|
|
|
{candidates.length > 0 ? (
|
|
<div className="flex min-h-0 w-full max-w-sm flex-col gap-1">
|
|
<span className="shrink-0 typography-micro text-left text-muted-foreground">
|
|
{announced.length > 0
|
|
? t('contextPanel.browser.devServers.justStarted')
|
|
: t('contextPanel.browser.devServers.title')}
|
|
</span>
|
|
{remoteOnly ? (
|
|
<span className="shrink-0 pb-1 text-left typography-micro text-muted-foreground">
|
|
{t('contextPanel.browser.devServers.remoteOnly')}
|
|
</span>
|
|
) : null}
|
|
<div className="flex min-h-0 flex-col gap-1 overflow-y-auto pr-0.5">
|
|
{candidates.map((candidate) => (
|
|
<Button
|
|
key={candidate.port}
|
|
type="button"
|
|
variant="outline"
|
|
size="sm"
|
|
className="w-full shrink-0 justify-start gap-2"
|
|
onClick={() => {
|
|
// The offer is answered; leaving it up would keep suggesting
|
|
// servers behind a page the user is already looking at.
|
|
clearAnnouncedDevServers(directory);
|
|
onOpen(candidate.url);
|
|
}}
|
|
>
|
|
<Icon name="global" className="size-3.5 shrink-0" aria-hidden="true" />
|
|
<span className="truncate">{browserUrlLabel(candidate.url) || candidate.url}</span>
|
|
<span className="ml-auto truncate typography-micro text-muted-foreground">
|
|
{pathLabel(candidate.url)}
|
|
</span>
|
|
</Button>
|
|
))}
|
|
</div>
|
|
</div>
|
|
) : null}
|
|
|
|
{candidates.length === 0 && discovery.kind === 'unavailable' ? (
|
|
<span className="typography-micro text-muted-foreground">
|
|
{t('contextPanel.browser.devServers.unavailable')}
|
|
</span>
|
|
) : null}
|
|
</div>
|
|
);
|
|
};
|